| Message ID | 1576123908-12105-3-git-send-email-thara.gopinath@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce Thermal Pressure | expand |
On Wed, Dec 11, 2019 at 11:11:43PM -0500, Thara Gopinath wrote: > Introduce arch_scale_thermal_capacity to retrieve per cpu thermal > pressure. > > Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org> > --- > include/linux/sched/topology.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h > index f341163..f1e22f9 100644 > --- a/include/linux/sched/topology.h > +++ b/include/linux/sched/topology.h > @@ -225,6 +225,14 @@ unsigned long arch_scale_cpu_capacity(int cpu) > } > #endif > > +#ifndef arch_scale_thermal_capacity > +static __always_inline > +unsigned long arch_scale_thermal_capacity(int cpu) > +{ > + return 0; > +} > +#endif This is confusing, the return value is not a capacity, it is a reduction in capacity. Either a comment of a better name would be appreciated.
On 16/12/2019 15:35, Peter Zijlstra wrote: > On Wed, Dec 11, 2019 at 11:11:43PM -0500, Thara Gopinath wrote: minor: in subject: s/sched/sched/topology >> Introduce arch_scale_thermal_capacity to retrieve per cpu thermal >> pressure. >> >> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org> >> --- >> include/linux/sched/topology.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h >> index f341163..f1e22f9 100644 >> --- a/include/linux/sched/topology.h >> +++ b/include/linux/sched/topology.h >> @@ -225,6 +225,14 @@ unsigned long arch_scale_cpu_capacity(int cpu) >> } >> #endif >> >> +#ifndef arch_scale_thermal_capacity >> +static __always_inline >> +unsigned long arch_scale_thermal_capacity(int cpu) >> +{ >> + return 0; >> +} >> +#endif > > This is confusing, the return value is not a capacity, it is a reduction > in capacity. Either a comment of a better name would be appreciated. +1, the patch-set uses: thermal_capacity, thermal_pressure, capped_capacity.
diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index f341163..f1e22f9 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -225,6 +225,14 @@ unsigned long arch_scale_cpu_capacity(int cpu) } #endif +#ifndef arch_scale_thermal_capacity +static __always_inline +unsigned long arch_scale_thermal_capacity(int cpu) +{ + return 0; +} +#endif + static inline int task_node(const struct task_struct *p) { return cpu_to_node(task_cpu(p));
Introduce arch_scale_thermal_capacity to retrieve per cpu thermal pressure. Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org> --- include/linux/sched/topology.h | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.1.4