[for,5.1,v1,00/14] guest_base, gdbstub and Travis

Hi,

This is the current state of my random collection of fixes that didn't
make it into 5.0. The gdbstub related fixes will probably get queued
up separately (and possibly submitted for stable?) once the tree gets
re-opened. We have:

  - The linux-user guest_base rework (which enable more sanitisers)
  - A bunch of gdbstub related test fixes:
    - unix socket based debug for linux-user
    - a generic multiarch gdbstub test vase
    - some other clean-ups
  - some minor .travis updates
    - drop MacOSX from the build
    - add a diagnostic df -h to post build script

The following patches need review:

  - .travis.yml: drop MacOSX
  - .travis.yml: show free disk space at end of run
  - tests/tcg: add a multiarch linux-user gdb test
  - tests/guest-debug: use the unix socket for linux-user tests
  - gdbstub/linux-user: support debugging over a unix socket
  - gdbstub: eliminate gdbserver_fd global
  - tests/tcg: drop inferior.was_attached() test
  - tests/tcg: better trap gdb failures
  - configure: favour gdb-multiarch if we have it
  - linux-user: completely re-write init_guest_space

Alex Bennée (11):
  linux-user: completely re-write init_guest_space
  .gitignore: include common build sub-directories
  configure: favour gdb-multiarch if we have it
  tests/tcg: better trap gdb failures
  tests/tcg: drop inferior.was_attached() test
  gdbstub: eliminate gdbserver_fd global
  gdbstub/linux-user: support debugging over a unix socket
  tests/guest-debug: use the unix socket for linux-user tests
  tests/tcg: add a multiarch linux-user gdb test
  .travis.yml: show free disk space at end of run
  .travis.yml: drop MacOSX

Philippe Mathieu-Daudé (1):
  gdbstub: Introduce gdb_get_float64() to get 64-bit float registers

Richard Henderson (2):
  exec/cpu-all: Use bool for have_guest_base
  accel/tcg: Relax va restrictions on 64-bit guests

 configure                                   |   2 +-
 include/exec/cpu-all.h                      |  25 +-
 include/exec/gdbstub.h                      |  25 +-
 linux-user/qemu.h                           |  31 +-
 target/alpha/cpu-param.h                    |  15 +-
 accel/tcg/translate-all.c                   |  15 +-
 bsd-user/main.c                             |  12 +-
 gdbstub.c                                   | 120 ++++-
 linux-user/elfload.c                        | 503 ++++++++++----------
 linux-user/flatload.c                       |   6 +
 linux-user/main.c                           |  39 +-
 target/m68k/helper.c                        |   3 +-
 target/ppc/gdbstub.c                        |   4 +-
 target/ppc/translate_init.inc.c             |   2 +-
 .gitignore                                  |   1 +
 .travis.yml                                 |  29 +-
 tests/guest-debug/run-test.py               |  29 +-
 tests/tcg/aarch64/Makefile.target           |   5 +-
 tests/tcg/aarch64/gdbstub/test-sve-ioctl.py |   4 -
 tests/tcg/aarch64/gdbstub/test-sve.py       |   4 -
 tests/tcg/cris/Makefile.target              |   1 +
 tests/tcg/multiarch/Makefile.target         |  14 +
 tests/tcg/multiarch/gdbstub/sha1.py         |  81 ++++
 23 files changed, 570 insertions(+), 400 deletions(-)
 create mode 100644 tests/tcg/multiarch/gdbstub/sha1.py

-- 
2.20.1

Patchew URL: https://patchew.org/QEMU/20200423170557.31106-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH for 5.1 v1 00/14] guest_base, gdbstub and Travis
Message-id: 20200423170557.31106-1-alex.bennee@linaro.org
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200423150127.142609-1-kwolf@redhat.com -> patchew/20200423150127.142609-1-kwolf@redhat.com
 - [tag update]      patchew/20200423160036.7048-1-armbru@redhat.com -> patchew/20200423160036.7048-1-armbru@redhat.com
Switched to a new branch 'test'
689e6e8 .travis.yml: drop MacOSX
f7c8828 .travis.yml: show free disk space at end of run
c2d0ee7 tests/tcg: add a multiarch linux-user gdb test
5002abd tests/guest-debug: use the unix socket for linux-user tests
98d25bf gdbstub/linux-user: support debugging over a unix socket
37544e1 gdbstub: eliminate gdbserver_fd global
852d87f tests/tcg: drop inferior.was_attached() test
72e9645 tests/tcg: better trap gdb failures
8a161b1 gdbstub: Introduce gdb_get_float64() to get 64-bit float registers
d0f142f configure: favour gdb-multiarch if we have it
bc6da7bb .gitignore: include common build sub-directories
ad7e15b accel/tcg: Relax va restrictions on 64-bit guests
55ee255 exec/cpu-all: Use bool for have_guest_base
55dbacd linux-user: completely re-write init_guest_space

=== OUTPUT BEGIN ===
1/14 Checking commit 55dbacd6b444 (linux-user: completely re-write init_guest_space)
2/14 Checking commit 55ee255da7f6 (exec/cpu-all: Use bool for have_guest_base)
3/14 Checking commit ad7e15b42dc2 (accel/tcg: Relax va restrictions on 64-bit guests)
ERROR: Macros with complex values should be enclosed in parenthesis
#91: FILE: include/exec/cpu-all.h:182:
+# define GUEST_ADDR_MAX_  ~0ul

total: 1 errors, 0 warnings, 88 lines checked

Patch 3/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/14 Checking commit bc6da7bb0a03 (.gitignore: include common build sub-directories)
5/14 Checking commit d0f142fa8cfd (configure: favour gdb-multiarch if we have it)
6/14 Checking commit 8a161b12a736 (gdbstub: Introduce gdb_get_float64() to get 64-bit float registers)
7/14 Checking commit 72e964519511 (tests/tcg: better trap gdb failures)
8/14 Checking commit 852d87fc501d (tests/tcg: drop inferior.was_attached() test)
9/14 Checking commit 37544e18de5c (gdbstub: eliminate gdbserver_fd global)
ERROR: suspect code indent for conditional statements (2, 6)
#33: FILE: gdbstub.c:2965:
+  if (gdbserver_state.fd < 0) {
       return;

ERROR: braces {} are necessary for all arms of this statement
#80: FILE: gdbstub.c:3139:
+    if (gdb_fd < 0)
[...]

total: 2 errors, 0 warnings, 73 lines checked

Patch 9/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/14 Checking commit 98d25bf64760 (gdbstub/linux-user: support debugging over a unix socket)
ERROR: suspect code indent for conditional statements (2, 6)
#67: FILE: gdbstub.c:2966:
+  if (gdbserver_state.socket_path) {
+      unlink(gdbserver_state.socket_path);

ERROR: space required before the open parenthesis '('
#101: FILE: gdbstub.c:3087:
+    for(;;) {

ERROR: spaces required around that '-' (ctx:VxV)
#128: FILE: gdbstub.c:3114:
+    pstrcpy(sockaddr.sun_path, sizeof(sockaddr.sun_path)-1, path);
                                                         ^

total: 3 errors, 0 warnings, 228 lines checked

Patch 10/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/14 Checking commit 5002abd35782 (tests/guest-debug: use the unix socket for linux-user tests)
WARNING: line over 80 characters
#38: FILE: tests/guest-debug/run-test.py:53:
+        cmd = "%s %s -g %s %s" % (args.qemu, args.qargs, socket_name, args.binary)

total: 0 errors, 1 warnings, 34 lines checked

Patch 11/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/14 Checking commit c2d0ee78fa1d (tests/tcg: add a multiarch linux-user gdb test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
new file mode 100644

total: 0 errors, 1 warnings, 124 lines checked

Patch 12/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/14 Checking commit f7c88287e116 (.travis.yml: show free disk space at end of run)
14/14 Checking commit 689e6e8641c4 (.travis.yml: drop MacOSX)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200423170557.31106-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew URL: https://patchew.org/QEMU/20200423170557.31106-1-alex.bennee@linaro.org/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

Cleared directory 'slirp'
Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) unregistered for path 'slirp'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) unregistered for path 'ui/keycodemapdb'
make[1]: *** [/var/tmp/patchew-tester-tmp-rhig99s_/src/docker-src.2020-04-23-14.15.56.12776] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-rhig99s_/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    2m0.927s
user    0m5.275s


The full log is available at
http://patchew.org/logs/20200423170557.31106-1-alex.bennee@linaro.org/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com