diff mbox series

[2/2] panfrost: Add compatible string for bifrost

Message ID 20200611085900.49740-2-tomeu.vizoso@collabora.com
State Accepted
Commit 72ef7fe96fd20d3d0e538e165b393819f99870ad
Headers show
Series [1/2] panfrost: Make sure GPU is powered on when reading GPU_LATEST_FLUSH_ID | expand

Commit Message

Tomeu Vizoso June 11, 2020, 8:58 a.m. UTC
Mesa now supports some Bifrost devices, so enable it.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

---
 drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.21.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Heiko Stübner June 11, 2020, 9:07 a.m. UTC | #1
Am Donnerstag, 11. Juni 2020, 10:58:44 CEST schrieb Tomeu Vizoso:
> Mesa now supports some Bifrost devices, so enable it.

> 

> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

> ---

>  drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c

> index 882fecc33fdb..8ff8e140f91e 100644

> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c

> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c

> @@ -677,6 +677,7 @@ static const struct of_device_id dt_match[] = {

>  	{ .compatible = "arm,mali-t830", .data = &default_data, },

>  	{ .compatible = "arm,mali-t860", .data = &default_data, },

>  	{ .compatible = "arm,mali-t880", .data = &default_data, },

> +	{ .compatible = "arm,mali-bifrost", .data = &default_data, },

>  	{}

>  };

>  MODULE_DEVICE_TABLE(of, dt_match);


on a PX30-board (sibling of rk3326) with a 720x1280 panel and
glmark2 running all tests

Tested-by: Heiko Stuebner <heiko@sntech.de>


and as this is the generic compatible from the binding:

Reviewed-by: Heiko Stuebner <heiko@sntech.de>



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Steven Price June 19, 2020, 9 a.m. UTC | #2
On 11/06/2020 09:58, Tomeu Vizoso wrote:
> Mesa now supports some Bifrost devices, so enable it.

> 

> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>


Reviewed-by: Steven Price <steven.price@arm.com>


I've also dug out my Hikey960 (from the box it's been in since lock down 
started), so I'll see if I can get things running on there, at the 
moment I'm seeing some DATA_INVALID_FAULT regressions running my hacked 
DDK :(

Steve

> ---

>   drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c

> index 882fecc33fdb..8ff8e140f91e 100644

> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c

> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c

> @@ -677,6 +677,7 @@ static const struct of_device_id dt_match[] = {

>   	{ .compatible = "arm,mali-t830", .data = &default_data, },

>   	{ .compatible = "arm,mali-t860", .data = &default_data, },

>   	{ .compatible = "arm,mali-t880", .data = &default_data, },

> +	{ .compatible = "arm,mali-bifrost", .data = &default_data, },

>   	{}

>   };

>   MODULE_DEVICE_TABLE(of, dt_match);

> 


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Tomeu Vizoso Oct. 5, 2020, 6:44 a.m. UTC | #3
On Fri, 19 Jun 2020 at 11:00, Steven Price <steven.price@arm.com> wrote:
>

> On 11/06/2020 09:58, Tomeu Vizoso wrote:

> > Mesa now supports some Bifrost devices, so enable it.

> >

> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

>

> Reviewed-by: Steven Price <steven.price@arm.com>

>

> I've also dug out my Hikey960 (from the box it's been in since lock down

> started), so I'll see if I can get things running on there, at the

> moment I'm seeing some DATA_INVALID_FAULT regressions running my hacked

> DDK :(


Hi!

Has this one fallen through the cracks?

Thanks,

Tomeu

>

> Steve

>

> > ---

> >   drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +

> >   1 file changed, 1 insertion(+)

> >

> > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c

> > index 882fecc33fdb..8ff8e140f91e 100644

> > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c

> > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c

> > @@ -677,6 +677,7 @@ static const struct of_device_id dt_match[] = {

> >       { .compatible = "arm,mali-t830", .data = &default_data, },

> >       { .compatible = "arm,mali-t860", .data = &default_data, },

> >       { .compatible = "arm,mali-t880", .data = &default_data, },

> > +     { .compatible = "arm,mali-bifrost", .data = &default_data, },

> >       {}

> >   };

> >   MODULE_DEVICE_TABLE(of, dt_match);

> >

>

> _______________________________________________

> dri-devel mailing list

> dri-devel@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Tomeu Vizoso Oct. 5, 2020, 7:06 a.m. UTC | #4
On Mon, 5 Oct 2020 at 08:44, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
>

> On Fri, 19 Jun 2020 at 11:00, Steven Price <steven.price@arm.com> wrote:

> >

> > On 11/06/2020 09:58, Tomeu Vizoso wrote:

> > > Mesa now supports some Bifrost devices, so enable it.

> > >

> > > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

> >

> > Reviewed-by: Steven Price <steven.price@arm.com>

> >

> > I've also dug out my Hikey960 (from the box it's been in since lock down

> > started), so I'll see if I can get things running on there, at the

> > moment I'm seeing some DATA_INVALID_FAULT regressions running my hacked

> > DDK :(

>

> Hi!

>

> Has this one fallen through the cracks?


Oops, sorry about the noise, I had an old checkout.

Cheers,

Tomeu

> Thanks,

>

> Tomeu

>

> >

> > Steve

> >

> > > ---

> > >   drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +

> > >   1 file changed, 1 insertion(+)

> > >

> > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c

> > > index 882fecc33fdb..8ff8e140f91e 100644

> > > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c

> > > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c

> > > @@ -677,6 +677,7 @@ static const struct of_device_id dt_match[] = {

> > >       { .compatible = "arm,mali-t830", .data = &default_data, },

> > >       { .compatible = "arm,mali-t860", .data = &default_data, },

> > >       { .compatible = "arm,mali-t880", .data = &default_data, },

> > > +     { .compatible = "arm,mali-bifrost", .data = &default_data, },

> > >       {}

> > >   };

> > >   MODULE_DEVICE_TABLE(of, dt_match);

> > >

> >

> > _______________________________________________

> > dri-devel mailing list

> > dri-devel@lists.freedesktop.org

> > https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
index 882fecc33fdb..8ff8e140f91e 100644
--- a/drivers/gpu/drm/panfrost/panfrost_drv.c
+++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
@@ -677,6 +677,7 @@  static const struct of_device_id dt_match[] = {
 	{ .compatible = "arm,mali-t830", .data = &default_data, },
 	{ .compatible = "arm,mali-t860", .data = &default_data, },
 	{ .compatible = "arm,mali-t880", .data = &default_data, },
+	{ .compatible = "arm,mali-bifrost", .data = &default_data, },
 	{}
 };
 MODULE_DEVICE_TABLE(of, dt_match);