| Message ID | 1586353273-12255-4-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/7] riscv: qemu: Remove the simple-bus driver for the SoC node | expand |
On 4/8/20 9:41 AM, Bin Meng wrote: > U-Boot proper running in S-mode only need SMP support when using > SBI v0.1. With SBI v0.2 HSM extension, it does not need implement > multicore boot in U-Boot proper. > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com> > --- > > arch/riscv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 10478ae..502143f 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -193,6 +193,7 @@ config SYS_MALLOC_F_LEN > > config SMP > bool "Symmetric Multi-Processing" > + depends on SBI_V01 So should this be "depends on SBI_V01 or RISCV_PRIV_1_9" when the priv spec 1.9 patch gets merged? > help > This enables support for systems with more than one CPU. If > you say N here, U-Boot will run on single and multiprocessor > --Sean
Hi Sean > From: Sean Anderson [mailto:seanga2 at gmail.com] > Sent: Wednesday, April 08, 2020 10:21 PM > To: Bin Meng; Rick Jian-Zhi Chen(???); Lukas Auer; Anup Patel; Atish Patra; Pragnesh Patel; U-Boot Mailing List > Subject: Re: [PATCH 4/7] riscv: Add SMP Kconfig option dependency for U-Boot proper > > On 4/8/20 9:41 AM, Bin Meng wrote: > > U-Boot proper running in S-mode only need SMP support when using SBI > > v0.1. With SBI v0.2 HSM extension, it does not need implement > > multicore boot in U-Boot proper. > > > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com> > > --- > > > > arch/riscv/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index > > 10478ae..502143f 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -193,6 +193,7 @@ config SYS_MALLOC_F_LEN > > > > config SMP > > bool "Symmetric Multi-Processing" > > + depends on SBI_V01 > > So should this be > > "depends on SBI_V01 or RISCV_PRIV_1_9" > > when the priv spec 1.9 patch gets merged? > Your series: [v7,22/22] riscv: Add Sipeed Maix support There are some patchs still need to be fixed: [v7,22/22] riscv: Add Sipeed Maix support https://patchwork.ozlabs.org/patch/1258463/ [v7,15/22] riscv: Clean up IPI initialization code https://patchwork.ozlabs.org/patch/1258461/ And there are two patchs about clk still get no positive response from clk maintainer [v7,05/22] clk: Add functions to register CCF clock structs https://patchwork.ozlabs.org/patch/1258446/ [v7,04/22] clk: Fix clk_get_by_* handling of index https://patchwork.ozlabs.org/patch/1258442/ Thanks Rick > > help > > This enables support for systems with more than one CPU. If > > you say N here, U-Boot will run on single and multiprocessor > > > > --Sean >
On 4/10/20 4:27 AM, Rick Chen wrote: > Hi Sean > >> From: Sean Anderson [mailto:seanga2 at gmail.com] >> Sent: Wednesday, April 08, 2020 10:21 PM >> To: Bin Meng; Rick Jian-Zhi Chen(???); Lukas Auer; Anup Patel; Atish Patra; Pragnesh Patel; U-Boot Mailing List >> Subject: Re: [PATCH 4/7] riscv: Add SMP Kconfig option dependency for U-Boot proper >> >> On 4/8/20 9:41 AM, Bin Meng wrote: >>> U-Boot proper running in S-mode only need SMP support when using SBI >>> v0.1. With SBI v0.2 HSM extension, it does not need implement >>> multicore boot in U-Boot proper. >>> >>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com> >>> --- >>> >>> arch/riscv/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index >>> 10478ae..502143f 100644 >>> --- a/arch/riscv/Kconfig >>> +++ b/arch/riscv/Kconfig >>> @@ -193,6 +193,7 @@ config SYS_MALLOC_F_LEN >>> >>> config SMP >>> bool "Symmetric Multi-Processing" >>> + depends on SBI_V01 >> >> So should this be >> >> "depends on SBI_V01 or RISCV_PRIV_1_9" >> >> when the priv spec 1.9 patch gets merged? >> > > Your series: [v7,22/22] riscv: Add Sipeed Maix support > > There are some patchs still need to be fixed: > > [v7,22/22] riscv: Add Sipeed Maix support > https://patchwork.ozlabs.org/patch/1258463/ > > [v7,15/22] riscv: Clean up IPI initialization code > https://patchwork.ozlabs.org/patch/1258461/ > > And there are two patchs about clk still get no positive response from > clk maintainer > > [v7,05/22] clk: Add functions to register CCF clock structs > https://patchwork.ozlabs.org/patch/1258446/ > > [v7,04/22] clk: Fix clk_get_by_* handling of index > https://patchwork.ozlabs.org/patch/1258442/ Yeah, I was waiting on a response wrt those patches before doing v8. I may try reworking the series so the first patch is unnecessary, but I don't think that will be possible with the second patch. I'm working on other projects at the moment, so I don't know if I'll have time to do that. --Sean
On Wed, Apr 8, 2020 at 6:42 AM Bin Meng <bmeng.cn at gmail.com> wrote: > > U-Boot proper running in S-mode only need SMP support when using > SBI v0.1. With SBI v0.2 HSM extension, it does not need implement > multicore boot in U-Boot proper. > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com> > --- > > arch/riscv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 10478ae..502143f 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -193,6 +193,7 @@ config SYS_MALLOC_F_LEN > > config SMP > bool "Symmetric Multi-Processing" > + depends on SBI_V01 What about RISCV_MMODE ? > help > This enables support for systems with more than one CPU. If > you say N here, U-Boot will run on single and multiprocessor > -- > 2.7.4 >
On Sat, Apr 11, 2020 at 7:55 AM Atish Patra <atishp at atishpatra.org> wrote: > > On Wed, Apr 8, 2020 at 6:42 AM Bin Meng <bmeng.cn at gmail.com> wrote: > > > > U-Boot proper running in S-mode only need SMP support when using > > SBI v0.1. With SBI v0.2 HSM extension, it does not need implement > > multicore boot in U-Boot proper. > > > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com> > > --- > > > > arch/riscv/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > index 10478ae..502143f 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -193,6 +193,7 @@ config SYS_MALLOC_F_LEN > > > > config SMP > > bool "Symmetric Multi-Processing" > > + depends on SBI_V01 > > What about RISCV_MMODE ? Yes this needs to be considered. > > > help > > This enables support for systems with more than one CPU. If > > you say N here, U-Boot will run on single and multiprocessor Regards, Bin
Hi Sean, On Wed, Apr 8, 2020 at 10:20 PM Sean Anderson <seanga2 at gmail.com> wrote: > > On 4/8/20 9:41 AM, Bin Meng wrote: > > U-Boot proper running in S-mode only need SMP support when using > > SBI v0.1. With SBI v0.2 HSM extension, it does not need implement > > multicore boot in U-Boot proper. > > > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com> > > --- > > > > arch/riscv/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > index 10478ae..502143f 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -193,6 +193,7 @@ config SYS_MALLOC_F_LEN > > > > config SMP > > bool "Symmetric Multi-Processing" > > + depends on SBI_V01 > > So should this be > > "depends on SBI_V01 or RISCV_PRIV_1_9" > > when the priv spec 1.9 patch gets merged? I will change the dependency only when U-Boot is working in S-mode. For M-mode, this dependency will not be added. > > > help > > This enables support for systems with more than one CPU. If > > you say N here, U-Boot will run on single and multiprocessor > > Regards, Bin
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 10478ae..502143f 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -193,6 +193,7 @@ config SYS_MALLOC_F_LEN config SMP bool "Symmetric Multi-Processing" + depends on SBI_V01 help This enables support for systems with more than one CPU. If you say N here, U-Boot will run on single and multiprocessor
U-Boot proper running in S-mode only need SMP support when using SBI v0.1. With SBI v0.2 HSM extension, it does not need implement multicore boot in U-Boot proper. Signed-off-by: Bin Meng <bmeng.cn at gmail.com> --- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+)