diff mbox series

[v2,3/5] wandboard: Do not print error when PMIC is not present

Message ID 20200417122713.30574-3-festevam@gmail.com
State Accepted
Commit b8e74fc8dbb6335f614c45257c330eba07e3e3b4
Headers show
Series [v2,1/5] wandboard: Fix version detection for mx6q/mx6dl revD1 | expand

Commit Message

Fabio Estevam April 17, 2020, 12:27 p.m. UTC
On wandboard variants prior to revD1, there is no PMIC populated, so
do not print an error when the reading of the device ID register fails.

Signed-off-by: Fabio Estevam <festevam at gmail.com>
---
Changes since v1:
- None

 board/wandboard/wandboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Schocher April 17, 2020, 2:51 p.m. UTC | #1
Hello Fabio,

Am 17.04.2020 um 14:27 schrieb Fabio Estevam:
> On wandboard variants prior to revD1, there is no PMIC populated, so
> do not print an error when the reading of the device ID register fails.
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
> Changes since v1:
> - None
> 
>   board/wandboard/wandboard.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Heiko Schocher <hs at denx.de>

Thanks!

bye,
Heiko
> 
> diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
> index 90957167b2..7fd60682a5 100644
> --- a/board/wandboard/wandboard.c
> +++ b/board/wandboard/wandboard.c
> @@ -369,7 +369,7 @@ int power_init_board(void)
>   
>   	reg = pmic_reg_read(dev, PFUZE100_DEVICEID);
>   	if (reg < 0) {
> -		printf("pmic_reg_read() ret %d\n", reg);
> +		debug("pmic_reg_read() ret %d\n", reg);
>   		return 0;
>   	}
>   	printf("PMIC:  PFUZE100 ID=0x%02x\n", reg);
>
Stefano Babic April 19, 2020, 9:09 a.m. UTC | #2
> On wandboard variants prior to revD1, there is no PMIC populated, so
> do not print an error when the reading of the device ID register fails.
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> Tested-by: Heiko Schocher <hs at denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 90957167b2..7fd60682a5 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -369,7 +369,7 @@  int power_init_board(void)
 
 	reg = pmic_reg_read(dev, PFUZE100_DEVICEID);
 	if (reg < 0) {
-		printf("pmic_reg_read() ret %d\n", reg);
+		debug("pmic_reg_read() ret %d\n", reg);
 		return 0;
 	}
 	printf("PMIC:  PFUZE100 ID=0x%02x\n", reg);