diff mbox series

[v2,1/2] mx7ulp: Remove duplicated definitions

Message ID 20200203120109.11287-1-festevam@gmail.com
State Accepted
Commit 2cfdb3bca7c452942fe6513b3ea12a45d5c58564
Headers show
Series [v2,1/2] mx7ulp: Remove duplicated definitions | expand

Commit Message

Fabio Estevam Feb. 3, 2020, 12:01 p.m. UTC
These PMC0 definitions are already defined in the beginning
of the file, so remove the duplication.

Reported-by: Stefano Babic <sbabic at denx.de>
Signed-off-by: Fabio Estevam <festevam at gmail.com>
---
Changes since v1:
- Newly introduced in this version.

 arch/arm/mach-imx/mx7ulp/soc.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Peng Fan Feb. 3, 2020, 12:10 p.m. UTC | #1
> Subject: [PATCH v2 1/2] mx7ulp: Remove duplicated definitions
> 
> These PMC0 definitions are already defined in the beginning of the file, so
> remove the duplication.
> 
> Reported-by: Stefano Babic <sbabic at denx.de>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

Reviewed-by: Peng Fan <peng.fan at nxp.com>

> ---
> Changes since v1:
> - Newly introduced in this version.
> 
>  arch/arm/mach-imx/mx7ulp/soc.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mx7ulp/soc.c
> b/arch/arm/mach-imx/mx7ulp/soc.c index 46484813d2..d8d691692c 100644
> --- a/arch/arm/mach-imx/mx7ulp/soc.c
> +++ b/arch/arm/mach-imx/mx7ulp/soc.c
> @@ -193,10 +193,6 @@ const char *get_imx_type(u32 imxtype)
>  	return "7ULP";
>  }
> 
> -#define PMC0_BASE_ADDR		0x410a1000
> -#define PMC0_CTRL		0x28
> -#define PMC0_CTRL_LDOEN		BIT(31)
> -
>  static bool ldo_mode_is_enabled(void)
>  {
>  	unsigned int reg;
> --
> 2.17.1
Stefano Babic April 18, 2020, 10:51 a.m. UTC | #2
> These PMC0 definitions are already defined in the beginning
> of the file, so remove the duplication.
> Reported-by: Stefano Babic <sbabic at denx.de>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> Reviewed-by: Peng Fan <peng.fan at nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/mx7ulp/soc.c b/arch/arm/mach-imx/mx7ulp/soc.c
index 46484813d2..d8d691692c 100644
--- a/arch/arm/mach-imx/mx7ulp/soc.c
+++ b/arch/arm/mach-imx/mx7ulp/soc.c
@@ -193,10 +193,6 @@  const char *get_imx_type(u32 imxtype)
 	return "7ULP";
 }
 
-#define PMC0_BASE_ADDR		0x410a1000
-#define PMC0_CTRL		0x28
-#define PMC0_CTRL_LDOEN		BIT(31)
-
 static bool ldo_mode_is_enabled(void)
 {
 	unsigned int reg;