| Message ID | 20200106231128.27661-2-festevam@gmail.com |
|---|---|
| State | Accepted |
| Commit | 80d37c7959672aeba9e170844b3b1d3284aa7090 |
| Headers | show |
| Series | [1/2] mmc: fsl_esdhc_imx: Handle the "broken-cd" property | expand |
On 07/01/20 00:11, Fabio Estevam wrote: > imx6ul-14x14-evk does not have a GPIO dedicated for reading the card > detect pin on the eSDHC2 port. In such cases the "broken-cd" property > must be passed, otherwise the card cannot be detected. > > Signed-off-by: Fabio Estevam <festevam at gmail.com> > --- > arch/arm/dts/imx6ul-14x14-evk.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/dts/imx6ul-14x14-evk.dtsi b/arch/arm/dts/imx6ul-14x14-evk.dtsi > index d1baf0f081..463d7ca124 100644 > --- a/arch/arm/dts/imx6ul-14x14-evk.dtsi > +++ b/arch/arm/dts/imx6ul-14x14-evk.dtsi > @@ -268,6 +268,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usdhc2>; > no-1-8-v; > + broken-cd; > keep-power-in-suspend; > wakeup-source; > status = "okay"; > Reviewed-by: Stefano Babic <sbabic at denx.de> Best regards, Stefano Babic
Hi Fabio, > Subject: [PATCH 2/2] ARM: dts: imx6ul-14x14-evk: Pass the "broken-cd" > property > > imx6ul-14x14-evk does not have a GPIO dedicated for reading the card detect > pin on the eSDHC2 port. In such cases the "broken-cd" property must be > passed, otherwise the card cannot be detected. > > Signed-off-by: Fabio Estevam <festevam at gmail.com> > --- > arch/arm/dts/imx6ul-14x14-evk.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/dts/imx6ul-14x14-evk.dtsi > b/arch/arm/dts/imx6ul-14x14-evk.dtsi > index d1baf0f081..463d7ca124 100644 > --- a/arch/arm/dts/imx6ul-14x14-evk.dtsi > +++ b/arch/arm/dts/imx6ul-14x14-evk.dtsi > @@ -268,6 +268,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usdhc2>; > no-1-8-v; > + broken-cd; Has this been in Kernel dts? Thanks, Peng. > keep-power-in-suspend; > wakeup-source; > status = "okay"; > -- > 2.17.1
Hi Peng,
On Tue, Jan 7, 2020 at 10:12 PM Peng Fan <peng.fan at nxp.com> wrote:
> Has this been in Kernel dts?
I have sent a patch to add 'broken-cd' in the kernel dts:
http://lists.infradead.org/pipermail/linux-arm-kernel/2020-January/703473.html
Hi Peng, On Tue, Jan 7, 2020 at 10:13 PM Fabio Estevam <festevam at gmail.com> wrote: > > Hi Peng, > > On Tue, Jan 7, 2020 at 10:12 PM Peng Fan <peng.fan at nxp.com> wrote: > > > Has this been in Kernel dts? > > I have sent a patch to add 'broken-cd' in the kernel dts: > http://lists.infradead.org/pipermail/linux-arm-kernel/2020-January/703473.html Just to let you know that the dts patch has been applied: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=for-next&id=3b49b6cde5136972dfa417112a11583a6924204a
> imx6ul-14x14-evk does not have a GPIO dedicated for reading the card > detect pin on the eSDHC2 port. In such cases the "broken-cd" property > must be passed, otherwise the card cannot be detected. > Signed-off-by: Fabio Estevam <festevam at gmail.com> > Reviewed-by: Stefano Babic <sbabic at denx.de> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/dts/imx6ul-14x14-evk.dtsi b/arch/arm/dts/imx6ul-14x14-evk.dtsi index d1baf0f081..463d7ca124 100644 --- a/arch/arm/dts/imx6ul-14x14-evk.dtsi +++ b/arch/arm/dts/imx6ul-14x14-evk.dtsi @@ -268,6 +268,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_usdhc2>; no-1-8-v; + broken-cd; keep-power-in-suspend; wakeup-source; status = "okay";
imx6ul-14x14-evk does not have a GPIO dedicated for reading the card detect pin on the eSDHC2 port. In such cases the "broken-cd" property must be passed, otherwise the card cannot be detected. Signed-off-by: Fabio Estevam <festevam at gmail.com> --- arch/arm/dts/imx6ul-14x14-evk.dtsi | 1 + 1 file changed, 1 insertion(+)