diff mbox series

[v2,18/21] tools: binman: add etype file for u-boot-lzma-img

Message ID 1579247168-491-1-git-send-email-weijie.gao@mediatek.com
State Superseded
Headers show
Series None | expand

Commit Message

Weijie Gao Jan. 17, 2020, 7:46 a.m. UTC 
This patch adds etype u-boot-lzma-img for binman. README.entries is also
updated.

Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
---
Changes since v1: updated README.entries, modified copyright and description.
---
 tools/binman/README.entries           | 15 ++++++++++++++
 tools/binman/etype/u_boot_lzma_img.py | 28 +++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 tools/binman/etype/u_boot_lzma_img.py

Comments

Simon Glass Jan. 30, 2020, 2:18 a.m. UTC | #1 
Hi Weijie,

On Fri, 17 Jan 2020 at 00:46, Weijie Gao <weijie.gao at mediatek.com> wrote:
>
> This patch adds etype u-boot-lzma-img for binman. README.entries is also
> updated.
>
> Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
> ---
> Changes since v1: updated README.entries, modified copyright and description.
> ---
>  tools/binman/README.entries           | 15 ++++++++++++++
>  tools/binman/etype/u_boot_lzma_img.py | 28 +++++++++++++++++++++++++++
>  2 files changed, 43 insertions(+)
>  create mode 100644 tools/binman/etype/u_boot_lzma_img.py

Please also add a test for this, so that 'binman test -T' passes. We
need to maintain 100% code coverage in this tool.

Regards,
Simon
diff mbox series

Patch

diff --git a/tools/binman/README.entries b/tools/binman/README.entries
index 6a816bba6b..0aea9b8f6d 100644
--- a/tools/binman/README.entries
+++ b/tools/binman/README.entries
@@ -747,6 +747,21 @@  applications.
 
 
 
+Entry: u-boot-lzma-img: U-Boot legacy image with contents compressed by LZMA
+----------------------------------------------------------------------------
+
+Properties / Entry arguments:
+    - filename: Filename of u-boot-lzma.img (default 'u-boot-lzma.img')
+
+This is the U-Boot binary as a packaged image, in legacy format. It has a
+header which allows it to be loaded at the correct address for execution.
+Its contents are compressed by LZMA.
+
+You should use FIT (Flat Image Tree) instead of the legacy image for new
+applications.
+
+
+
 Entry: u-boot-nodtb: U-Boot flat binary without device tree appended
 --------------------------------------------------------------------
 
diff --git a/tools/binman/etype/u_boot_lzma_img.py b/tools/binman/etype/u_boot_lzma_img.py
new file mode 100644
index 0000000000..966d6a46da
--- /dev/null
+++ b/tools/binman/etype/u_boot_lzma_img.py
@@ -0,0 +1,28 @@ 
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2020 MediaTek Inc. All Rights Reserved.
+# Author: Weijie Gao <weijie.gao at mediatek.com>
+#
+# Entry-type module for U-Boot legacy image with contents compressed by LZMA
+#
+
+from entry import Entry
+from blob import Entry_blob
+
+class Entry_u_boot_lzma_img(Entry_blob):
+    """U-Boot legacy image with contents compressed by LZMA
+
+    Properties / Entry arguments:
+        - filename: Filename of u-boot-lzma.img (default 'u-boot-lzma.img')
+
+    This is the U-Boot binary as a packaged image, in legacy format. It has a
+    header which allows it to be loaded at the correct address for execution.
+    Its contents are compressed by LZMA.
+
+    You should use FIT (Flat Image Tree) instead of the legacy image for new
+    applications.
+    """
+    def __init__(self, section, etype, node):
+        Entry_blob.__init__(self, section, etype, node)
+
+    def GetDefaultFilename(self):
+        return 'u-boot-lzma.img'