| Message ID | d3b93a74e66fa5ccf202cb0a606324b681276b58.1594304267.git.michal.simek@xilinx.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | serial: Fix SIFIVE debug serial dependency | expand |
Hi Michal, On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek at xilinx.com> wrote: > > The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > debug consoles") has added incorrect dependency for SIFIVE debug uart which > should depend on SIFIVE driver instead of PL01x. Does that mean this should have a Fixes: tag? > > Signed-off-by: Michal Simek <michal.simek at xilinx.com> > --- > > drivers/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Regards, Simon
Hi Simon, On 10. 07. 20 2:35, Simon Glass wrote: > Hi Michal, > > On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek at xilinx.com> wrote: >> >> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for >> debug consoles") has added incorrect dependency for SIFIVE debug uart which >> should depend on SIFIVE driver instead of PL01x. > > Does that mean this should have a Fixes: tag? TBH I had it there but removed it because commit is pointing to it anyway. And also I am not aware about any stable process in place. Or is there any process around that people are looking for fixed tags and picking them to any u-boot stable tree? Thanks, Michal
On Fri, 10 Jul 2020 at 00:21, Michal Simek <michal.simek at xilinx.com> wrote: > > Hi Simon, > > On 10. 07. 20 2:35, Simon Glass wrote: > > Hi Michal, > > > > On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek at xilinx.com> wrote: > >> > >> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > >> debug consoles") has added incorrect dependency for SIFIVE debug uart which > >> should depend on SIFIVE driver instead of PL01x. > > > > Does that mean this should have a Fixes: tag? > > TBH I had it there but removed it because commit is pointing to it > anyway. And also I am not aware about any stable process in place. > Or is there any process around that people are looking for fixed tags > and picking them to any u-boot stable tree? > +Tom Rini who may know
On Tue, Jul 14, 2020 at 07:05:54PM -0600, Simon Glass wrote: > On Fri, 10 Jul 2020 at 00:21, Michal Simek <michal.simek at xilinx.com> wrote: > > > > Hi Simon, > > > > On 10. 07. 20 2:35, Simon Glass wrote: > > > Hi Michal, > > > > > > On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek at xilinx.com> wrote: > > >> > > >> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > > >> debug consoles") has added incorrect dependency for SIFIVE debug uart which > > >> should depend on SIFIVE driver instead of PL01x. > > > > > > Does that mean this should have a Fixes: tag? > > > > TBH I had it there but removed it because commit is pointing to it > > anyway. And also I am not aware about any stable process in place. > > Or is there any process around that people are looking for fixed tags > > and picking them to any u-boot stable tree? > > +Tom Rini who may know We do fixes tags because it's good history.
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 17d0e7362379..006cb5a50140 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX config DEBUG_UART_SIFIVE bool "SiFive UART" - depends on PL01X_SERIAL + depends on SIFIVE_SERIAL help Select this to enable a debug UART using the serial_sifive driver. You will need to provide parameters to make this work. The driver will
The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") has added incorrect dependency for SIFIVE debug uart which should depend on SIFIVE driver instead of PL01x. Signed-off-by: Michal Simek <michal.simek at xilinx.com> --- drivers/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)