| Message ID | 20200611110321.9574-3-andre.przywara@arm.com |
|---|---|
| State | Accepted |
| Commit | f1dd05bc347b2dc6adb7d49e824b6696d090fb91 |
| Headers | show |
| Series | arm: Juno board updates and PCIe/SATA enablement | expand |
On Thu, Jun 11, 2020 at 2:05 PM Andre Przywara <andre.przywara at arm.com> wrote: > > Similar to patch 821fec0ceb3e ("net: remove scary warning about EEPROM > provided MAC address") this removes the somewhat awkward "warning" on > boards using DM_ETH: > In many parts of the computing world having a unique MAC address > sitting in some on-NIC storage is considered the normal case. > > If there is a properly provided MAC address (either from ROM or from DT), > remove the warning to not scare the user unnecessarily. > > Signed-off-by: Andre Przywara <andre.przywara at arm.com> > --- > net/eth-uclass.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/eth-uclass.c b/net/eth-uclass.c > index 7f89f65c92..0d9b75a9a2 100644 > --- a/net/eth-uclass.c > +++ b/net/eth-uclass.c > @@ -560,8 +560,6 @@ static int eth_post_probe(struct udevice *dev) > memcpy(pdata->enetaddr, env_enetaddr, ARP_HLEN); > } else if (is_valid_ethaddr(pdata->enetaddr)) { > eth_env_set_enetaddr_by_index("eth", dev->seq, pdata->enetaddr); > - printf("\nWarning: %s using MAC address from %s\n", > - dev->name, source); > } else if (is_zero_ethaddr(pdata->enetaddr) || > !is_valid_ethaddr(pdata->enetaddr)) { > #ifdef CONFIG_NET_RANDOM_ETHADDR > -- > 2.17.5 > Reviewed-By: Ramon Fried <rfried.dev at gmail.com>
On Thu, Jun 11, 2020 at 1:04 PM Andre Przywara <andre.przywara at arm.com> wrote: > Similar to patch 821fec0ceb3e ("net: remove scary warning about EEPROM > provided MAC address") this removes the somewhat awkward "warning" on > boards using DM_ETH: > In many parts of the computing world having a unique MAC address > sitting in some on-NIC storage is considered the normal case. > > If there is a properly provided MAC address (either from ROM or from DT), > remove the warning to not scare the user unnecessarily. > > Signed-off-by: Andre Przywara <andre.przywara at arm.com> Reviewed-by: Linus Walleij <linus.walleij at linaro.org> Yours, Linus Walleij
diff --git a/net/eth-uclass.c b/net/eth-uclass.c index 7f89f65c92..0d9b75a9a2 100644 --- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -560,8 +560,6 @@ static int eth_post_probe(struct udevice *dev) memcpy(pdata->enetaddr, env_enetaddr, ARP_HLEN); } else if (is_valid_ethaddr(pdata->enetaddr)) { eth_env_set_enetaddr_by_index("eth", dev->seq, pdata->enetaddr); - printf("\nWarning: %s using MAC address from %s\n", - dev->name, source); } else if (is_zero_ethaddr(pdata->enetaddr) || !is_valid_ethaddr(pdata->enetaddr)) { #ifdef CONFIG_NET_RANDOM_ETHADDR
Similar to patch 821fec0ceb3e ("net: remove scary warning about EEPROM provided MAC address") this removes the somewhat awkward "warning" on boards using DM_ETH: In many parts of the computing world having a unique MAC address sitting in some on-NIC storage is considered the normal case. If there is a properly provided MAC address (either from ROM or from DT), remove the warning to not scare the user unnecessarily. Signed-off-by: Andre Przywara <andre.przywara at arm.com> --- net/eth-uclass.c | 2 -- 1 file changed, 2 deletions(-)