| Message ID | 20200313174248.925841-2-otavio@ossystems.com.br |
|---|---|
| State | Accepted |
| Commit | af84b3327ad269ffefcd66ddff2f5dea5eff38f8 |
| Headers | show |
| Series | Fixes for rv1108 and rv1108-elgin-r1 | expand |
Hi Otavio, On 2020/3/14 ??1:42, Otavio Salvador wrote: > In order to make the console pins more robust to noise, activate > the pullups and increase its drive strength. > > Signed-off-by: Otavio Salvador <otavio at ossystems.com.br> Reviewed-by: Kever Yang <kever.yang at rock-chips.com> Thanks, - Kever > --- > > arch/arm/dts/rv1108-elgin-r1.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/dts/rv1108-elgin-r1.dts b/arch/arm/dts/rv1108-elgin-r1.dts > index 32b95940b0..83e8b31838 100644 > --- a/arch/arm/dts/rv1108-elgin-r1.dts > +++ b/arch/arm/dts/rv1108-elgin-r1.dts > @@ -40,9 +40,20 @@ > }; > > &uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart2m0_xfer_pullup>; > status = "okay"; > }; > > &usb20_otg { > status = "okay"; > }; > + > +&pinctrl { > + uart2m0 { > + uart2m0_xfer_pullup: uart2m0-xfer-pullup { > + rockchip,pins = <2 RK_PD2 RK_FUNC_1 &pcfg_pull_up_drv_8ma>, > + <2 RK_PD1 RK_FUNC_1 &pcfg_pull_up_drv_8ma>; > + }; > + }; > +};
Ping? On Tue, Mar 17, 2020 at 10:50 PM Kever Yang <kever.yang at rock-chips.com> wrote: > > Hi Otavio, > > > On 2020/3/14 ??1:42, Otavio Salvador wrote: > > In order to make the console pins more robust to noise, activate > > the pullups and increase its drive strength. > > > > Signed-off-by: Otavio Salvador <otavio at ossystems.com.br> > > > Reviewed-by: Kever Yang <kever.yang at rock-chips.com> > > Thanks, > - Kever > > --- > > > > arch/arm/dts/rv1108-elgin-r1.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/dts/rv1108-elgin-r1.dts b/arch/arm/dts/rv1108-elgin-r1.dts > > index 32b95940b0..83e8b31838 100644 > > --- a/arch/arm/dts/rv1108-elgin-r1.dts > > +++ b/arch/arm/dts/rv1108-elgin-r1.dts > > @@ -40,9 +40,20 @@ > > }; > > > > &uart2 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&uart2m0_xfer_pullup>; > > status = "okay"; > > }; > > > > &usb20_otg { > > status = "okay"; > > }; > > + > > +&pinctrl { > > + uart2m0 { > > + uart2m0_xfer_pullup: uart2m0-xfer-pullup { > > + rockchip,pins = <2 RK_PD2 RK_FUNC_1 &pcfg_pull_up_drv_8ma>, > > + <2 RK_PD1 RK_FUNC_1 &pcfg_pull_up_drv_8ma>; > > + }; > > + }; > > +}; > >
diff --git a/arch/arm/dts/rv1108-elgin-r1.dts b/arch/arm/dts/rv1108-elgin-r1.dts index 32b95940b0..83e8b31838 100644 --- a/arch/arm/dts/rv1108-elgin-r1.dts +++ b/arch/arm/dts/rv1108-elgin-r1.dts @@ -40,9 +40,20 @@ }; &uart2 { + pinctrl-names = "default"; + pinctrl-0 = <&uart2m0_xfer_pullup>; status = "okay"; }; &usb20_otg { status = "okay"; }; + +&pinctrl { + uart2m0 { + uart2m0_xfer_pullup: uart2m0-xfer-pullup { + rockchip,pins = <2 RK_PD2 RK_FUNC_1 &pcfg_pull_up_drv_8ma>, + <2 RK_PD1 RK_FUNC_1 &pcfg_pull_up_drv_8ma>; + }; + }; +};
In order to make the console pins more robust to noise, activate the pullups and increase its drive strength. Signed-off-by: Otavio Salvador <otavio at ossystems.com.br> --- arch/arm/dts/rv1108-elgin-r1.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)