| Message ID | 20200517162425.76584-15-marek.vasut+renesas@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [01/15] net: pcnet: Drop typedef struct pcnet_priv_t | expand |
Am 17.05.20 um 18:24 schrieb Marek Vasut: > Add Kconfig entries for the pcnet driver and convert MIPS malta > to use those. > > Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com> > Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com> > Cc: Joe Hershberger <joe.hershberger at ni.com> > --- > configs/malta_defconfig | 1 + > drivers/net/Kconfig | 6 ++++++ > include/configs/malta.h | 1 - > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/configs/malta_defconfig b/configs/malta_defconfig > index 2b43818c81..0680f595db 100644 > --- a/configs/malta_defconfig > +++ b/configs/malta_defconfig > @@ -26,6 +26,7 @@ CONFIG_MTD_NOR_FLASH=y > CONFIG_FLASH_CFI_DRIVER=y > CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y > CONFIG_SYS_FLASH_CFI=y > +CONFIG_PCNET=y > CONFIG_PCI=y > CONFIG_RTC_MC146818=y > CONFIG_SYS_NS16550=y we have four Malta defconfigs to get build coverage for MIPS32/64 and LE/BE. Thus you need to update all of them. $ ls -1 configs/malta* configs/malta64_defconfig configs/malta64el_defconfig configs/malta_defconfig configs/maltael_defconfig > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index f7855c92d3..cef3b5c0de 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -377,6 +377,12 @@ config MII > help > Enable support of the Media-Independent Interface (MII) > > +config PCNET > + bool "AMD PCnet series Ethernet controller driver" > + help > + This driver supports AMD PCnet series fast ethernet family of > + PCI chipsets/adapters. > + > config RTL8139 > bool "Realtek 8139 series Ethernet controller driver" > help > diff --git a/include/configs/malta.h b/include/configs/malta.h > index 82c90042d9..9602773ff9 100644 > --- a/include/configs/malta.h > +++ b/include/configs/malta.h > @@ -15,7 +15,6 @@ > > #define CONFIG_PCI_GT64120 > #define CONFIG_PCI_MSC01 > -#define CONFIG_PCNET > > #define CONFIG_SYS_ISA_IO_BASE_ADDRESS 0 > >
On 5/18/20 11:18 AM, Daniel Schwierzeck wrote: > > > Am 17.05.20 um 18:24 schrieb Marek Vasut: >> Add Kconfig entries for the pcnet driver and convert MIPS malta >> to use those. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com> >> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com> >> Cc: Joe Hershberger <joe.hershberger at ni.com> >> --- >> configs/malta_defconfig | 1 + >> drivers/net/Kconfig | 6 ++++++ >> include/configs/malta.h | 1 - >> 3 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/configs/malta_defconfig b/configs/malta_defconfig >> index 2b43818c81..0680f595db 100644 >> --- a/configs/malta_defconfig >> +++ b/configs/malta_defconfig >> @@ -26,6 +26,7 @@ CONFIG_MTD_NOR_FLASH=y >> CONFIG_FLASH_CFI_DRIVER=y >> CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y >> CONFIG_SYS_FLASH_CFI=y >> +CONFIG_PCNET=y >> CONFIG_PCI=y >> CONFIG_RTC_MC146818=y >> CONFIG_SYS_NS16550=y > > we have four Malta defconfigs to get build coverage for MIPS32/64 and > LE/BE. Thus you need to update all of them. > > $ ls -1 configs/malta* > configs/malta64_defconfig > configs/malta64el_defconfig > configs/malta_defconfig > configs/maltael_defconfig > All right. Can you test it on those before I send V2 ?
Am 18.05.20 um 11:54 schrieb Marek Vasut: > On 5/18/20 11:18 AM, Daniel Schwierzeck wrote: >> >> >> Am 17.05.20 um 18:24 schrieb Marek Vasut: >>> Add Kconfig entries for the pcnet driver and convert MIPS malta >>> to use those. >>> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com> >>> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com> >>> Cc: Joe Hershberger <joe.hershberger at ni.com> >>> --- >>> configs/malta_defconfig | 1 + >>> drivers/net/Kconfig | 6 ++++++ >>> include/configs/malta.h | 1 - >>> 3 files changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/configs/malta_defconfig b/configs/malta_defconfig >>> index 2b43818c81..0680f595db 100644 >>> --- a/configs/malta_defconfig >>> +++ b/configs/malta_defconfig >>> @@ -26,6 +26,7 @@ CONFIG_MTD_NOR_FLASH=y >>> CONFIG_FLASH_CFI_DRIVER=y >>> CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y >>> CONFIG_SYS_FLASH_CFI=y >>> +CONFIG_PCNET=y >>> CONFIG_PCI=y >>> CONFIG_RTC_MC146818=y >>> CONFIG_SYS_NS16550=y >> >> we have four Malta defconfigs to get build coverage for MIPS32/64 and >> LE/BE. Thus you need to update all of them. >> >> $ ls -1 configs/malta* >> configs/malta64_defconfig >> configs/malta64el_defconfig >> configs/malta_defconfig >> configs/maltael_defconfig >> > > All right. Can you test it on those before I send V2 ? > the non-DM part works for all Malta Qemu variants. I can't test the DM part because of the dependency to DM_PCI which is still on the TODO list for Malta.
diff --git a/configs/malta_defconfig b/configs/malta_defconfig index 2b43818c81..0680f595db 100644 --- a/configs/malta_defconfig +++ b/configs/malta_defconfig @@ -26,6 +26,7 @@ CONFIG_MTD_NOR_FLASH=y CONFIG_FLASH_CFI_DRIVER=y CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y CONFIG_SYS_FLASH_CFI=y +CONFIG_PCNET=y CONFIG_PCI=y CONFIG_RTC_MC146818=y CONFIG_SYS_NS16550=y diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index f7855c92d3..cef3b5c0de 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -377,6 +377,12 @@ config MII help Enable support of the Media-Independent Interface (MII) +config PCNET + bool "AMD PCnet series Ethernet controller driver" + help + This driver supports AMD PCnet series fast ethernet family of + PCI chipsets/adapters. + config RTL8139 bool "Realtek 8139 series Ethernet controller driver" help diff --git a/include/configs/malta.h b/include/configs/malta.h index 82c90042d9..9602773ff9 100644 --- a/include/configs/malta.h +++ b/include/configs/malta.h @@ -15,7 +15,6 @@ #define CONFIG_PCI_GT64120 #define CONFIG_PCI_MSC01 -#define CONFIG_PCNET #define CONFIG_SYS_ISA_IO_BASE_ADDRESS 0
Add Kconfig entries for the pcnet driver and convert MIPS malta to use those. Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com> Cc: Joe Hershberger <joe.hershberger at ni.com> --- configs/malta_defconfig | 1 + drivers/net/Kconfig | 6 ++++++ include/configs/malta.h | 1 - 3 files changed, 7 insertions(+), 1 deletion(-)