diff mbox series

[v3,4/5] arm64: dts: qcom: sc7180: Use pdc interrupts for USB instead of GIC interrupts

Message ID 1601376452-31839-5-git-send-email-sanm@codeaurora.org
State Superseded
Headers show
Series USB DWC3 host wake up support from system suspend | expand

Commit Message

Sandeep Maheswaram Sept. 29, 2020, 10:47 a.m. UTC 
Using pdc interrupts for USB instead of GIC interrupts to
support wake up in case xo shutdown.

Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Sergei Shtylyov Sept. 29, 2020, 11:41 a.m. UTC | #1 
Hello!

On 29.09.2020 13:47, Sandeep Maheswaram wrote:

> Using pdc interrupts for USB instead of GIC interrupts to
> support wake up in case xo shutdown.

    s/xo/of/?

> Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
[...]

MBR, Sergei
Stephen Boyd Oct. 1, 2020, 1:05 a.m. UTC | #2 
Quoting Sergei Shtylyov (2020-09-29 04:41:19)
> Hello!
> 
> On 29.09.2020 13:47, Sandeep Maheswaram wrote:
> 
> > Using pdc interrupts for USB instead of GIC interrupts to
> > support wake up in case xo shutdown.
> 
>     s/xo/of/?

No it is xo. If anything it could be capitalized because it's the
pin name and usually stands for "crystal oscillator".

> 
> > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Sergei Shtylyov Oct. 1, 2020, 8:14 a.m. UTC | #3 
On 01.10.2020 4:05, Stephen Boyd wrote:

[...]
>>> Using pdc interrupts for USB instead of GIC interrupts to
>>> support wake up in case xo shutdown.
>>
>>      s/xo/of/?
> 
> No it is xo. If anything it could be capitalized because it's the
> pin name and usually stands for "crystal oscillator".

    In this case, "of" is still needed. :-)

>>> Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
>>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

MBR, Sergei
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 6678f1e..b196764 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2687,10 +2687,10 @@ 
 					  <&gcc GCC_USB30_PRIM_MASTER_CLK>;
 			assigned-clock-rates = <19200000>, <150000000>;
 
-			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
-				     <GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>,
-				     <GIC_SPI 488 IRQ_TYPE_LEVEL_HIGH>,
-				     <GIC_SPI 489 IRQ_TYPE_LEVEL_HIGH>;
+			interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pdc 6 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pdc 8 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pdc 9 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "hs_phy_irq", "ss_phy_irq",
 					  "dm_hs_phy_irq", "dp_hs_phy_irq";