mbox series

[v6,0/5] DVFS support for Venus

Message ID 1598970026-7199-1-git-send-email-rnayak@codeaurora.org
Headers show
Series DVFS support for Venus | expand

Message

Rajendra Nayak Sept. 1, 2020, 2:20 p.m. UTC
Rob, can you pick PATCH 1 since its already reviewed by you.
Stan, Patch 2 and 3 will need to be picked by you and they both have your ACKs
Patch 4 and 5 will need to be merged via the qcom tree once we have them reviewed.

v6: No changes, rebased on 5.9-rc3

v5: Fixed the opp-tables (patch 4/5) to avoid -ERANGE from
dev_pm_opp_set_rate

v4: Moved code from probe/remove/runtime_suspend into
different pm_ops callbacks

v3: Renamed the optional power domain as cx

v2: Fixed up the labels of OPP nodes in patch 4
    Included the bindings update patch as part of this series,
    a resend of https://lore.kernel.org/patchwork/patch/1241077/

These patches add DVFS support for Venus

Rajendra Nayak (5):
  dt-bindings: media: venus: Add an optional power domain for perf
    voting
  media: venus: core: Fix error handling in probe
  media: venus: core: Add support for opp tables/perf voting
  arm64: dts: sdm845: Add OPP tables and power-domains for venus
  arm64: dts: sc7180: Add OPP tables and power-domains for venus

 .../bindings/media/qcom,sc7180-venus.yaml          |  6 +-
 .../bindings/media/qcom,sdm845-venus-v2.yaml       |  6 +-
 arch/arm64/boot/dts/qcom/sc7180.dtsi               | 35 +++++++-
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 40 +++++++++-
 drivers/media/platform/qcom/venus/core.c           | 17 ++--
 drivers/media/platform/qcom/venus/core.h           |  5 ++
 drivers/media/platform/qcom/venus/pm_helpers.c     | 92 ++++++++++++++++++++--
 7 files changed, 183 insertions(+), 18 deletions(-)

Comments

Stanimir Varbanov Sept. 16, 2020, 7:26 a.m. UTC | #1
Hi,

On 9/16/20 8:33 AM, Rajendra Nayak wrote:
> 

> On 9/1/2020 7:50 PM, Rajendra Nayak wrote:

>> Rob, can you pick PATCH 1 since its already reviewed by you.

>> Stan, Patch 2 and 3 will need to be picked by you and they both have

>> your ACKs

> 

> Rob/Stan, any plans to get the patches merged for 5.10?


2/5 and 3/5 are queued up for v5.10 through media tree.

> 

>> Patch 4 and 5 will need to be merged via the qcom tree once we have

>> them reviewed.

>>

>> v6: No changes, rebased on 5.9-rc3

>>

>> v5: Fixed the opp-tables (patch 4/5) to avoid -ERANGE from

>> dev_pm_opp_set_rate

>>

>> v4: Moved code from probe/remove/runtime_suspend into

>> different pm_ops callbacks

>>

>> v3: Renamed the optional power domain as cx

>>

>> v2: Fixed up the labels of OPP nodes in patch 4

>>      Included the bindings update patch as part of this series,

>>      a resend of https://lore.kernel.org/patchwork/patch/1241077/

>>

>> These patches add DVFS support for Venus

>>

>> Rajendra Nayak (5):

>>    dt-bindings: media: venus: Add an optional power domain for perf

>>      voting

>>    media: venus: core: Fix error handling in probe

>>    media: venus: core: Add support for opp tables/perf voting

>>    arm64: dts: sdm845: Add OPP tables and power-domains for venus

>>    arm64: dts: sc7180: Add OPP tables and power-domains for venus

>>

>>   .../bindings/media/qcom,sc7180-venus.yaml          |  6 +-

>>   .../bindings/media/qcom,sdm845-venus-v2.yaml       |  6 +-

>>   arch/arm64/boot/dts/qcom/sc7180.dtsi               | 35 +++++++-

>>   arch/arm64/boot/dts/qcom/sdm845.dtsi               | 40 +++++++++-

>>   drivers/media/platform/qcom/venus/core.c           | 17 ++--

>>   drivers/media/platform/qcom/venus/core.h           |  5 ++

>>   drivers/media/platform/qcom/venus/pm_helpers.c     | 92

>> ++++++++++++++++++++--

>>   7 files changed, 183 insertions(+), 18 deletions(-)

>>

> 


-- 
regards,
Stan
Doug Anderson Oct. 1, 2020, 8:40 p.m. UTC | #2
Hi,

On Wed, Sep 16, 2020 at 12:26 AM Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
>
> Hi,
>
> On 9/16/20 8:33 AM, Rajendra Nayak wrote:
> >
> > On 9/1/2020 7:50 PM, Rajendra Nayak wrote:
> >> Rob, can you pick PATCH 1 since its already reviewed by you.
> >> Stan, Patch 2 and 3 will need to be picked by you and they both have
> >> your ACKs
> >
> > Rob/Stan, any plans to get the patches merged for 5.10?
>
> 2/5 and 3/5 are queued up for v5.10 through media tree.

Normally I'd expect device tree bindings (patch #1) to go through the
same tree as the driver changes.  Does the media tree work
differently?  If you're expecting Rob Herring to land the device tree
binding change, is he aware?


-Doug
Stanimir Varbanov Oct. 1, 2020, 11:17 p.m. UTC | #3
Hi,

On 10/1/20 11:40 PM, Doug Anderson wrote:
> Hi,
> 
> On Wed, Sep 16, 2020 at 12:26 AM Stanimir Varbanov
> <stanimir.varbanov@linaro.org> wrote:
>>
>> Hi,
>>
>> On 9/16/20 8:33 AM, Rajendra Nayak wrote:
>>>
>>> On 9/1/2020 7:50 PM, Rajendra Nayak wrote:
>>>> Rob, can you pick PATCH 1 since its already reviewed by you.
>>>> Stan, Patch 2 and 3 will need to be picked by you and they both have
>>>> your ACKs
>>>
>>> Rob/Stan, any plans to get the patches merged for 5.10?
>>
>> 2/5 and 3/5 are queued up for v5.10 through media tree.
> 
> Normally I'd expect device tree bindings (patch #1) to go through the
> same tree as the driver changes.  Does the media tree work
> differently?  If you're expecting Rob Herring to land the device tree
> binding change, is he aware?

I sent pull request to Mauro with 1/5 included.
Thanks for spotting.

> 
> 
> -Doug
>