| Message ID | 20201014010340.433398-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Commit | d85cc6635a2a1338f7a45f652e97b02f9a69b9f5 |
| Headers | show |
| Series | ACPI: processor: remove unnecessary string _UID comments | expand |
On Wed, Oct 14, 2020 at 3:03 AM Alex Hung <alex.hung@canonical.com> wrote: > > ACPI 6.3 Errata A no longer allows _UID to be string except Itanium > for historical reasons as stated in section 5.2.12. Therefore, it is > redundant to comment "we don't handle string _UIDs yet" which implies a > feature is missing. > > "From ACPI Specification 6.3 onward, all processor objects for all > architectures except Itanium must now use Device() objects with an _HID > of ACPI0007, and use only integer _UID values." > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > drivers/acpi/acpi_processor.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c > index b51ddf3..710605f 100644 > --- a/drivers/acpi/acpi_processor.c > +++ b/drivers/acpi/acpi_processor.c > @@ -264,7 +264,6 @@ static int acpi_processor_get_info(struct acpi_device *device) > } else { > /* > * Declared with "Device" statement; match _UID. > - * Note that we don't handle string _UIDs yet. > */ > status = acpi_evaluate_integer(pr->handle, METHOD_NAME__UID, > NULL, &value); > -- Applied as 5.10-rc material with edited changelog and subject, thanks!
diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index b51ddf3..710605f 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c @@ -264,7 +264,6 @@ static int acpi_processor_get_info(struct acpi_device *device) } else { /* * Declared with "Device" statement; match _UID. - * Note that we don't handle string _UIDs yet. */ status = acpi_evaluate_integer(pr->handle, METHOD_NAME__UID, NULL, &value);
ACPI 6.3 Errata A no longer allows _UID to be string except Itanium for historical reasons as stated in section 5.2.12. Therefore, it is redundant to comment "we don't handle string _UIDs yet" which implies a feature is missing. "From ACPI Specification 6.3 onward, all processor objects for all architectures except Itanium must now use Device() objects with an _HID of ACPI0007, and use only integer _UID values." Signed-off-by: Alex Hung <alex.hung@canonical.com> --- drivers/acpi/acpi_processor.c | 1 - 1 file changed, 1 deletion(-)