| Message ID | 20200829142501.31478-1-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties | expand |
On 29.08.2020 16:24, Krzysztof Kozlowski wrote: > Additional properties or nodes actually might appear (e.g. operating > points table) so use unevaluatedProperties to fix dtbs_check warnings > like: > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000: > 'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
On 29.08.2020 16:24, Krzysztof Kozlowski wrote: > Samsung Exynos SoCs use syscon for system registers so document its > compatibles. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 049ec2ffc7f9..0f21943dea28 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -40,6 +40,10 @@ properties: > - allwinner,sun50i-a64-system-controller > - microchip,sparx5-cpu-syscon > - mstar,msc313-pmsleep > + - samsung,exynos3-sysreg > + - samsung,exynos4-sysreg > + - samsung,exynos5-sysreg > + - samsung,exynos5433-sysreg Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Do you also have a patch updating Documentation/devicetree/ bindings/arm/samsung/sysreg.yaml with new compatibles?
On Mon, Aug 31, 2020 at 02:30:52PM +0200, Sylwester Nawrocki wrote: > On 29.08.2020 16:24, Krzysztof Kozlowski wrote: > > Samsung Exynos SoCs use syscon for system registers so document its > > compatibles. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > > index 049ec2ffc7f9..0f21943dea28 100644 > > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > > @@ -40,6 +40,10 @@ properties: > > - allwinner,sun50i-a64-system-controller > > - microchip,sparx5-cpu-syscon > > - mstar,msc313-pmsleep > > + - samsung,exynos3-sysreg > > + - samsung,exynos4-sysreg > > + - samsung,exynos5-sysreg > > + - samsung,exynos5433-sysreg > > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > > Do you also have a patch updating Documentation/devicetree/ > bindings/arm/samsung/sysreg.yaml with new compatibles? Good point. This file should be probably dropped as everything is documented in syscon. Best regards, Krzysztof
On 29.08.2020 16:24, Krzysztof Kozlowski wrote: > System register nodes, implementing syscon binding, should use > appropriate compatible. This fixes dtbs_check warnings: > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: syscon@13b80000: > compatible: ['syscon'] is not valid under any of the given schemas > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
On Mon, 31 Aug 2020 at 15:12, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > > On 29.08.2020 16:25, Krzysztof Kozlowski wrote: > > The Wolfson Arizona codec is interrupt controller which is required by > > bindings. This fixes dtbs_check warnings like: > > > > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required property > > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > > However I really wonder if it makes sense to expose this to DTS. Indeed, > the main MFD device of the WM5110 chip is interrupt controller, but its > interrupts are requested internally by the respective drivers. In such case maybe the schema should be updated? Feel free to send a follow up or a replacement patch for this one. Best regards, Krzysztof
On Sat, Aug 29, 2020 at 04:24:57PM +0200, Krzysztof Kozlowski wrote: > Additional properties actually might appear (e.g. power-domains) so use > unevaluatedProperties to fix dtbs_check warnings like: Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Sat, 29 Aug 2020 16:24:52 +0200, Krzysztof Kozlowski wrote: > Additional properties actually might appear (e.g. assigned-clocks) so > use unevaluatedProperties to fix dtbs_check warnings like: > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000: > 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: samsung-i2s: Use unevaluatedProperties commit: 8187d8300251a99e40e288be80bef6a15b7b22e4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Sat, Aug 29, 2020 at 04:24:52PM +0200, Krzysztof Kozlowski wrote: > Additional properties actually might appear (e.g. assigned-clocks) so > use unevaluatedProperties to fix dtbs_check warnings like: > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000: > 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
On Tue, Sep 01, 2020 at 03:50:00PM +0100, Mark Brown wrote: > On Sat, 29 Aug 2020 16:24:52 +0200, Krzysztof Kozlowski wrote: > > Additional properties actually might appear (e.g. assigned-clocks) so > > use unevaluatedProperties to fix dtbs_check warnings like: > > > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000: > > 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > Thanks! > > [1/1] ASoC: samsung-i2s: Use unevaluatedProperties > commit: 8187d8300251a99e40e288be80bef6a15b7b22e4 Please revert or drop. All these 'unevaluatedProperties' changes are wrong. Rob
diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml index 686c13c14e32..30ff2da81416 100644 --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml @@ -86,7 +86,7 @@ required: - compatible - reg -additionalProperties: false +unevaluatedProperties: false allOf: - if:
Additional properties actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix dtbs_check warnings like: arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000: 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)