mbox series

[v2,0/2] ibmveth gso fix.

Message ID 20201013232014.26044-1-dwilder@us.ibm.com
Headers show
Series ibmveth gso fix. | expand

Message

David Wilder Oct. 13, 2020, 11:20 p.m. UTC 
The ibmveth driver is a virtual Ethernet driver used on IBM pSeries systems.
Gso packets can be sent between LPARS (virtual hosts) without segmentation,
by flagging gso packets using one of two methods depending on the firmware
version. Some gso packet were not correctly identified by the receiver.
This patch-set corrects this issue.

V2:
- Added fix tags.
- Byteswap the constant at compilation time.
- Updated the commit message to clarify what frame validation is performed
  by the hypervisor.

Signed-off-by: David Wilder <dwilder@us.ibm.com>
Reviewed-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Reviewed-by: Cristobal Forno <cris.forno@ibm.com>
Reviewed-by: Pradeep Satyanarayana <pradeeps@linux.vnet.ibm.com>

David Wilder (2):
  ibmveth: Switch order of ibmveth_helper calls.
  ibmveth: Identify ingress large send packets.

 drivers/net/ethernet/ibm/ibmveth.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

Comments

Jakub Kicinski Oct. 15, 2020, 3:23 a.m. UTC | #1 
On Tue, 13 Oct 2020 16:20:12 -0700 David Wilder wrote:
> The ibmveth driver is a virtual Ethernet driver used on IBM pSeries systems.
> Gso packets can be sent between LPARS (virtual hosts) without segmentation,
> by flagging gso packets using one of two methods depending on the firmware
> version. Some gso packet were not correctly identified by the receiver.
> This patch-set corrects this issue.
> 
> V2:
> - Added fix tags.
> - Byteswap the constant at compilation time.
> - Updated the commit message to clarify what frame validation is performed
>   by the hypervisor.

Applied, thanks everyone!
Jakub Kicinski Oct. 15, 2020, 3:23 a.m. UTC | #2 
On Tue, 13 Oct 2020 16:20:13 -0700 David Wilder wrote:
> Fixes: 66aa0678efc2 ("ibmveth: Support to enable LSO/CSO for Trunk
> VEA.")

Please make sure Fixes tags are not wrapped in the future.