| Message ID | 20200912033758.142601-1-yanaijie@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: bnx2fc: make a bunch of symbols static in bnx2fc_fcoe.c | expand |
Jason, > This eliminates the following sparse warning: > > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:53:1: warning: symbol > 'bnx2fc_global_lock' was not declared. Should it be static? > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:111:6: warning: symbol > 'bnx2fc_devloss_tmo' was not declared. Should it be static? > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:116:6: warning: symbol > 'bnx2fc_max_luns' was not declared. Should it be static? > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:121:6: warning: symbol > 'bnx2fc_queue_depth' was not declared. Should it be static? > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:126:6: warning: symbol > 'bnx2fc_log_fka' was not declared. Should it be static? Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
On Sat, 12 Sep 2020 11:37:58 +0800, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:53:1: warning: symbol > 'bnx2fc_global_lock' was not declared. Should it be static? > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:111:6: warning: symbol > 'bnx2fc_devloss_tmo' was not declared. Should it be static? > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:116:6: warning: symbol > 'bnx2fc_max_luns' was not declared. Should it be static? > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:121:6: warning: symbol > 'bnx2fc_queue_depth' was not declared. Should it be static? > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:126:6: warning: symbol > 'bnx2fc_log_fka' was not declared. Should it be static? Applied to 5.10/scsi-queue, thanks! [1/1] scsi: bnx2fc: Make a bunch of symbols static in bnx2fc_fcoe.c https://git.kernel.org/mkp/scsi/c/5c2ef01448e9 -- Martin K. Petersen Oracle Linux Engineering
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 5cdeeb3539fd..6890bbe04a8c 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c @@ -50,7 +50,7 @@ struct workqueue_struct *bnx2fc_wq; * Here the io threads are per cpu but the l2 thread is just one */ struct fcoe_percpu_s bnx2fc_global; -DEFINE_SPINLOCK(bnx2fc_global_lock); +static DEFINE_SPINLOCK(bnx2fc_global_lock); static struct cnic_ulp_ops bnx2fc_cnic_cb; static struct libfc_function_template bnx2fc_libfc_fcn_templ; @@ -108,22 +108,22 @@ MODULE_PARM_DESC(debug_logging, "\t\t0x10 - fcoe L2 fame related logs.\n" "\t\t0xff - LOG all messages."); -uint bnx2fc_devloss_tmo; +static uint bnx2fc_devloss_tmo; module_param_named(devloss_tmo, bnx2fc_devloss_tmo, uint, S_IRUGO); MODULE_PARM_DESC(devloss_tmo, " Change devloss_tmo for the remote ports " "attached via bnx2fc."); -uint bnx2fc_max_luns = BNX2FC_MAX_LUN; +static uint bnx2fc_max_luns = BNX2FC_MAX_LUN; module_param_named(max_luns, bnx2fc_max_luns, uint, S_IRUGO); MODULE_PARM_DESC(max_luns, " Change the default max_lun per SCSI host. Default " "0xffff."); -uint bnx2fc_queue_depth; +static uint bnx2fc_queue_depth; module_param_named(queue_depth, bnx2fc_queue_depth, uint, S_IRUGO); MODULE_PARM_DESC(queue_depth, " Change the default queue depth of SCSI devices " "attached via bnx2fc."); -uint bnx2fc_log_fka; +static uint bnx2fc_log_fka; module_param_named(log_fka, bnx2fc_log_fka, uint, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(log_fka, " Print message to kernel log when fcoe is " "initiating a FIP keep alive when debug logging is enabled.");
This eliminates the following sparse warning: drivers/scsi/bnx2fc/bnx2fc_fcoe.c:53:1: warning: symbol 'bnx2fc_global_lock' was not declared. Should it be static? drivers/scsi/bnx2fc/bnx2fc_fcoe.c:111:6: warning: symbol 'bnx2fc_devloss_tmo' was not declared. Should it be static? drivers/scsi/bnx2fc/bnx2fc_fcoe.c:116:6: warning: symbol 'bnx2fc_max_luns' was not declared. Should it be static? drivers/scsi/bnx2fc/bnx2fc_fcoe.c:121:6: warning: symbol 'bnx2fc_queue_depth' was not declared. Should it be static? drivers/scsi/bnx2fc/bnx2fc_fcoe.c:126:6: warning: symbol 'bnx2fc_log_fka' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)