| Message ID | 20200909175946.395313-2-jic23@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings:iio:adc: Another set of yaml conversions. | expand |
On Wed, 09 Sep 2020 18:59:27 +0100, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > A simple conversion of this freescale ADC binding from txt to yaml. > For maintainer I went with Fugang Duan as the original author of the > binding. Would be great to have confirmation of this. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Fugang Duan <B38611@freescale.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > --- > .../bindings/iio/adc/fsl,vf610-adc.yaml | 81 +++++++++++++++++++ > .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 --------- > 2 files changed, 81 insertions(+), 36 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Sep 9, 2020 at 12:02 PM Jonathan Cameron <jic23@kernel.org> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > A simple conversion of this freescale ADC binding from txt to yaml. > For maintainer I went with Fugang Duan as the original author of the > binding. Would be great to have confirmation of this. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Fugang Duan <B38611@freescale.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > --- > .../bindings/iio/adc/fsl,vf610-adc.yaml | 81 +++++++++++++++++++ > .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 --------- > 2 files changed, 81 insertions(+), 36 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > new file mode 100644 > index 000000000000..99b6b55fd0a3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/fsl,vf610-adc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ADC found on Freescale vf610 and similar SoCs > + > +maintainers: > + - Fugang Duan <B38611@freescale.com> I assume you got a bunch of bounces on this series, too? Looks like 1, 4, 7, 9, 13, 16, 19, and 20 bounced. Please fix those addresses before applying. Rob
On Tue, 15 Sep 2020 14:45:58 -0600 Rob Herring <robh@kernel.org> wrote: > On Wed, Sep 9, 2020 at 12:02 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > A simple conversion of this freescale ADC binding from txt to yaml. > > For maintainer I went with Fugang Duan as the original author of the > > binding. Would be great to have confirmation of this. > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Fugang Duan <B38611@freescale.com> > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > --- > > .../bindings/iio/adc/fsl,vf610-adc.yaml | 81 +++++++++++++++++++ > > .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 --------- > > 2 files changed, 81 insertions(+), 36 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > > new file mode 100644 > > index 000000000000..99b6b55fd0a3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > > @@ -0,0 +1,81 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/adc/fsl,vf610-adc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ADC found on Freescale vf610 and similar SoCs > > + > > +maintainers: > > + - Fugang Duan <B38611@freescale.com> > > I assume you got a bunch of bounces on this series, too? Looks like 1, > 4, 7, 9, 13, 16, 19, and 20 bounced. Please fix those addresses before > applying. Yup. I missed them on v1, but have saved the set for v2 to be able to fix those I can. for some I can make a reasonable stab at a suitable maintainer as covered by a catch all. For the others if I can't find a newer address I'll cover them myself until someone else steps up. I think that's just 9 and 13. For 4 I didn't get a bounce but can add that to my list! For this particular one looks like fugang duan is still active but now with an NXP address so I'll update that. I've changed the cc on this mail. Thanks, Jonathan > > Rob
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> Sent: Wednesday, September 16, 2020 6:34 PM > On Tue, 15 Sep 2020 14:45:58 -0600 > Rob Herring <robh@kernel.org> wrote: > > > On Wed, Sep 9, 2020 at 12:02 PM Jonathan Cameron <jic23@kernel.org> > wrote: > > > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > > > A simple conversion of this freescale ADC binding from txt to yaml. > > > For maintainer I went with Fugang Duan as the original author of the > > > binding. Would be great to have confirmation of this. > > > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > Cc: Fugang Duan <B38611@freescale.com> > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > > --- > > > .../bindings/iio/adc/fsl,vf610-adc.yaml | 81 > +++++++++++++++++++ > > > .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 --------- > > > 2 files changed, 81 insertions(+), 36 deletions(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > > > b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > > > new file mode 100644 > > > index 000000000000..99b6b55fd0a3 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > > > @@ -0,0 +1,81 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > > +--- > > > +$id: > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde > > > > +vicetree.org%2Fschemas%2Fiio%2Fadc%2Ffsl%2Cvf610-adc.yaml%23&da > > > > +ta=02%7C01%7Cfugang.duan%40nxp.com%7C750fcd8ebdf34af6655308d85a2 > c41 > > > > +8d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63735849344455 > 0580& > > > > +amp;sdata=SwRIWqN5caXEUZBTmnjKKHJKAZ1FQ03s1Gdpf%2FTyXzE%3D&am > p;rese > > > +rved=0 > > > +$schema: > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde > > > > +vicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cfug > an > > > > +g.duan%40nxp.com%7C750fcd8ebdf34af6655308d85a2c418d%7C686ea1d3bc > 2b4 > > > > +c6fa92cd99c5c301635%7C0%7C0%7C637358493444550580&sdata=c4To > ZCOG > > > +iPM0XbxCnLGJEEXvnMvFKqSgg3gtLeDYACI%3D&reserved=0 > > > + > > > +title: ADC found on Freescale vf610 and similar SoCs > > > + > > > +maintainers: > > > + - Fugang Duan <B38611@freescale.com> > > > > I assume you got a bunch of bounces on this series, too? Looks like 1, > > 4, 7, 9, 13, 16, 19, and 20 bounced. Please fix those addresses before > > applying. > > Yup. I missed them on v1, but have saved the set for v2 to be able to fix those I > can. > > for some I can make a reasonable stab at a suitable maintainer as covered by a > catch all. For the others if I can't find a newer address I'll cover them myself > until someone else steps up. > I think that's just 9 and 13. For 4 I didn't get a bounce but can add that to my > list! > > For this particular one looks like fugang duan is still active but now with an NXP > address so I'll update that. I've changed the cc on this mail. > > Thanks, > > Jonathan Thanks, Jonathan. For the patch, it looks good. Reviewed-by: Fugang Duan <fugang.duan@nxp.com> > > > > > > Rob >
On Thu, 17 Sep 2020 02:24:36 +0000 Andy Duan <fugang.duan@nxp.com> wrote: > From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> Sent: Wednesday, September 16, 2020 6:34 PM > > On Tue, 15 Sep 2020 14:45:58 -0600 > > Rob Herring <robh@kernel.org> wrote: > > > > > On Wed, Sep 9, 2020 at 12:02 PM Jonathan Cameron <jic23@kernel.org> > > wrote: > > > > > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > > > > > A simple conversion of this freescale ADC binding from txt to yaml. > > > > For maintainer I went with Fugang Duan as the original author of the > > > > binding. Would be great to have confirmation of this. > > > > > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Cc: Fugang Duan <B38611@freescale.com> > > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > > > --- > > > > .../bindings/iio/adc/fsl,vf610-adc.yaml | 81 > > +++++++++++++++++++ > > > > .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 --------- > > > > 2 files changed, 81 insertions(+), 36 deletions(-) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > > > > b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > > > > new file mode 100644 > > > > index 000000000000..99b6b55fd0a3 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml > > > > @@ -0,0 +1,81 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > > > +--- > > > > +$id: > > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde > > > > > > +vicetree.org%2Fschemas%2Fiio%2Fadc%2Ffsl%2Cvf610-adc.yaml%23&da > > > > > > +ta=02%7C01%7Cfugang.duan%40nxp.com%7C750fcd8ebdf34af6655308d85a2 > > c41 > > > > > > +8d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63735849344455 > > 0580& > > > > > > +amp;sdata=SwRIWqN5caXEUZBTmnjKKHJKAZ1FQ03s1Gdpf%2FTyXzE%3D&am > > p;rese > > > > +rved=0 > > > > +$schema: > > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde > > > > > > +vicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cfug > > an > > > > > > +g.duan%40nxp.com%7C750fcd8ebdf34af6655308d85a2c418d%7C686ea1d3bc > > 2b4 > > > > > > +c6fa92cd99c5c301635%7C0%7C0%7C637358493444550580&sdata=c4To > > ZCOG > > > > +iPM0XbxCnLGJEEXvnMvFKqSgg3gtLeDYACI%3D&reserved=0 > > > > + > > > > +title: ADC found on Freescale vf610 and similar SoCs > > > > + > > > > +maintainers: > > > > + - Fugang Duan <B38611@freescale.com> > > > > > > I assume you got a bunch of bounces on this series, too? Looks like 1, > > > 4, 7, 9, 13, 16, 19, and 20 bounced. Please fix those addresses before > > > applying. > > > > Yup. I missed them on v1, but have saved the set for v2 to be able to fix those I > > can. > > > > for some I can make a reasonable stab at a suitable maintainer as covered by a > > catch all. For the others if I can't find a newer address I'll cover them myself > > until someone else steps up. > > I think that's just 9 and 13. For 4 I didn't get a bounce but can add that to my > > list! > > > > For this particular one looks like fugang duan is still active but now with an NXP > > address so I'll update that. I've changed the cc on this mail. > > > > Thanks, > > > > Jonathan > > Thanks, Jonathan. > > For the patch, it looks good. > > Reviewed-by: Fugang Duan <fugang.duan@nxp.com> I've updated the maintainer address to the one you have for this tag and applied to the togreg branch of iio.git, pushing out as testing for the autobuilders to perhaps poke at it. Thanks, Jonathan > > > > > > > > > > Rob > > >
diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file mode 100644 index 000000000000..99b6b55fd0a3 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml @@ -0,0 +1,81 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/fsl,vf610-adc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ADC found on Freescale vf610 and similar SoCs + +maintainers: + - Fugang Duan <B38611@freescale.com> + +description: + ADCs found on vf610/i.MX6slx and upward SoCs from Freescale. + +properties: + compatible: + const: fsl,vf610-adc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + description: ADC source clock (ipg clock) + maxItems: 1 + + clock-names: + const: adc + + vref-supply: + description: ADC reference voltage supply. + + fsl,adck-max-frequency: + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 3 + maxItems: 3 + description: | + Maximum frequencies from datasheet operating requirements. + Three values necessary to cover the 3 conversion modes. + * Frequency in normal mode (ADLPC=0, ADHSC=0) + * Frequency in high-speed mode (ADLPC=0, ADHSC=1) + * Frequency in low-power mode (ADLPC=1, ADHSC=0) + + min-sample-time: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Minimum sampling time in nanoseconds. This value has + to be chosen according to the conversion mode and the connected analog + source resistance (R_as) and capacitance (C_as). Refer the datasheet's + operating requirements. A safe default across a wide range of R_as and + C_as as well as conversion modes is 1000ns. + + "#io-channel-cells": + const: 1 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - vref-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/vf610-clock.h> + adc@4003b000 { + compatible = "fsl,vf610-adc"; + reg = <0x4003b000 0x1000>; + interrupts = <0 53 0x04>; + clocks = <&clks VF610_CLK_ADC0>; + clock-names = "adc"; + fsl,adck-max-frequency = <30000000>, <40000000>, <20000000>; + vref-supply = <®_vcc_3v3_mcu>; + min-sample-time = <10000>; + }; +... diff --git a/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt b/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt deleted file mode 100644 index 1aad0514e647..000000000000 --- a/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt +++ /dev/null @@ -1,36 +0,0 @@ -Freescale vf610 Analog to Digital Converter bindings - -The devicetree bindings are for the new ADC driver written for -vf610/i.MX6slx and upward SoCs from Freescale. - -Required properties: -- compatible: Should contain "fsl,vf610-adc" -- reg: Offset and length of the register set for the device -- interrupts: Should contain the interrupt for the device -- clocks: The clock is needed by the ADC controller, ADC clock source is ipg clock. -- clock-names: Must contain "adc", matching entry in the clocks property. -- vref-supply: The regulator supply ADC reference voltage. - -Recommended properties: -- fsl,adck-max-frequency: Maximum frequencies according to datasheets operating - requirements. Three values are required, depending on conversion mode: - - Frequency in normal mode (ADLPC=0, ADHSC=0) - - Frequency in high-speed mode (ADLPC=0, ADHSC=1) - - Frequency in low-power mode (ADLPC=1, ADHSC=0) -- min-sample-time: Minimum sampling time in nanoseconds. This value has - to be chosen according to the conversion mode and the connected analog - source resistance (R_as) and capacitance (C_as). Refer the datasheet's - operating requirements. A safe default across a wide range of R_as and - C_as as well as conversion modes is 1000ns. - -Example: -adc0: adc@4003b000 { - compatible = "fsl,vf610-adc"; - reg = <0x4003b000 0x1000>; - interrupts = <0 53 0x04>; - clocks = <&clks VF610_CLK_ADC0>; - clock-names = "adc"; - fsl,adck-max-frequency = <30000000>, <40000000>, - <20000000>; - vref-supply = <®_vcc_3v3_mcu>; -};