| Message ID | 20201002061353.1340766-1-clg@kaod.org |
|---|---|
| State | New |
| Headers | show |
| Series | ppc/pnv: Increase max firware size | expand |
That was sent a bit fast. Can you please add in the commit log : Builds enabling GCOV can be bigger than 4MB and the limit on FSP systems is 16MB. Thanks C. On 10/2/20 8:13 AM, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- > hw/ppc/pnv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index 6670967e26a9..d9e52873ea70 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -61,7 +61,7 @@ > > #define FW_FILE_NAME "skiboot.lid" > #define FW_LOAD_ADDR 0x0 > -#define FW_MAX_SIZE (4 * MiB) > +#define FW_MAX_SIZE (16 * MiB) > > #define KERNEL_LOAD_ADDR 0x20000000 > #define KERNEL_MAX_SIZE (256 * MiB) >
On Fri, 2 Oct 2020 08:15:46 +0200 Cédric Le Goater <clg@kaod.org> wrote: > That was sent a bit fast. Can you please add in the commit log : > > Builds enabling GCOV can be bigger than 4MB and the limit on FSP > systems is 16MB. > > Thanks > And also s/firware/firmware in the title. Cheers, -- Greg > C. > > On 10/2/20 8:13 AM, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater <clg@kaod.org> > > --- > > hw/ppc/pnv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > > index 6670967e26a9..d9e52873ea70 100644 > > --- a/hw/ppc/pnv.c > > +++ b/hw/ppc/pnv.c > > @@ -61,7 +61,7 @@ > > > > #define FW_FILE_NAME "skiboot.lid" > > #define FW_LOAD_ADDR 0x0 > > -#define FW_MAX_SIZE (4 * MiB) > > +#define FW_MAX_SIZE (16 * MiB) > > > > #define KERNEL_LOAD_ADDR 0x20000000 > > #define KERNEL_MAX_SIZE (256 * MiB) > > > >
On 10/2/20 9:26 AM, Greg Kurz wrote: > On Fri, 2 Oct 2020 08:15:46 +0200 > Cédric Le Goater <clg@kaod.org> wrote: > >> That was sent a bit fast. Can you please add in the commit log : >> >> Builds enabling GCOV can be bigger than 4MB and the limit on FSP >> systems is 16MB. >> >> Thanks >> > > And also s/firware/firmware in the title. bah. sending a v2. Thanks, C.
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 6670967e26a9..d9e52873ea70 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -61,7 +61,7 @@ #define FW_FILE_NAME "skiboot.lid" #define FW_LOAD_ADDR 0x0 -#define FW_MAX_SIZE (4 * MiB) +#define FW_MAX_SIZE (16 * MiB) #define KERNEL_LOAD_ADDR 0x20000000 #define KERNEL_MAX_SIZE (256 * MiB)
Signed-off-by: Cédric Le Goater <clg@kaod.org> --- hw/ppc/pnv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)