mbox series

[v2,0/2] fix parsing of reboot= cmdline

Message ID 20201027133545.58625-1-mcroce@linux.microsoft.com
Headers show
Series fix parsing of reboot= cmdline | expand

Message

Matteo Croce Oct. 27, 2020, 1:35 p.m. UTC
From: Matteo Croce <mcroce@microsoft.com>

The parsing of the reboot= cmdline has two major errors:
- a missing bound check can crash the system on reboot
- parsing of the cpu number only works if specified last

Fix both, along with a small code refactor.

v1->v2:
As Petr suggested, don't force base 10 in simple_strtoul(),
so hex values are accepted as well.

Matteo Croce (2):
  reboot: fix overflow parsing reboot cpu number
  reboot: fix parsing of reboot cpu number

 kernel/reboot.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

Comments

Greg KH Oct. 27, 2020, 1:42 p.m. UTC | #1
On Tue, Oct 27, 2020 at 02:35:43PM +0100, Matteo Croce wrote:
> From: Matteo Croce <mcroce@microsoft.com>

> 

> The parsing of the reboot= cmdline has two major errors:

> - a missing bound check can crash the system on reboot

> - parsing of the cpu number only works if specified last

> 

> Fix both, along with a small code refactor.

> 

> v1->v2:

> As Petr suggested, don't force base 10 in simple_strtoul(),

> so hex values are accepted as well.

> 

> Matteo Croce (2):

>   reboot: fix overflow parsing reboot cpu number

>   reboot: fix parsing of reboot cpu number

> 

>  kernel/reboot.c | 24 +++++++++++++-----------

>  1 file changed, 13 insertions(+), 11 deletions(-)

> 

> -- 

> 2.28.0

> 


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>