diff mbox series

[29/36] qdev: Move qdev_prop_tpm declaration to tpm_prop.h

Message ID 20201029220246.472693-30-ehabkost@redhat.com
State Accepted
Commit 8f2aff643caad71c45c70da1af285e5a3330d518
Headers show
Series Make qdev static property API usable by any QOM type | expand

Commit Message

Eduardo Habkost Oct. 29, 2020, 10:02 p.m. UTC
Move the variable declaration close to the macro that uses it.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
 hw/tpm/tpm_prop.h            | 2 ++
 include/hw/qdev-properties.h | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Stefan Berger Oct. 29, 2020, 10:40 p.m. UTC | #1
On 10/29/20 6:02 PM, Eduardo Habkost wrote:
> Move the variable declaration close to the macro that uses it.

>

> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

> ---

> Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>

> Cc: Paolo Bonzini <pbonzini@redhat.com>

> Cc: "Daniel P. Berrangé" <berrange@redhat.com>

> Cc: Eduardo Habkost <ehabkost@redhat.com>

> Cc: qemu-devel@nongnu.org



Reviewed-by:  Stefan Berger <stefanb@linux.ibm.com>

> ---

>   hw/tpm/tpm_prop.h            | 2 ++

>   include/hw/qdev-properties.h | 1 -

>   2 files changed, 2 insertions(+), 1 deletion(-)

>

> diff --git a/hw/tpm/tpm_prop.h b/hw/tpm/tpm_prop.h

> index 85e1ae5718..871af584b7 100644

> --- a/hw/tpm/tpm_prop.h

> +++ b/hw/tpm/tpm_prop.h

> @@ -25,6 +25,8 @@

>   #include "sysemu/tpm_backend.h"

>   #include "hw/qdev-properties.h"

>

> +extern const PropertyInfo qdev_prop_tpm;

> +

>   #define DEFINE_PROP_TPMBE(_n, _s, _f)                     \

>       DEFINE_PROP(_n, _s, _f, qdev_prop_tpm, TPMBackend *)

>

> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h

> index e1ef466790..2b00a1bcf6 100644

> --- a/include/hw/qdev-properties.h

> +++ b/include/hw/qdev-properties.h

> @@ -18,7 +18,6 @@ extern const PropertyInfo qdev_prop_uint64;

>   extern const PropertyInfo qdev_prop_int64;

>   extern const PropertyInfo qdev_prop_size;

>   extern const PropertyInfo qdev_prop_string;

> -extern const PropertyInfo qdev_prop_tpm;

>   extern const PropertyInfo qdev_prop_on_off_auto;

>   extern const PropertyInfo qdev_prop_size32;

>   extern const PropertyInfo qdev_prop_uuid;
Marc-André Lureau Oct. 30, 2020, 5:02 p.m. UTC | #2
On Fri, Oct 30, 2020 at 2:24 AM Eduardo Habkost <ehabkost@redhat.com> wrote:

> Move the variable declaration close to the macro that uses it.

>

> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

>


Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>



> ---

> Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>

> Cc: Paolo Bonzini <pbonzini@redhat.com>

> Cc: "Daniel P. Berrangé" <berrange@redhat.com>

> Cc: Eduardo Habkost <ehabkost@redhat.com>

> Cc: qemu-devel@nongnu.org

> ---

>  hw/tpm/tpm_prop.h            | 2 ++

>  include/hw/qdev-properties.h | 1 -

>  2 files changed, 2 insertions(+), 1 deletion(-)

>

> diff --git a/hw/tpm/tpm_prop.h b/hw/tpm/tpm_prop.h

> index 85e1ae5718..871af584b7 100644

> --- a/hw/tpm/tpm_prop.h

> +++ b/hw/tpm/tpm_prop.h

> @@ -25,6 +25,8 @@

>  #include "sysemu/tpm_backend.h"

>  #include "hw/qdev-properties.h"

>

> +extern const PropertyInfo qdev_prop_tpm;

> +

>  #define DEFINE_PROP_TPMBE(_n, _s, _f)                     \

>      DEFINE_PROP(_n, _s, _f, qdev_prop_tpm, TPMBackend *)

>

> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h

> index e1ef466790..2b00a1bcf6 100644

> --- a/include/hw/qdev-properties.h

> +++ b/include/hw/qdev-properties.h

> @@ -18,7 +18,6 @@ extern const PropertyInfo qdev_prop_uint64;

>  extern const PropertyInfo qdev_prop_int64;

>  extern const PropertyInfo qdev_prop_size;

>  extern const PropertyInfo qdev_prop_string;

> -extern const PropertyInfo qdev_prop_tpm;

>  extern const PropertyInfo qdev_prop_on_off_auto;

>  extern const PropertyInfo qdev_prop_size32;

>  extern const PropertyInfo qdev_prop_uuid;

> --

> 2.28.0

>

>

>


-- 
Marc-André Lureau
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 30, 2020 at 2:24 AM Eduardo Habkost &lt;<a href="mailto:ehabkost@redhat.com">ehabkost@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Move the variable declaration close to the macro that uses it.<br>
<br>
Signed-off-by: Eduardo Habkost &lt;<a href="mailto:ehabkost@redhat.com" target="_blank">ehabkost@redhat.com</a>&gt;<br></blockquote><div><br></div><div><div>Reviewed-by: Marc-André Lureau &lt;<a href="mailto:marcandre.lureau@redhat.com" target="_blank">marcandre.lureau@redhat.com</a>&gt;</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

---<br>
Cc: Stefan Berger &lt;<a href="mailto:stefanb@linux.vnet.ibm.com" target="_blank">stefanb@linux.vnet.ibm.com</a>&gt;<br>
Cc: Paolo Bonzini &lt;<a href="mailto:pbonzini@redhat.com" target="_blank">pbonzini@redhat.com</a>&gt;<br>
Cc: &quot;Daniel P. Berrangé&quot; &lt;<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>&gt;<br>
Cc: Eduardo Habkost &lt;<a href="mailto:ehabkost@redhat.com" target="_blank">ehabkost@redhat.com</a>&gt;<br>
Cc: <a href="mailto:qemu-devel@nongnu.org" target="_blank">qemu-devel@nongnu.org</a><br>
---<br>
 hw/tpm/tpm_prop.h            | 2 ++<br>
 include/hw/qdev-properties.h | 1 -<br>
 2 files changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/hw/tpm/tpm_prop.h b/hw/tpm/tpm_prop.h<br>
index 85e1ae5718..871af584b7 100644<br>
--- a/hw/tpm/tpm_prop.h<br>
+++ b/hw/tpm/tpm_prop.h<br>
@@ -25,6 +25,8 @@<br>
 #include &quot;sysemu/tpm_backend.h&quot;<br>
 #include &quot;hw/qdev-properties.h&quot;<br>
<br>
+extern const PropertyInfo qdev_prop_tpm;<br>
+<br>
 #define DEFINE_PROP_TPMBE(_n, _s, _f)                     \<br>
     DEFINE_PROP(_n, _s, _f, qdev_prop_tpm, TPMBackend *)<br>
<br>
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h<br>
index e1ef466790..2b00a1bcf6 100644<br>
--- a/include/hw/qdev-properties.h<br>
+++ b/include/hw/qdev-properties.h<br>
@@ -18,7 +18,6 @@ extern const PropertyInfo qdev_prop_uint64;<br>
 extern const PropertyInfo qdev_prop_int64;<br>
 extern const PropertyInfo qdev_prop_size;<br>
 extern const PropertyInfo qdev_prop_string;<br>
-extern const PropertyInfo qdev_prop_tpm;<br>
 extern const PropertyInfo qdev_prop_on_off_auto;<br>
 extern const PropertyInfo qdev_prop_size32;<br>
 extern const PropertyInfo qdev_prop_uuid;<br>
-- <br>
2.28.0<br>
<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature">Marc-André Lureau<br></div></div>
diff mbox series

Patch

diff --git a/hw/tpm/tpm_prop.h b/hw/tpm/tpm_prop.h
index 85e1ae5718..871af584b7 100644
--- a/hw/tpm/tpm_prop.h
+++ b/hw/tpm/tpm_prop.h
@@ -25,6 +25,8 @@ 
 #include "sysemu/tpm_backend.h"
 #include "hw/qdev-properties.h"
 
+extern const PropertyInfo qdev_prop_tpm;
+
 #define DEFINE_PROP_TPMBE(_n, _s, _f)                     \
     DEFINE_PROP(_n, _s, _f, qdev_prop_tpm, TPMBackend *)
 
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index e1ef466790..2b00a1bcf6 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -18,7 +18,6 @@  extern const PropertyInfo qdev_prop_uint64;
 extern const PropertyInfo qdev_prop_int64;
 extern const PropertyInfo qdev_prop_size;
 extern const PropertyInfo qdev_prop_string;
-extern const PropertyInfo qdev_prop_tpm;
 extern const PropertyInfo qdev_prop_on_off_auto;
 extern const PropertyInfo qdev_prop_size32;
 extern const PropertyInfo qdev_prop_uuid;