diff mbox

watchdog: fix ARCH_BCM_MOBILE dependency

Message ID 1394662322-12445-1-git-send-email-elder@linaro.org
State Accepted
Commit 5e82ec94ac5d2d941414861654032543a75cf823
Headers show

Commit Message

Alex Elder March 12, 2014, 10:12 p.m. UTC
Starting with this commit:
    047ef2fa rename ARCH_BCM to ARCH_BCM_MOBILE (clocksource)
the meaning of the ARCH_BCM config option is changed to represent
all Broadcom chips with code in the mach-bcm directory.

Configuration options related to specific Broadcom platforms should
now use another symbol (currently ARCH_BCM_MOBILE, ARCH_BCM2835, or
ARCH_BCM_5301X).

The BCM_KONA_WDT config option indicates a dependency on ARCH_BCM,
but it should be ARCH_BCM_MOBILE instead.  Fix that.

Signed-off-by: Alex Elder <elder@linaro.org>
---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guenter Roeck March 13, 2014, midnight UTC | #1
On 03/12/2014 03:12 PM, Alex Elder wrote:
> Starting with this commit:
>      047ef2fa rename ARCH_BCM to ARCH_BCM_MOBILE (clocksource)
> the meaning of the ARCH_BCM config option is changed to represent
> all Broadcom chips with code in the mach-bcm directory.
>
> Configuration options related to specific Broadcom platforms should
> now use another symbol (currently ARCH_BCM_MOBILE, ARCH_BCM2835, or
> ARCH_BCM_5301X).
>
> The BCM_KONA_WDT config option indicates a dependency on ARCH_BCM,
> but it should be ARCH_BCM_MOBILE instead.  Fix that.
>
> Signed-off-by: Alex Elder <elder@linaro.org>

Hi Alex,

Markus Mayer already submitted a similar patch:
	http://patchwork.roeck-us.net/patch/1263/

Guenter



--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alex Elder March 13, 2014, 1:41 a.m. UTC | #2
On 03/12/2014 07:00 PM, Guenter Roeck wrote:
> On 03/12/2014 03:12 PM, Alex Elder wrote:
>> Starting with this commit:
>>      047ef2fa rename ARCH_BCM to ARCH_BCM_MOBILE (clocksource)
>> the meaning of the ARCH_BCM config option is changed to represent
>> all Broadcom chips with code in the mach-bcm directory.
>>
>> Configuration options related to specific Broadcom platforms should
>> now use another symbol (currently ARCH_BCM_MOBILE, ARCH_BCM2835, or
>> ARCH_BCM_5301X).
>>
>> The BCM_KONA_WDT config option indicates a dependency on ARCH_BCM,
>> but it should be ARCH_BCM_MOBILE instead.  Fix that.
>>
>> Signed-off-by: Alex Elder <elder@linaro.org>
> 
> Hi Alex,
> 
> Markus Mayer already submitted a similar patch:
>     http://patchwork.roeck-us.net/patch/1263/

Yes someone else pointed that out to me shortly
after I sent mine.  I wasn't aware he had done it.
I discovered the problem independently today and
just sent out the fix.  Thanks.

					-Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 79d2589..47a6f10 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1160,7 +1160,7 @@  config BCM2835_WDT
 
 config BCM_KONA_WDT
 	tristate "BCM Kona Watchdog"
-	depends on ARCH_BCM
+	depends on ARCH_BCM_MOBILE
 	select WATCHDOG_CORE
 	help
 	  Support for the watchdog timer on the following Broadcom BCM281xx