| Message ID | 20201119164325.9536-1-ilina@codeaurora.org |
|---|---|
| State | Accepted |
| Commit | a94ef811f7c3748736b85db0406da8e4ea391ac6 |
| Headers | show |
| Series | [v2] PM / Domains: replace -ENOTSUPP with -EOPNOTSUPP | expand |
On Thu, Nov 19, 2020 at 5:44 PM Lina Iyer <ilina@codeaurora.org> wrote: > > While submitting a patch to add next_wakeup, checkpatch reported this - > > WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP > + return -ENOTSUPP; > > Address the above warning in other functions in pm_domain.h. > > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > --- > include/linux/pm_domain.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h > index 34a8784b0ad4..e55781333695 100644 > --- a/include/linux/pm_domain.h > +++ b/include/linux/pm_domain.h > @@ -259,24 +259,24 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd, > } > static inline int pm_genpd_remove(struct generic_pm_domain *genpd) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int dev_pm_genpd_set_performance_state(struct device *dev, > unsigned int state) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int dev_pm_genpd_add_notifier(struct device *dev, > struct notifier_block *nb) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int dev_pm_genpd_remove_notifier(struct device *dev) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int dev_pm_genpd_set_next_wakeup(struct device *dev, ktime_t next) > @@ -334,13 +334,13 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev, > static inline int of_genpd_add_provider_simple(struct device_node *np, > struct generic_pm_domain *genpd) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int of_genpd_add_provider_onecell(struct device_node *np, > struct genpd_onecell_data *data) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline void of_genpd_del_provider(struct device_node *np) {} > @@ -396,7 +396,7 @@ static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev, > static inline > struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) > { > - return ERR_PTR(-ENOTSUPP); > + return ERR_PTR(-EOPNOTSUPP); > } > #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */ > > -- Applied as 5.11 material, thanks!
diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index 34a8784b0ad4..e55781333695 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -259,24 +259,24 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd, } static inline int pm_genpd_remove(struct generic_pm_domain *genpd) { - return -ENOTSUPP; + return -EOPNOTSUPP; } static inline int dev_pm_genpd_set_performance_state(struct device *dev, unsigned int state) { - return -ENOTSUPP; + return -EOPNOTSUPP; } static inline int dev_pm_genpd_add_notifier(struct device *dev, struct notifier_block *nb) { - return -ENOTSUPP; + return -EOPNOTSUPP; } static inline int dev_pm_genpd_remove_notifier(struct device *dev) { - return -ENOTSUPP; + return -EOPNOTSUPP; } static inline int dev_pm_genpd_set_next_wakeup(struct device *dev, ktime_t next) @@ -334,13 +334,13 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev, static inline int of_genpd_add_provider_simple(struct device_node *np, struct generic_pm_domain *genpd) { - return -ENOTSUPP; + return -EOPNOTSUPP; } static inline int of_genpd_add_provider_onecell(struct device_node *np, struct genpd_onecell_data *data) { - return -ENOTSUPP; + return -EOPNOTSUPP; } static inline void of_genpd_del_provider(struct device_node *np) {} @@ -396,7 +396,7 @@ static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev, static inline struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) { - return ERR_PTR(-ENOTSUPP); + return ERR_PTR(-EOPNOTSUPP); } #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */