| Message ID | 20201119142104.85566-1-alexandru.ardelean@analog.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: xra1403: remove unneeded spi_set_drvdata() | expand |
On Thu, Nov 19, 2020 at 4:04 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean > <alexandru.ardelean@analog.com> wrote: > > > > There is no matching spi_get_drvdata() call in the driver, so there is no > > need to do spi_set_drvdata(). This looks like it probably was copied from a > > driver that used both spi_set_drvdata() & spi_get_drvdata(). > > While above luckily (*) okay it may not always be the case. > > *) it can be paired with dev_get_drvdata() which is usual for PM callbacks. > > With amended commit message > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > I applied this patch. I wasn't sure exactly how you want the commit message to be changed - it sounds pretty clear to me so I took it. Bartosz > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > > --- > > drivers/gpio/gpio-xra1403.c | 10 +--------- > > 1 file changed, 1 insertion(+), 9 deletions(-) > > > > diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c > > index e2cac12092af..49c878cfd5c6 100644 > > --- a/drivers/gpio/gpio-xra1403.c > > +++ b/drivers/gpio/gpio-xra1403.c > > @@ -186,15 +186,7 @@ static int xra1403_probe(struct spi_device *spi) > > return ret; > > } > > > > - ret = devm_gpiochip_add_data(&spi->dev, &xra->chip, xra); > > - if (ret < 0) { > > - dev_err(&spi->dev, "Unable to register gpiochip\n"); > > - return ret; > > - } > > - > > - spi_set_drvdata(spi, xra); > > - > > - return 0; > > + return devm_gpiochip_add_data(&spi->dev, &xra->chip, xra); > > } > > > > static const struct spi_device_id xra1403_ids[] = { > > -- > > 2.17.1
On Mon, Nov 30, 2020 at 6:37 PM Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > > On Thu, Nov 19, 2020 at 4:04 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > > On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean > > <alexandru.ardelean@analog.com> wrote: > > > > > > There is no matching spi_get_drvdata() call in the driver, so there is no > > > need to do spi_set_drvdata(). This looks like it probably was copied from a > > > driver that used both spi_set_drvdata() & spi_get_drvdata(). > > > > While above luckily (*) okay it may not always be the case. > > > > *) it can be paired with dev_get_drvdata() which is usual for PM callbacks. > > > > With amended commit message > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > > > I applied this patch. I wasn't sure exactly how you want the commit > message to be changed - it sounds pretty clear to me so I took it. For example, by adding " or dev_get_drvdata()" to the end. -- With Best Regards, Andy Shevchenko
diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c index e2cac12092af..49c878cfd5c6 100644 --- a/drivers/gpio/gpio-xra1403.c +++ b/drivers/gpio/gpio-xra1403.c @@ -186,15 +186,7 @@ static int xra1403_probe(struct spi_device *spi) return ret; } - ret = devm_gpiochip_add_data(&spi->dev, &xra->chip, xra); - if (ret < 0) { - dev_err(&spi->dev, "Unable to register gpiochip\n"); - return ret; - } - - spi_set_drvdata(spi, xra); - - return 0; + return devm_gpiochip_add_data(&spi->dev, &xra->chip, xra); } static const struct spi_device_id xra1403_ids[] = {
There is no matching spi_get_drvdata() call in the driver, so there is no need to do spi_set_drvdata(). This looks like it probably was copied from a driver that used both spi_set_drvdata() & spi_get_drvdata(). Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> --- drivers/gpio/gpio-xra1403.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)