diff mbox series

[v5,08/11] input: raspberrypi-ts: Release firmware handle when not needed

Message ID 20201123183833.18750-9-nsaenzjulienne@suse.de
State Superseded
Headers show
Series None | expand

Commit Message

Nicolas Saenz Julienne Nov. 23, 2020, 6:38 p.m. UTC
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

---

Changes since v3:
 - Release firmware handle in probe function

Changes since v2:
 - Use devm_rpi_firmware_get(), instead of remove function

 drivers/input/touchscreen/raspberrypi-ts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Dec. 2, 2020, 6:03 a.m. UTC | #1
Hi Nicolas,

On Mon, Nov 23, 2020 at 07:38:29PM +0100, Nicolas Saenz Julienne wrote:
> Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware

> interface when unbinding the device.


I do not believe this comment is correct any longer. Otherwise:

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>


> 

> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

> 

> ---

> 

> Changes since v3:

>  - Release firmware handle in probe function

> 

> Changes since v2:

>  - Use devm_rpi_firmware_get(), instead of remove function

> 

>  drivers/input/touchscreen/raspberrypi-ts.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/input/touchscreen/raspberrypi-ts.c b/drivers/input/touchscreen/raspberrypi-ts.c

> index ef6aaed217cf..5000f5fd9ec3 100644

> --- a/drivers/input/touchscreen/raspberrypi-ts.c

> +++ b/drivers/input/touchscreen/raspberrypi-ts.c

> @@ -160,7 +160,7 @@ static int rpi_ts_probe(struct platform_device *pdev)

>  	touchbuf = (u32)ts->fw_regs_phys;

>  	error = rpi_firmware_property(fw, RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF,

>  				      &touchbuf, sizeof(touchbuf));

> -

> +	rpi_firmware_put(fw);

>  	if (error || touchbuf != 0) {

>  		dev_warn(dev, "Failed to set touchbuf, %d\n", error);

>  		return error;

> -- 

> 2.29.2

> 


-- 
Dmitry
Nicolas Saenz Julienne Dec. 3, 2020, 2:52 p.m. UTC | #2
On Tue, 2020-12-01 at 22:03 -0800, Dmitry Torokhov wrote:
> Hi Nicolas,

> 

> On Mon, Nov 23, 2020 at 07:38:29PM +0100, Nicolas Saenz Julienne wrote:

> > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware

> > interface when unbinding the device.

> 

> I do not believe this comment is correct any longer. Otherwise:

> 

> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>


Yes, sorry for that. I'll update it.

Regards,
Nicolas
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/raspberrypi-ts.c b/drivers/input/touchscreen/raspberrypi-ts.c
index ef6aaed217cf..5000f5fd9ec3 100644
--- a/drivers/input/touchscreen/raspberrypi-ts.c
+++ b/drivers/input/touchscreen/raspberrypi-ts.c
@@ -160,7 +160,7 @@  static int rpi_ts_probe(struct platform_device *pdev)
 	touchbuf = (u32)ts->fw_regs_phys;
 	error = rpi_firmware_property(fw, RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF,
 				      &touchbuf, sizeof(touchbuf));
-
+	rpi_firmware_put(fw);
 	if (error || touchbuf != 0) {
 		dev_warn(dev, "Failed to set touchbuf, %d\n", error);
 		return error;