| Message ID | 20201208084912.20949-1-info@metux.net |
|---|---|
| State | New |
| Headers | show |
| Series | net: 8021q: vlan: reduce noise in driver initialization | expand |
Hi "Enrico,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on net-next/master net/master linus/master v5.10-rc7 next-20201208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576
config: nds32-randconfig-r014-20201208 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7c73ca17c3872132d7bd1b9407a26dd5ed916e2c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821
git checkout 7c73ca17c3872132d7bd1b9407a26dd5ed916e2c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
nds32le-linux-ld: net/8021q/vlan_dev.o: in function `vlan_ethtool_get_drvinfo':
>> vlan_dev.c:(.text+0x2e8): undefined reference to `vlan_fullname'
>> nds32le-linux-ld: vlan_dev.c:(.text+0x2ec): undefined reference to `vlan_fullname'
>> nds32le-linux-ld: vlan_dev.c:(.text+0x300): undefined reference to `vlan_version'
nds32le-linux-ld: vlan_dev.c:(.text+0x304): undefined reference to `vlan_version'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..9f4b1b9a37e4 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -42,9 +42,6 @@ unsigned int vlan_net_id __read_mostly; -const char vlan_fullname[] = "802.1Q VLAN Support"; -const char vlan_version[] = DRV_VERSION; - /* End of global variables definitions. */ static int vlan_group_prealloc_vid(struct vlan_group *vg, @@ -687,8 +684,6 @@ static int __init vlan_proto_init(void) { int err; - pr_info("%s v%s\n", vlan_fullname, vlan_version); - err = register_pernet_subsys(&vlan_net_ops); if (err < 0) goto err0;
If drivers work properly, they should be silent. Thus remove the unncessary noise von initialization. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> --- net/8021q/vlan.c | 5 ----- 1 file changed, 5 deletions(-)