mbox series

[0/8] pinctrl: ralink: rt2880: Some minimal clean ups

Message ID 20201213161721.6514-1-sergio.paracuellos@gmail.com
Headers show
Series pinctrl: ralink: rt2880: Some minimal clean ups | expand

Message

Sergio Paracuellos Dec. 13, 2020, 4:17 p.m. UTC
After this driver was moved from staging into pinctrl subsytems
some reviews for bindigns and driver itself comes from Ron Herring
and Dan Carpenter. Get rid of all the comments to properly be in
a good shape before merge window.

Best regards,
    Sergio Paracuellos

Sergio Paracuellos (8):
  dt-bindings: pinctrl: rt2880: properly redo bindings
  pinctrl: ralink: rt2880: avoid double pointer to simplify code
  pinctrl: ralink: rt2880: return proper error code
  pinctrl: ralink: rt2880: add missing NULL check
  pinctrl: ralink: rt2880: delete not needed error message
  pinctrl: ralink: rt2880: preserve error codes
  pinctrl: ralink: rt2880: use 'PTR_ERR_OR_ZERO'
  staging: mt7621-dts: properly name pinctrl related nodes

 .../pinctrl/ralink,rt2880-pinmux.yaml         | 62 +++++++++----------
 drivers/pinctrl/ralink/pinctrl-rt2880.c       | 45 +++++++-------
 drivers/staging/mt7621-dts/mt7621.dtsi        | 46 +++++++-------
 3 files changed, 73 insertions(+), 80 deletions(-)

Comments

Linus Walleij Dec. 14, 2020, 9:01 a.m. UTC | #1
On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:

> After this driver was moved from staging into pinctrl subsytems
> some reviews for bindigns and driver itself comes from Ron Herring
> and Dan Carpenter. Get rid of all the comments to properly be in
> a good shape before merge window.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

If Greg wants he can queue them last minute. Else I'll apply these
after the merge window, no big deal.

Yours,
Linus Walleij
Linus Walleij Jan. 4, 2021, 2:39 p.m. UTC | #2
On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:

> After this driver was moved from staging into pinctrl subsytems

> some reviews for bindigns and driver itself comes from Ron Herring

> and Dan Carpenter. Get rid of all the comments to properly be in

> a good shape before merge window.


Applied patches 1-7 to the pinctrl tree, patch 8 needs to be sent
to Greg.

Yours,
Linus Walleij
Sergio Paracuellos Jan. 4, 2021, 2:45 p.m. UTC | #3
Hi,

On Mon, Jan 4, 2021 at 3:39 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>

> On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos

> <sergio.paracuellos@gmail.com> wrote:

>

> > After this driver was moved from staging into pinctrl subsytems

> > some reviews for bindigns and driver itself comes from Ron Herring

> > and Dan Carpenter. Get rid of all the comments to properly be in

> > a good shape before merge window.

>

> Applied patches 1-7 to the pinctrl tree, patch 8 needs to be sent

> to Greg.


Thanks Linus. PATCH 8 should apply directly as it is in this series
also in staging. Greg, can you take PATCH 8 from this series or do you
want me to resend it?

>

> Yours,

> Linus Walleij


Best regards,
    Sergio Paracuellos
Greg Kroah-Hartman Jan. 4, 2021, 2:55 p.m. UTC | #4
On Mon, Jan 04, 2021 at 03:45:36PM +0100, Sergio Paracuellos wrote:
> Hi,

> 

> On Mon, Jan 4, 2021 at 3:39 PM Linus Walleij <linus.walleij@linaro.org> wrote:

> >

> > On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos

> > <sergio.paracuellos@gmail.com> wrote:

> >

> > > After this driver was moved from staging into pinctrl subsytems

> > > some reviews for bindigns and driver itself comes from Ron Herring

> > > and Dan Carpenter. Get rid of all the comments to properly be in

> > > a good shape before merge window.

> >

> > Applied patches 1-7 to the pinctrl tree, patch 8 needs to be sent

> > to Greg.

> 

> Thanks Linus. PATCH 8 should apply directly as it is in this series

> also in staging. Greg, can you take PATCH 8 from this series or do you

> want me to resend it?


Resend please.

thanks,

greg k-h