| Message ID | 1609865076-13890-1-git-send-email-loic.poulain@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] mhi: unconstify mhi_event_config | expand |
Hi Loic On 1/5/21 8:44 AM, Loic Poulain wrote: > Some parameters may have to be determined at runtime. > It is the case for the event ring MSI vector. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > v2: no change > > include/linux/mhi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index 62da830..48b1b2a 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -290,7 +290,7 @@ struct mhi_controller_config { > u32 num_channels; > const struct mhi_channel_config *ch_cfg; > u32 num_events; > - const struct mhi_event_config *event_cfg; > + struct mhi_event_config *event_cfg; commented on previous patch set, copying my comment here Do we need to update mhi controller driver like ath11k and generic pci driver to avoid compiler warnings? > bool use_bounce_buf; > bool m2_no_db; > }; > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
On Wed, Jan 06, 2021 at 09:39:27AM +0100, Loic Poulain wrote: > Hi Hemant, > > On Wed, 6 Jan 2021 at 03:28, Hemant Kumar <hemantk@codeaurora.org> wrote: > > > Hi Loic > > > > On 1/5/21 8:44 AM, Loic Poulain wrote: > > > Some parameters may have to be determined at runtime. > > > It is the case for the event ring MSI vector. > > > > > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > --- > > > v2: no change > > > > > > include/linux/mhi.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > > > index 62da830..48b1b2a 100644 > > > --- a/include/linux/mhi.h > > > +++ b/include/linux/mhi.h > > > @@ -290,7 +290,7 @@ struct mhi_controller_config { > > > u32 num_channels; > > > const struct mhi_channel_config *ch_cfg; > > > u32 num_events; > > > - const struct mhi_event_config *event_cfg; > > > + struct mhi_event_config *event_cfg; > > commented on previous patch set, copying my comment here > > Do we need to update mhi controller driver like ath11k and generic pci > > driver to avoid compiler warnings? > > > > ath11k does declare its mhi_event_config as const so it should not cause > any issue. mhi_pci_generic event config is modified in 2/2. > Ath11k doesn't declare it as const. It might be an issue before but not now ;) Thanks, Mani > Regards, > Loic
On Tue, Jan 05, 2021 at 05:44:35PM +0100, Loic Poulain wrote: > Some parameters may have to be determined at runtime. > It is the case for the event ring MSI vector. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Applied to mhi-next! Thanks, Mani > --- > v2: no change > > include/linux/mhi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index 62da830..48b1b2a 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -290,7 +290,7 @@ struct mhi_controller_config { > u32 num_channels; > const struct mhi_channel_config *ch_cfg; > u32 num_events; > - const struct mhi_event_config *event_cfg; > + struct mhi_event_config *event_cfg; > bool use_bounce_buf; > bool m2_no_db; > }; > -- > 2.7.4 >
Hello: This series was applied to qcom/linux.git (refs/heads/for-next): On Tue, 5 Jan 2021 17:44:35 +0100 you wrote: > Some parameters may have to be determined at runtime. > It is the case for the event ring MSI vector. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > v2: no change > > [...] Here is the summary with links: - [v2,1/2] mhi: unconstify mhi_event_config https://git.kernel.org/qcom/c/fcba4b2047a3 - [v2,2/2] mhi: pci_generic: Fix shared MSI vector support https://git.kernel.org/qcom/c/b91c3b30e226 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/include/linux/mhi.h b/include/linux/mhi.h index 62da830..48b1b2a 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -290,7 +290,7 @@ struct mhi_controller_config { u32 num_channels; const struct mhi_channel_config *ch_cfg; u32 num_events; - const struct mhi_event_config *event_cfg; + struct mhi_event_config *event_cfg; bool use_bounce_buf; bool m2_no_db; };