| Message ID | 20210111145445.28854-2-ribalda@chromium.org |
|---|---|
| State | Accepted |
| Commit | c432147c771d5efe00d0e96ceb7779636cd31300 |
| Headers | show |
| Series | media: staging/intel-ipu3 : Do not zero reserved fields | expand |
Hi Ricardo, On 11/01/2021 14:54, Ricardo Ribalda wrote: > Core code already clears reserved fields of struct > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero > v4l2_plane_pix_format reserved fields"). > > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> This is just 9/9 of the series right ? ;-) -- Kieran > --- > drivers/staging/media/ipu3/ipu3-v4l2.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c > index 4dc8d9165f63..60aa02eb7d2a 100644 > --- a/drivers/staging/media/ipu3/ipu3-v4l2.c > +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c > @@ -773,9 +773,6 @@ static int imgu_try_fmt(struct file *file, void *fh, struct v4l2_format *f) > > pixm->pixelformat = fmt->fourcc; > > - memset(pixm->plane_fmt[0].reserved, 0, > - sizeof(pixm->plane_fmt[0].reserved)); > - > return 0; > } > >
Hi Kieran On Tue, Jan 12, 2021 at 12:59 PM Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > > Hi Ricardo, > > On 11/01/2021 14:54, Ricardo Ribalda wrote: > > Core code already clears reserved fields of struct > > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero > > v4l2_plane_pix_format reserved fields"). > > > > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > > This is just 9/9 of the series right ? ;-) I was just testing that you were doing a good review :P My bad, I sent the mails with git email-send 00* and I forgot to clean before :(. I already marked the patch as obsolete in patchwork. Sorry for wasting your time Best regards! > -- > Kieran > > > --- > > drivers/staging/media/ipu3/ipu3-v4l2.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c > > index 4dc8d9165f63..60aa02eb7d2a 100644 > > --- a/drivers/staging/media/ipu3/ipu3-v4l2.c > > +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c > > @@ -773,9 +773,6 @@ static int imgu_try_fmt(struct file *file, void *fh, struct v4l2_format *f) > > > > pixm->pixelformat = fmt->fourcc; > > > > - memset(pixm->plane_fmt[0].reserved, 0, > > - sizeof(pixm->plane_fmt[0].reserved)); > > - > > return 0; > > } > > > > > -- Ricardo Ribalda
diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c index 4dc8d9165f63..60aa02eb7d2a 100644 --- a/drivers/staging/media/ipu3/ipu3-v4l2.c +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c @@ -773,9 +773,6 @@ static int imgu_try_fmt(struct file *file, void *fh, struct v4l2_format *f) pixm->pixelformat = fmt->fourcc; - memset(pixm->plane_fmt[0].reserved, 0, - sizeof(pixm->plane_fmt[0].reserved)); - return 0; }
Core code already clears reserved fields of struct v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields"). Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- drivers/staging/media/ipu3/ipu3-v4l2.c | 3 --- 1 file changed, 3 deletions(-)