| Message ID | 20210111191926.3688443-22-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 94f0d0c80cf3c84debb8123ed0b058ecc9e081c0 |
| Headers | show |
| Series | Rid W=1 warnings from GPU | expand |
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:415:6: warning: no previous prototype for ‘dce110_get_required_compressed_surfacesize’ [-Wmissing-prototypes] > > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Leo Li <sunpeng.li@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied. Thanks! Alex > --- > .../amd/display/dc/dce110/dce110_compressor.c | 30 ------------------- > 1 file changed, 30 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c > index 72b580a4eb856..18b0a69b0b1e8 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c > @@ -412,36 +412,6 @@ void dce110_compressor_destroy(struct compressor **compressor) > *compressor = NULL; > } > > -bool dce110_get_required_compressed_surfacesize(struct fbc_input_info fbc_input_info, > - struct fbc_requested_compressed_size size) > -{ > - bool result = false; > - > - unsigned int max_x = FBC_MAX_X, max_y = FBC_MAX_Y; > - > - get_max_support_fbc_buffersize(&max_x, &max_y); > - > - if (fbc_input_info.dynamic_fbc_buffer_alloc == 0) { > - /* > - * For DCE11 here use Max HW supported size: HW Support up to 3840x2400 resolution > - * or 18000 chunks. > - */ > - size.preferred_size = size.min_size = align_to_chunks_number_per_line(max_x) * max_y * 4; /* (For FBC when LPT not supported). */ > - size.preferred_size_alignment = size.min_size_alignment = 0x100; /* For FBC when LPT not supported */ > - size.bits.preferred_must_be_framebuffer_pool = 1; > - size.bits.min_must_be_framebuffer_pool = 1; > - > - result = true; > - } > - /* > - * Maybe to add registry key support with optional size here to override above > - * for debugging purposes > - */ > - > - return result; > -} > - > - > void get_max_support_fbc_buffersize(unsigned int *max_x, unsigned int *max_y) > { > *max_x = FBC_MAX_X; > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c index 72b580a4eb856..18b0a69b0b1e8 100644 --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c @@ -412,36 +412,6 @@ void dce110_compressor_destroy(struct compressor **compressor) *compressor = NULL; } -bool dce110_get_required_compressed_surfacesize(struct fbc_input_info fbc_input_info, - struct fbc_requested_compressed_size size) -{ - bool result = false; - - unsigned int max_x = FBC_MAX_X, max_y = FBC_MAX_Y; - - get_max_support_fbc_buffersize(&max_x, &max_y); - - if (fbc_input_info.dynamic_fbc_buffer_alloc == 0) { - /* - * For DCE11 here use Max HW supported size: HW Support up to 3840x2400 resolution - * or 18000 chunks. - */ - size.preferred_size = size.min_size = align_to_chunks_number_per_line(max_x) * max_y * 4; /* (For FBC when LPT not supported). */ - size.preferred_size_alignment = size.min_size_alignment = 0x100; /* For FBC when LPT not supported */ - size.bits.preferred_must_be_framebuffer_pool = 1; - size.bits.min_must_be_framebuffer_pool = 1; - - result = true; - } - /* - * Maybe to add registry key support with optional size here to override above - * for debugging purposes - */ - - return result; -} - - void get_max_support_fbc_buffersize(unsigned int *max_x, unsigned int *max_y) { *max_x = FBC_MAX_X;
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:415:6: warning: no previous prototype for ‘dce110_get_required_compressed_surfacesize’ [-Wmissing-prototypes] Cc: Harry Wentland <harry.wentland@amd.com> Cc: Leo Li <sunpeng.li@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- .../amd/display/dc/dce110/dce110_compressor.c | 30 ------------------- 1 file changed, 30 deletions(-)