| Message ID | 1610388462-16322-1-git-send-email-loic.poulain@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,1/3] bus: mhi: core: Add helper API to return number of free TREs | expand |
On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > From: Hemant Kumar <hemantk@codeaurora.org> > > Introduce mhi_get_free_desc_count() API to return number > of TREs available to queue buffer. MHI clients can use this > API to know before hand if ring is full without calling queue > API. > > Signed-off-by: Hemant Kumar <hemantk@codeaurora.org> > Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Can we apply these to net-next or does it need to be on a stable branch that will also get pulled into mhi-next?
On Wed, Jan 13, 2021 at 07:33:01PM -0800, Jakub Kicinski wrote: > On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > > From: Hemant Kumar <hemantk@codeaurora.org> > > > > Introduce mhi_get_free_desc_count() API to return number > > of TREs available to queue buffer. MHI clients can use this > > API to know before hand if ring is full without calling queue > > API. > > > > Signed-off-by: Hemant Kumar <hemantk@codeaurora.org> > > Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Can we apply these to net-next or does it need to be on a stable branch > that will also get pulled into mhi-next? We should use the immutable branch for this so that I can pull into mhi-next. Thanks, Mani
On Thu, 14 Jan 2021 09:27:49 +0530 Manivannan Sadhasivam wrote: > On Wed, Jan 13, 2021 at 07:33:01PM -0800, Jakub Kicinski wrote: > > On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > > > From: Hemant Kumar <hemantk@codeaurora.org> > > > > > > Introduce mhi_get_free_desc_count() API to return number > > > of TREs available to queue buffer. MHI clients can use this > > > API to know before hand if ring is full without calling queue > > > API. > > > > > > Signed-off-by: Hemant Kumar <hemantk@codeaurora.org> > > > Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > > Can we apply these to net-next or does it need to be on a stable branch > > that will also get pulled into mhi-next? > > We should use the immutable branch for this so that I can pull into > mhi-next. Thanks for a quire reply! Loic, FWIW git merge-base is your friend.
On Wed, Jan 13, 2021 at 08:02:46PM -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 09:27:49 +0530 Manivannan Sadhasivam wrote: > > On Wed, Jan 13, 2021 at 07:33:01PM -0800, Jakub Kicinski wrote: > > > On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > > > > From: Hemant Kumar <hemantk@codeaurora.org> > > > > > > > > Introduce mhi_get_free_desc_count() API to return number > > > > of TREs available to queue buffer. MHI clients can use this > > > > API to know before hand if ring is full without calling queue > > > > API. > > > > > > > > Signed-off-by: Hemant Kumar <hemantk@codeaurora.org> > > > > Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> > > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > > > > Can we apply these to net-next or does it need to be on a stable branch > > > that will also get pulled into mhi-next? > > > > We should use the immutable branch for this so that I can pull into > > mhi-next. > Please find the immutable branch: https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-net-immutable I've now merged this into mhi-next! Thanks, Mani > Thanks for a quire reply! > > Loic, FWIW git merge-base is your friend.
On Wed, 27 Jan 2021 16:53:17 +0530 Manivannan Sadhasivam wrote: > On Wed, Jan 13, 2021 at 08:02:46PM -0800, Jakub Kicinski wrote: > > On Thu, 14 Jan 2021 09:27:49 +0530 Manivannan Sadhasivam wrote: > > > On Wed, Jan 13, 2021 at 07:33:01PM -0800, Jakub Kicinski wrote: > > > > On Mon, 11 Jan 2021 19:07:40 +0100 Loic Poulain wrote: > > > > > From: Hemant Kumar <hemantk@codeaurora.org> > > > > > > > > > > Introduce mhi_get_free_desc_count() API to return number > > > > > of TREs available to queue buffer. MHI clients can use this > > > > > API to know before hand if ring is full without calling queue > > > > > API. > > > > > > > > > > Signed-off-by: Hemant Kumar <hemantk@codeaurora.org> > > > > > Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> > > > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > > > > > > Can we apply these to net-next or does it need to be on a stable branch > > > > that will also get pulled into mhi-next? > > > > > > We should use the immutable branch for this so that I can pull into > > > mhi-next. > > > > Please find the immutable branch: > https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-net-immutable > > I've now merged this into mhi-next! Loic, please prepare a proper pull request based on that with the other patches included.
diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c index 3db1108..4e31f4f 100644 --- a/drivers/bus/mhi/core/main.c +++ b/drivers/bus/mhi/core/main.c @@ -309,6 +309,18 @@ int mhi_destroy_device(struct device *dev, void *data) return 0; } +int mhi_get_free_desc_count(struct mhi_device *mhi_dev, + enum dma_data_direction dir) +{ + struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl; + struct mhi_chan *mhi_chan = (dir == DMA_TO_DEVICE) ? + mhi_dev->ul_chan : mhi_dev->dl_chan; + struct mhi_ring *tre_ring = &mhi_chan->tre_ring; + + return get_nr_avail_ring_elements(mhi_cntrl, tre_ring); +} +EXPORT_SYMBOL_GPL(mhi_get_free_desc_count); + void mhi_notify(struct mhi_device *mhi_dev, enum mhi_callback cb_reason) { struct mhi_driver *mhi_drv; diff --git a/include/linux/mhi.h b/include/linux/mhi.h index cd571ad..62da830 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -614,6 +614,15 @@ void mhi_set_mhi_state(struct mhi_controller *mhi_cntrl, void mhi_notify(struct mhi_device *mhi_dev, enum mhi_callback cb_reason); /** + * mhi_get_free_desc_count - Get transfer ring length + * Get # of TD available to queue buffers + * @mhi_dev: Device associated with the channels + * @dir: Direction of the channel + */ +int mhi_get_free_desc_count(struct mhi_device *mhi_dev, + enum dma_data_direction dir); + +/** * mhi_prepare_for_power_up - Do pre-initialization before power up. * This is optional, call this before power up if * the controller does not want bus framework to