| Message ID | 20201012154050.68039-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 542baf5108e052684c3abdeea57861f12f89a6b9 |
| Headers | show |
| Series | [v1] sh: Drop ARCH_NR_GPIOS definition | expand |
On Mon, Oct 12, 2020 at 06:40:50PM +0300, Andy Shevchenko wrote: > The default by generic header is the same, hence drop unnecessary definition. Any comment on this? > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/sh/include/asm/gpio.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/sh/include/asm/gpio.h b/arch/sh/include/asm/gpio.h > index 351918894e86..d643250f0a0f 100644 > --- a/arch/sh/include/asm/gpio.h > +++ b/arch/sh/include/asm/gpio.h > @@ -16,7 +16,6 @@ > #include <cpu/gpio.h> > #endif > > -#define ARCH_NR_GPIOS 512 > #include <asm-generic/gpio.h> > > #ifdef CONFIG_GPIOLIB > -- > 2.28.0 > -- With Best Regards, Andy Shevchenko
On 11/9/20 6:13 AM, Andy Shevchenko wrote: > On Mon, Oct 12, 2020 at 06:40:50PM +0300, Andy Shevchenko wrote: >> The default by generic header is the same, hence drop unnecessary definition. > > Any comment on this? Acked-by: Rob Landley <rob@landley.net> It's in the stack I forwarded to Rich to look at this weekend. Rob
On Wed, Nov 11, 2020 at 10:45:38AM -0600, Rob Landley wrote: > On 11/9/20 6:13 AM, Andy Shevchenko wrote: > > On Mon, Oct 12, 2020 at 06:40:50PM +0300, Andy Shevchenko wrote: > >> The default by generic header is the same, hence drop unnecessary definition. > > > > Any comment on this? > > Acked-by: Rob Landley <rob@landley.net> Thanks! > It's in the stack I forwarded to Rich to look at this weekend. Unfortunately I still do not see this in the latest Linux Next. -- With Best Regards, Andy Shevchenko
Hi Andy! On 12/28/20 10:36 PM, Andy Shevchenko wrote: > On Wed, Nov 11, 2020 at 10:45:38AM -0600, Rob Landley wrote: >> On 11/9/20 6:13 AM, Andy Shevchenko wrote: >>> On Mon, Oct 12, 2020 at 06:40:50PM +0300, Andy Shevchenko wrote: >>>> The default by generic header is the same, hence drop unnecessary definition. >>> >>> Any comment on this? >> >> Acked-by: Rob Landley <rob@landley.net> > > Thanks! > >> It's in the stack I forwarded to Rich to look at this weekend. > > Unfortunately I still do not see this in the latest Linux Next. Rich already mentioned that he planned to pick up any patches the next weeks/days. I'm currently testing all the patches recently posted for any regressions. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hi Andy! On 10/12/20 5:40 PM, Andy Shevchenko wrote: > The default by generic header is the same, hence drop unnecessary definition. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/sh/include/asm/gpio.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/sh/include/asm/gpio.h b/arch/sh/include/asm/gpio.h > index 351918894e86..d643250f0a0f 100644 > --- a/arch/sh/include/asm/gpio.h > +++ b/arch/sh/include/asm/gpio.h > @@ -16,7 +16,6 @@ > #include <cpu/gpio.h> > #endif > > -#define ARCH_NR_GPIOS 512 > #include <asm-generic/gpio.h> > > #ifdef CONFIG_GPIOLIB > Verified on my SH-7785LCR board. Boots fine. Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
On 1/1/21 7:51 AM, John Paul Adrian Glaubitz wrote: > Hi Andy! > > On 12/28/20 10:36 PM, Andy Shevchenko wrote: >> On Wed, Nov 11, 2020 at 10:45:38AM -0600, Rob Landley wrote: >>> On 11/9/20 6:13 AM, Andy Shevchenko wrote: >>>> On Mon, Oct 12, 2020 at 06:40:50PM +0300, Andy Shevchenko wrote: >>>>> The default by generic header is the same, hence drop unnecessary definition. >>>> >>>> Any comment on this? >>> >>> Acked-by: Rob Landley <rob@landley.net> >> >> Thanks! >> >>> It's in the stack I forwarded to Rich to look at this weekend. >> >> Unfortunately I still do not see this in the latest Linux Next. > > Rich already mentioned that he planned to pick up any patches the next > weeks/days. > > I'm currently testing all the patches recently posted for any regressions. I spoke to him on wednesday and he said he was working on it. Rob
On 10/12/20 5:40 PM, Andy Shevchenko wrote: > The default by generic header is the same, hence drop unnecessary definition. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/sh/include/asm/gpio.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/sh/include/asm/gpio.h b/arch/sh/include/asm/gpio.h > index 351918894e86..d643250f0a0f 100644 > --- a/arch/sh/include/asm/gpio.h > +++ b/arch/sh/include/asm/gpio.h > @@ -16,7 +16,6 @@ > #include <cpu/gpio.h> > #endif > > -#define ARCH_NR_GPIOS 512 > #include <asm-generic/gpio.h> > > #ifdef CONFIG_GPIOLIB Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hi Rob! On 1/2/21 3:12 AM, Rob Landley wrote: >> Rich already mentioned that he planned to pick up any patches the next >> weeks/days. >> >> I'm currently testing all the patches recently posted for any regressions. > > I spoke to him on wednesday and he said he was working on it. Any news on this? I have tested or acked all patches now that I found on the list that are not applied yet. I can assemble a list of these if necessary. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
On 1/18/21 2:20 PM, John Paul Adrian Glaubitz wrote: > Hi Rob! > > On 1/2/21 3:12 AM, Rob Landley wrote: >>> Rich already mentioned that he planned to pick up any patches the next >>> weeks/days. >>> >>> I'm currently testing all the patches recently posted for any regressions. >> >> I spoke to him on wednesday and he said he was working on it. > > Any news on this? I have tested or acked all patches now that I found on the > list that are not applied yet. I can assemble a list of these if necessary. I spoke to him on the 13th and he said he was working on it, just like I spoke to him on the 6th and he said he was working on it. And so on for a few months now. Assembling a list wouldn't hurt, but I've assembled a list at him multiple times. I suspect what I need to do is assemble a git tree and submit a pull request. Rob
diff --git a/arch/sh/include/asm/gpio.h b/arch/sh/include/asm/gpio.h index 351918894e86..d643250f0a0f 100644 --- a/arch/sh/include/asm/gpio.h +++ b/arch/sh/include/asm/gpio.h @@ -16,7 +16,6 @@ #include <cpu/gpio.h> #endif -#define ARCH_NR_GPIOS 512 #include <asm-generic/gpio.h> #ifdef CONFIG_GPIOLIB
The default by generic header is the same, hence drop unnecessary definition. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- arch/sh/include/asm/gpio.h | 1 - 1 file changed, 1 deletion(-)