| Message ID | 20210123141825.15481-1-paul@crapouillou.net |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] dt-bindings/phy: ingenic: Add compatibles for JZ4760(B) SoCs | expand |
On Sat, 23 Jan 2021 14:18:24 +0000, Paul Cercueil wrote: > Add the ingenic,jz4760-phy and ingenic,jz4760b-phy compatible strings, > and make the ingenic,jz4770-phy compatible string require > ingenic,jz4760-phy as a fallback, since both work the same, and the > JZ4760 SoC is older. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > > Notes: > v2: Fix indentation > > .../bindings/phy/ingenic,phy-usb.yaml | 22 ++++++++++++------- > 1 file changed, 14 insertions(+), 8 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/ingenic,cgu.example.dt.yaml: clock-controller@10000000: usb-phy@3c:compatible: 'oneOf' conditional failed, one must be fixed: ['ingenic,jz4770-phy'] is too short 'ingenic,jz4770-phy' is not one of ['ingenic,jz4760-phy', 'ingenic,jz4775-phy', 'ingenic,jz4780-phy', 'ingenic,x1000-phy', 'ingenic,x1830-phy', 'ingenic,x2000-phy'] From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/ingenic,cgu.example.dt.yaml: usb-phy@3c: compatible: 'oneOf' conditional failed, one must be fixed: ['ingenic,jz4770-phy'] is too short 'ingenic,jz4770-phy' is not one of ['ingenic,jz4760-phy', 'ingenic,jz4775-phy', 'ingenic,jz4780-phy', 'ingenic,x1000-phy', 'ingenic,x1830-phy', 'ingenic,x2000-phy'] From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml See https://patchwork.ozlabs.org/patch/1430732 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml b/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml index 0fd93d71fe5a..d59c697ed81e 100644 --- a/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml +++ b/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml @@ -15,13 +15,19 @@ properties: pattern: '^usb-phy@.*' compatible: - enum: - - ingenic,jz4770-phy - - ingenic,jz4775-phy - - ingenic,jz4780-phy - - ingenic,x1000-phy - - ingenic,x1830-phy - - ingenic,x2000-phy + oneOf: + - enum: + - ingenic,jz4760-phy + - ingenic,jz4775-phy + - ingenic,jz4780-phy + - ingenic,x1000-phy + - ingenic,x1830-phy + - ingenic,x2000-phy + - items: + - enum: + - ingenic,jz4760b-phy + - ingenic,jz4770-phy + - const: ingenic,jz4760-phy reg: maxItems: 1 @@ -48,7 +54,7 @@ examples: - | #include <dt-bindings/clock/jz4770-cgu.h> otg_phy: usb-phy@3c { - compatible = "ingenic,jz4770-phy"; + compatible = "ingenic,jz4770-phy", "ingenic,jz4760-phy"; reg = <0x3c 0x10>; vcc-supply = <&vcc>;
Add the ingenic,jz4760-phy and ingenic,jz4760b-phy compatible strings, and make the ingenic,jz4770-phy compatible string require ingenic,jz4760-phy as a fallback, since both work the same, and the JZ4760 SoC is older. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- Notes: v2: Fix indentation .../bindings/phy/ingenic,phy-usb.yaml | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-)