mbox series

[net-next,00/10] Add support for route offload failure notifications

Message ID 20210207082258.3872086-1-idosch@idosch.org
Headers show
Series Add support for route offload failure notifications | expand

Message

Ido Schimmel Feb. 7, 2021, 8:22 a.m. UTC
From: Ido Schimmel <idosch@nvidia.com>

This is a complementary series to the one merged in commit 389cb1ecc86e
("Merge branch 'add-notifications-when-route-hardware-flags-change'").

The previous series added RTM_NEWROUTE notifications to user space
whenever a route was successfully installed in hardware or when its
state in hardware changed. This allows routing daemons to delay
advertisement of routes until they are installed in hardware.

However, if route installation failed, a routing daemon will wait
indefinitely for a notification that will never come. The aim of this
series is to provide a failure notification via a new flag
(RTM_F_OFFLOAD_FAILED) in the RTM_NEWROUTE message. Upon such a
notification a routing daemon may decide to withdraw the route from the
FIB.

Series overview:

Patch #1 adds the new RTM_F_OFFLOAD_FAILED flag

Patches #2-#3 and #4-#5 add failure notifications to IPv4 and IPv6,
respectively

Patches #6-#8 teach netdevsim to fail route installation via a new knob
in debugfs

Patch #9 extends mlxsw to mark routes with the new flag

Patch #10 adds test cases for the new notification over netdevsim

Amit Cohen (9):
  rtnetlink: Add RTM_F_OFFLOAD_FAILED flag
  IPv4: Add "offload failed" indication to routes
  IPv4: Extend 'fib_notify_on_flag_change' sysctl
  IPv6: Add "offload failed" indication to routes
  IPv6: Extend 'fib_notify_on_flag_change' sysctl
  netdevsim: fib: Do not warn if route was not found for several events
  netdevsim: fib: Add debugfs to debug route offload failure
  mlxsw: spectrum_router: Set offload_failed flag
  selftests: netdevsim: Test route offload failure notifications

Ido Schimmel (1):
  netdevsim: dev: Initialize FIB module after debugfs

 Documentation/networking/ip-sysctl.rst        |   6 +-
 .../ethernet/mellanox/mlxsw/spectrum_router.c |  58 +++++++-
 drivers/net/netdevsim/dev.c                   |  40 +++---
 drivers/net/netdevsim/fib.c                   | 123 +++++++++++++++-
 include/net/ip6_fib.h                         |   5 +-
 include/net/ip_fib.h                          |   3 +-
 include/uapi/linux/rtnetlink.h                |   5 +
 net/ipv4/fib_lookup.h                         |   3 +-
 net/ipv4/fib_semantics.c                      |   3 +
 net/ipv4/fib_trie.c                           |  13 +-
 net/ipv4/route.c                              |   1 +
 net/ipv4/sysctl_net_ipv4.c                    |   2 +-
 net/ipv6/route.c                              |  14 +-
 net/ipv6/sysctl_net_ipv6.c                    |   2 +-
 .../net/netdevsim/fib_notifications.sh        | 134 +++++++++++++++++-
 15 files changed, 372 insertions(+), 40 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 9, 2021, 1 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Sun,  7 Feb 2021 10:22:48 +0200 you wrote:
> From: Ido Schimmel <idosch@nvidia.com>

> 

> This is a complementary series to the one merged in commit 389cb1ecc86e

> ("Merge branch 'add-notifications-when-route-hardware-flags-change'").

> 

> The previous series added RTM_NEWROUTE notifications to user space

> whenever a route was successfully installed in hardware or when its

> state in hardware changed. This allows routing daemons to delay

> advertisement of routes until they are installed in hardware.

> 

> [...]


Here is the summary with links:
  - [net-next,01/10] rtnetlink: Add RTM_F_OFFLOAD_FAILED flag
    https://git.kernel.org/netdev/net-next/c/49fc251360a1
  - [net-next,02/10] IPv4: Add "offload failed" indication to routes
    https://git.kernel.org/netdev/net-next/c/36c5100e859d
  - [net-next,03/10] IPv4: Extend 'fib_notify_on_flag_change' sysctl
    https://git.kernel.org/netdev/net-next/c/648106c30a63
  - [net-next,04/10] IPv6: Add "offload failed" indication to routes
    https://git.kernel.org/netdev/net-next/c/0c5fcf9e249e
  - [net-next,05/10] IPv6: Extend 'fib_notify_on_flag_change' sysctl
    https://git.kernel.org/netdev/net-next/c/6fad361ae9f4
  - [net-next,06/10] netdevsim: fib: Do not warn if route was not found for several events
    https://git.kernel.org/netdev/net-next/c/484a4dfb7558
  - [net-next,07/10] netdevsim: dev: Initialize FIB module after debugfs
    https://git.kernel.org/netdev/net-next/c/f57ab5b75f71
  - [net-next,08/10] netdevsim: fib: Add debugfs to debug route offload failure
    https://git.kernel.org/netdev/net-next/c/134c75324240
  - [net-next,09/10] mlxsw: spectrum_router: Set offload_failed flag
    https://git.kernel.org/netdev/net-next/c/a4cb1c02c3e1
  - [net-next,10/10] selftests: netdevsim: Test route offload failure notifications
    https://git.kernel.org/netdev/net-next/c/9ee53e37532f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html