| Message ID | 20210125200856.1976-1-me@dylanvanassche.be |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] leds: gpio: Set max brightness to 1 | expand |
On Mon 2021-01-25 21:08:57, Dylan Van Assche wrote: > GPIO LEDs only know 2 states: ON or OFF and do not have PWM capabilities. > However, the max brightness is reported as 255. > > This patch sets the max brightness value of a GPIO controlled LED to 1. > > Tested on my PinePhone 1.2. > > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> I believe I have applied this already. Thanks for patches, Pavel -- http://www.livejournal.com/~pavelmachek
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 93f5b1b60fde..242bb38cadee 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -96,7 +96,9 @@ static int create_gpio_led(const struct gpio_led *template, } else { state = (template->default_state == LEDS_GPIO_DEFSTATE_ON); } - led_dat->cdev.brightness = state ? LED_FULL : LED_OFF; + led_dat->cdev.brightness = state; + led_dat->cdev.max_brightness = 1; + if (!template->retain_state_suspended) led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME; if (template->panic_indicator)
GPIO LEDs only know 2 states: ON or OFF and do not have PWM capabilities. However, the max brightness is reported as 255. This patch sets the max brightness value of a GPIO controlled LED to 1. Tested on my PinePhone 1.2. Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> --- v2 drops an obsolete change in include/linux/leds.h v3 simplifies the patch for better readability drivers/leds/leds-gpio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)