| Message ID | 20210218093753.1700-1-zbestahu@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy | expand |
Always mention version number and version history in a patch. Don't resend it now anyway. On 18-02-21, 17:37, Yue Hu wrote: > From: Yue Hu <huyue2@yulong.com> > > Currently, update_lock is also used in sugov_update_single_freq(). The > comment is not helpful anymore. > > Signed-off-by: Yue Hu <huyue2@yulong.com> > --- > kernel/sched/cpufreq_schedutil.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c > index add8081..fd43d59 100644 > --- a/kernel/sched/cpufreq_schedutil.c > +++ b/kernel/sched/cpufreq_schedutil.c > @@ -26,7 +26,7 @@ struct sugov_policy { > struct sugov_tunables *tunables; > struct list_head tunables_hook; > > - raw_spinlock_t update_lock; /* For shared policies */ > + raw_spinlock_t update_lock; > u64 last_freq_update_time; > s64 freq_update_delay_ns; > unsigned int next_freq; Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Thu, 18 Feb 2021 15:09:24 +0530 Viresh Kumar <viresh.kumar@linaro.org> wrote: > Always mention version number and version history in a patch. Don't > resend it now anyway. ok, got it. Thank you. > > On 18-02-21, 17:37, Yue Hu wrote: > > From: Yue Hu <huyue2@yulong.com> > > > > Currently, update_lock is also used in sugov_update_single_freq(). > > The comment is not helpful anymore. > > > > Signed-off-by: Yue Hu <huyue2@yulong.com> > > --- > > kernel/sched/cpufreq_schedutil.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c index add8081..fd43d59 100644 > > --- a/kernel/sched/cpufreq_schedutil.c > > +++ b/kernel/sched/cpufreq_schedutil.c > > @@ -26,7 +26,7 @@ struct sugov_policy { > > struct sugov_tunables *tunables; > > struct list_head tunables_hook; > > > > - raw_spinlock_t update_lock; /* For > > shared policies */ > > + raw_spinlock_t update_lock; > > u64 last_freq_update_time; > > s64 freq_update_delay_ns; > > unsigned int next_freq; > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> >
On Thu, Feb 18, 2021 at 11:51 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > Always mention version number and version history in a patch. Don't > resend it now anyway. > > On 18-02-21, 17:37, Yue Hu wrote: > > From: Yue Hu <huyue2@yulong.com> > > > > Currently, update_lock is also used in sugov_update_single_freq(). The > > comment is not helpful anymore. > > > > Signed-off-by: Yue Hu <huyue2@yulong.com> > > --- > > kernel/sched/cpufreq_schedutil.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c > > index add8081..fd43d59 100644 > > --- a/kernel/sched/cpufreq_schedutil.c > > +++ b/kernel/sched/cpufreq_schedutil.c > > @@ -26,7 +26,7 @@ struct sugov_policy { > > struct sugov_tunables *tunables; > > struct list_head tunables_hook; > > > > - raw_spinlock_t update_lock; /* For shared policies */ > > + raw_spinlock_t update_lock; > > u64 last_freq_update_time; > > s64 freq_update_delay_ns; > > unsigned int next_freq; > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Applied as 5.12-rc material, thanks!
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index add8081..fd43d59 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -26,7 +26,7 @@ struct sugov_policy { struct sugov_tunables *tunables; struct list_head tunables_hook; - raw_spinlock_t update_lock; /* For shared policies */ + raw_spinlock_t update_lock; u64 last_freq_update_time; s64 freq_update_delay_ns; unsigned int next_freq;