| Message ID | 20210101165507.19486-1-tiny.windzz@gmail.com |
|---|---|
| Headers | show |
| Series | Introduce devm_pm_opp_* API | expand |
01.01.2021 19:54, Yangtao Li пишет: > Hi, > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > devm_pm_opp_register_notifier. > > Yangtao Li (31): > opp: Add devres wrapper for dev_pm_opp_set_clkname and > dev_pm_opp_put_clkname > opp: Add devres wrapper for dev_pm_opp_set_regulators and > dev_pm_opp_put_regulators > opp: Add devres wrapper for dev_pm_opp_set_supported_hw > opp: Add devres wrapper for dev_pm_opp_of_add_table > opp: Add devres wrapper for dev_pm_opp_register_notifier > serial: qcom_geni_serial: fix potential mem leak in > qcom_geni_serial_probe() > serial: qcom_geni_serial: convert to use devm_pm_opp_* API > spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe() > spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe() > qcom-geni-se: remove opp_table > mmc: sdhci-msm: fix potential mem leak in sdhci_msm_probe() > mmc: sdhci-msm: convert to use devm_pm_opp_* API > spi: spi-qcom-qspi: fix potential mem leak in qcom_qspi_probe() > spi: spi-qcom-qspi: convert to use devm_pm_opp_* API > drm/msm: fix potential mem leak > drm/msm: convert to use devm_pm_opp_* API and remove dp_ctrl_put > drm/lima: convert to use devm_pm_opp_* API > drm/lima: remove unneeded devm_devfreq_remove_device() > drm/panfrost: convert to use devm_pm_opp_* API > media: venus: fix error check in core_get_v4() > media: venus: convert to use devm_pm_opp_* API > memory: samsung: exynos5422-dmc: fix return error in > exynos5_init_freq_table > memory: samsung: exynos5422-dmc: convert to use devm_pm_opp_* API > memory: tegra20: convert to use devm_pm_opp_* API > memory: tegra30: convert to use devm_pm_opp_* API > PM / devfreq: tegra30: convert to use devm_pm_opp_* API > PM / devfreq: rk3399_dmc: convert to use devm_pm_opp_* API > PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API > PM / devfreq: imx-bus: convert to use devm_pm_opp_* API > PM / devfreq: exynos: convert to use devm_pm_opp_* API > PM / devfreq: convert to devm_pm_opp_register_notifier and remove > unused API > > drivers/devfreq/devfreq.c | 66 +------ > drivers/devfreq/exynos-bus.c | 42 +---- > drivers/devfreq/imx-bus.c | 14 +- > drivers/devfreq/imx8m-ddrc.c | 15 +- > drivers/devfreq/rk3399_dmc.c | 22 +-- > drivers/devfreq/tegra30-devfreq.c | 21 +-- > drivers/gpu/drm/lima/lima_devfreq.c | 45 +---- > drivers/gpu/drm/lima/lima_devfreq.h | 2 - > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 31 ++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 - > drivers/gpu/drm/msm/dp/dp_ctrl.c | 29 +-- > drivers/gpu/drm/msm/dp/dp_ctrl.h | 1 - > drivers/gpu/drm/msm/dp/dp_display.c | 5 +- > drivers/gpu/drm/msm/dsi/dsi_host.c | 23 ++- > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 34 +--- > drivers/gpu/drm/panfrost/panfrost_devfreq.h | 1 - > .../media/platform/qcom/venus/pm_helpers.c | 22 +-- > drivers/memory/samsung/exynos5422-dmc.c | 13 +- > drivers/memory/tegra/tegra20-emc.c | 29 +-- > drivers/memory/tegra/tegra30-emc.c | 29 +-- > drivers/mmc/host/sdhci-msm.c | 27 ++- > drivers/opp/core.c | 173 ++++++++++++++++++ > drivers/opp/of.c | 36 ++++ > drivers/spi/spi-geni-qcom.c | 23 ++- > drivers/spi/spi-qcom-qspi.c | 25 ++- > drivers/tty/serial/qcom_geni_serial.c | 31 ++-- > include/linux/devfreq.h | 23 --- > include/linux/pm_opp.h | 38 ++++ > include/linux/qcom-geni-se.h | 2 - > 32 files changed, 402 insertions(+), 428 deletions(-) > Hello, Could you please add helper for dev_pm_opp_attach_genpd() and make cpufreq drivers to use the helpers? I'd also like to see a devm helper for dev_pm_opp_register_set_opp_helper(), which should become useful for Tegra drivers sometime soon.
03.01.2021 17:30, Frank Lee пишет: > HI, > > On Sun, Jan 3, 2021 at 8:52 PM Dmitry Osipenko <digetx@gmail.com> wrote: >> >> 01.01.2021 19:54, Yangtao Li пишет: >>> Hi, >>> >>> This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, >>> devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, >>> devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and >>> devm_pm_opp_register_notifier. >>> >>> Yangtao Li (31): >>> opp: Add devres wrapper for dev_pm_opp_set_clkname and >>> dev_pm_opp_put_clkname >>> opp: Add devres wrapper for dev_pm_opp_set_regulators and >>> dev_pm_opp_put_regulators >>> opp: Add devres wrapper for dev_pm_opp_set_supported_hw >>> opp: Add devres wrapper for dev_pm_opp_of_add_table >>> opp: Add devres wrapper for dev_pm_opp_register_notifier >>> serial: qcom_geni_serial: fix potential mem leak in >>> qcom_geni_serial_probe() >>> serial: qcom_geni_serial: convert to use devm_pm_opp_* API >>> spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe() >>> spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe() >>> qcom-geni-se: remove opp_table >>> mmc: sdhci-msm: fix potential mem leak in sdhci_msm_probe() >>> mmc: sdhci-msm: convert to use devm_pm_opp_* API >>> spi: spi-qcom-qspi: fix potential mem leak in qcom_qspi_probe() >>> spi: spi-qcom-qspi: convert to use devm_pm_opp_* API >>> drm/msm: fix potential mem leak >>> drm/msm: convert to use devm_pm_opp_* API and remove dp_ctrl_put >>> drm/lima: convert to use devm_pm_opp_* API >>> drm/lima: remove unneeded devm_devfreq_remove_device() >>> drm/panfrost: convert to use devm_pm_opp_* API >>> media: venus: fix error check in core_get_v4() >>> media: venus: convert to use devm_pm_opp_* API >>> memory: samsung: exynos5422-dmc: fix return error in >>> exynos5_init_freq_table >>> memory: samsung: exynos5422-dmc: convert to use devm_pm_opp_* API >>> memory: tegra20: convert to use devm_pm_opp_* API >>> memory: tegra30: convert to use devm_pm_opp_* API >>> PM / devfreq: tegra30: convert to use devm_pm_opp_* API >>> PM / devfreq: rk3399_dmc: convert to use devm_pm_opp_* API >>> PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API >>> PM / devfreq: imx-bus: convert to use devm_pm_opp_* API >>> PM / devfreq: exynos: convert to use devm_pm_opp_* API >>> PM / devfreq: convert to devm_pm_opp_register_notifier and remove >>> unused API >>> >>> drivers/devfreq/devfreq.c | 66 +------ >>> drivers/devfreq/exynos-bus.c | 42 +---- >>> drivers/devfreq/imx-bus.c | 14 +- >>> drivers/devfreq/imx8m-ddrc.c | 15 +- >>> drivers/devfreq/rk3399_dmc.c | 22 +-- >>> drivers/devfreq/tegra30-devfreq.c | 21 +-- >>> drivers/gpu/drm/lima/lima_devfreq.c | 45 +---- >>> drivers/gpu/drm/lima/lima_devfreq.h | 2 - >>> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- >>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- >>> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- >>> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 31 ++-- >>> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 - >>> drivers/gpu/drm/msm/dp/dp_ctrl.c | 29 +-- >>> drivers/gpu/drm/msm/dp/dp_ctrl.h | 1 - >>> drivers/gpu/drm/msm/dp/dp_display.c | 5 +- >>> drivers/gpu/drm/msm/dsi/dsi_host.c | 23 ++- >>> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 34 +--- >>> drivers/gpu/drm/panfrost/panfrost_devfreq.h | 1 - >>> .../media/platform/qcom/venus/pm_helpers.c | 22 +-- >>> drivers/memory/samsung/exynos5422-dmc.c | 13 +- >>> drivers/memory/tegra/tegra20-emc.c | 29 +-- >>> drivers/memory/tegra/tegra30-emc.c | 29 +-- >>> drivers/mmc/host/sdhci-msm.c | 27 ++- >>> drivers/opp/core.c | 173 ++++++++++++++++++ >>> drivers/opp/of.c | 36 ++++ >>> drivers/spi/spi-geni-qcom.c | 23 ++- >>> drivers/spi/spi-qcom-qspi.c | 25 ++- >>> drivers/tty/serial/qcom_geni_serial.c | 31 ++-- >>> include/linux/devfreq.h | 23 --- >>> include/linux/pm_opp.h | 38 ++++ >>> include/linux/qcom-geni-se.h | 2 - >>> 32 files changed, 402 insertions(+), 428 deletions(-) >>> >> >> Hello, >> >> Could you please add helper for dev_pm_opp_attach_genpd() and make >> cpufreq drivers to use the helpers? > > Thank you for reminding me. But we shouldn't use this for CPU devices > as the CPU device doesn't get bound to a driver, it is rather a fake platform > device which gets the cpufreq drivers probed. Indeed, the CPU device exists seprately from cpufreq driver. >> I'd also like to see a devm helper for >> dev_pm_opp_register_set_opp_helper(), which should become useful for >> Tegra drivers sometime soon. > > For non-cpu devices? For DRM driver I'd want to use devm for both set_opp_helper() and opp_attach_genpd(). https://patchwork.ozlabs.org/project/linux-tegra/patch/20201217180638.22748-39-digetx@gmail.com/
On 01-01-21, 16:54, Yangtao Li wrote: > Add devres wrapper for dev_pm_opp_register_notifier() to simplify driver > code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/opp/core.c | 38 ++++++++++++++++++++++++++++++++++++++ > include/linux/pm_opp.h | 6 ++++++ > 2 files changed, 44 insertions(+) > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index 6b83e373f0d8..ef3544f8cecd 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -2599,6 +2599,44 @@ int dev_pm_opp_unregister_notifier(struct device *dev, > } > EXPORT_SYMBOL(dev_pm_opp_unregister_notifier); > > +static void devm_pm_opp_notifier_release(struct device *dev, void *res) > +{ > + struct notifier_block *nb = *(struct notifier_block **)res; > + > + WARN_ON(dev_pm_opp_unregister_notifier(dev, nb)); > +} > + > +/** > + * devm_pm_opp_register_notifier() - Register OPP notifier for the device > + * @dev: Device for which notifier needs to be registered > + * @nb: Notifier block to be registered > + * > + * Return: 0 on success or a negative error value. > + * > + * The notifier will be unregistered after the device is destroyed. > + */ > +int devm_pm_opp_register_notifier(struct device *dev, struct notifier_block *nb) > +{ > + struct notifier_block **ptr; > + int ret; > + > + ptr = devres_alloc(devm_pm_opp_notifier_release, sizeof(*ptr), GFP_KERNEL); > + if (!ptr) > + return -ENOMEM; > + > + ret = dev_pm_opp_register_notifier(dev, nb); > + if (ret) { > + devres_free(ptr); > + return ret; > + } > + > + *ptr = nb; > + devres_add(dev, ptr); > + > + return 0; > +} > +EXPORT_SYMBOL(devm_pm_opp_register_notifier); I am not in favor of this patch, and it only has one user, which makes it more unwanted.
Dropped lots of people from cc list On 04-01-21, 12:49, Viresh Kumar wrote: > On 01-01-21, 16:54, Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code, and we don't need > > to make opp_table glabal. > > > > Let's remove opp_table from geni_se later. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/tty/serial/qcom_geni_serial.c | 23 +++++++++-------------- > > 1 file changed, 9 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > > index 5aada7ebae35..36a92df8ec11 100644 > > --- a/drivers/tty/serial/qcom_geni_serial.c > > +++ b/drivers/tty/serial/qcom_geni_serial.c > > @@ -1352,6 +1352,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) > > int irq; > > bool console = false; > > struct uart_driver *drv; > > + struct opp_table *opp_table; > > > > if (of_device_is_compatible(pdev->dev.of_node, "qcom,geni-debug-uart")) > > console = true; > > @@ -1433,13 +1434,13 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) > > if (of_property_read_bool(pdev->dev.of_node, "cts-rts-swap")) > > port->cts_rts_swap = true; > > > > - port->se.opp_table = dev_pm_opp_set_clkname(&pdev->dev, "se"); > > - if (IS_ERR(port->se.opp_table)) > > - return PTR_ERR(port->se.opp_table); > > + opp_table = devm_pm_opp_set_clkname(&pdev->dev, "se"); > > + if (IS_ERR(opp_table)) > > + return PTR_ERR(opp_table); > > /* OPP table is optional */ > > - ret = dev_pm_opp_of_add_table(&pdev->dev); > > + ret = devm_pm_opp_of_add_table(&pdev->dev); > > if (ret) { > > - dev_pm_opp_put_clkname(port->se.opp_table); > > + devm_pm_opp_put_clkname(&pdev->dev, opp_table); > > We shouldn't be doing this here, i.e. put_clkname. Even when the OPP > table isn't present, this driver calls dev_pm_opp_set_rate() which > behaves like clk_set_rate() in this case and so the clk name is still > required by the OPP core. The same problem is there with multiple patches, fix them all please.
On Fri, Jan 01, 2021 at 04:54:59PM +0000, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/memory/samsung/exynos5422-dmc.c | 21 +++++---------------- > 1 file changed, 5 insertions(+), 16 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
01.01.2021 19:54, Yangtao Li пишет: > Add devres wrapper for dev_pm_opp_set_supported_hw() to simplify driver > code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/opp/core.c | 38 ++++++++++++++++++++++++++++++++++++++ > include/linux/pm_opp.h | 8 ++++++++ > 2 files changed, 46 insertions(+) Reviewed-by: Dmitry Osipenko <digetx@gmail.com> Tested-by: Dmitry Osipenko <digetx@gmail.com>
01.01.2021 19:54, Yangtao Li пишет: > Hi, > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > devm_pm_opp_register_notifier. Hello Yangtao, Thank you for your effort, looking forward to v2!
20.01.2021 19:01, Dmitry Osipenko пишет: > 01.01.2021 19:54, Yangtao Li пишет: >> Hi, >> >> This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, >> devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, >> devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and >> devm_pm_opp_register_notifier. > > Hello Yangtao, > > Thank you for your effort, looking forward to v2! Yangtao, could you please let me know what is the status of this series? Will you be able to make a v2 anytime soon?
On 02-03-21, 16:40, Dmitry Osipenko wrote: > 20.01.2021 19:01, Dmitry Osipenko пишет: > > 01.01.2021 19:54, Yangtao Li пишет: > >> Hi, > >> > >> This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > >> devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > >> devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > >> devm_pm_opp_register_notifier. > > > > Hello Yangtao, > > > > Thank you for your effort, looking forward to v2! > > Yangtao, could you please let me know what is the status of this series? > Will you be able to make a v2 anytime soon? Dmitry, if Yangtao doesn't reply back this week with a proposal, please go ahead and respin the patches yourself. Thanks.
03.03.2021 07:01, Viresh Kumar пишет: > On 02-03-21, 16:40, Dmitry Osipenko wrote: >> 20.01.2021 19:01, Dmitry Osipenko пишет: >>> 01.01.2021 19:54, Yangtao Li пишет: >>>> Hi, >>>> >>>> This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, >>>> devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, >>>> devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and >>>> devm_pm_opp_register_notifier. >>> >>> Hello Yangtao, >>> >>> Thank you for your effort, looking forward to v2! >> >> Yangtao, could you please let me know what is the status of this series? >> Will you be able to make a v2 anytime soon? > > Dmitry, if Yangtao doesn't reply back this week with a proposal, please go ahead > and respin the patches yourself. Thanks. > Alright!
Hi, This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and devm_pm_opp_register_notifier. Yangtao Li (31): opp: Add devres wrapper for dev_pm_opp_set_clkname and dev_pm_opp_put_clkname opp: Add devres wrapper for dev_pm_opp_set_regulators and dev_pm_opp_put_regulators opp: Add devres wrapper for dev_pm_opp_set_supported_hw opp: Add devres wrapper for dev_pm_opp_of_add_table opp: Add devres wrapper for dev_pm_opp_register_notifier serial: qcom_geni_serial: fix potential mem leak in qcom_geni_serial_probe() serial: qcom_geni_serial: convert to use devm_pm_opp_* API spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe() spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe() qcom-geni-se: remove opp_table mmc: sdhci-msm: fix potential mem leak in sdhci_msm_probe() mmc: sdhci-msm: convert to use devm_pm_opp_* API spi: spi-qcom-qspi: fix potential mem leak in qcom_qspi_probe() spi: spi-qcom-qspi: convert to use devm_pm_opp_* API drm/msm: fix potential mem leak drm/msm: convert to use devm_pm_opp_* API and remove dp_ctrl_put drm/lima: convert to use devm_pm_opp_* API drm/lima: remove unneeded devm_devfreq_remove_device() drm/panfrost: convert to use devm_pm_opp_* API media: venus: fix error check in core_get_v4() media: venus: convert to use devm_pm_opp_* API memory: samsung: exynos5422-dmc: fix return error in exynos5_init_freq_table memory: samsung: exynos5422-dmc: convert to use devm_pm_opp_* API memory: tegra20: convert to use devm_pm_opp_* API memory: tegra30: convert to use devm_pm_opp_* API PM / devfreq: tegra30: convert to use devm_pm_opp_* API PM / devfreq: rk3399_dmc: convert to use devm_pm_opp_* API PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API PM / devfreq: imx-bus: convert to use devm_pm_opp_* API PM / devfreq: exynos: convert to use devm_pm_opp_* API PM / devfreq: convert to devm_pm_opp_register_notifier and remove unused API drivers/devfreq/devfreq.c | 66 +------ drivers/devfreq/exynos-bus.c | 42 +---- drivers/devfreq/imx-bus.c | 14 +- drivers/devfreq/imx8m-ddrc.c | 15 +- drivers/devfreq/rk3399_dmc.c | 22 +-- drivers/devfreq/tegra30-devfreq.c | 21 +-- drivers/gpu/drm/lima/lima_devfreq.c | 45 +---- drivers/gpu/drm/lima/lima_devfreq.h | 2 - drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 31 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 - drivers/gpu/drm/msm/dp/dp_ctrl.c | 29 +-- drivers/gpu/drm/msm/dp/dp_ctrl.h | 1 - drivers/gpu/drm/msm/dp/dp_display.c | 5 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 23 ++- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 34 +--- drivers/gpu/drm/panfrost/panfrost_devfreq.h | 1 - .../media/platform/qcom/venus/pm_helpers.c | 22 +-- drivers/memory/samsung/exynos5422-dmc.c | 13 +- drivers/memory/tegra/tegra20-emc.c | 29 +-- drivers/memory/tegra/tegra30-emc.c | 29 +-- drivers/mmc/host/sdhci-msm.c | 27 ++- drivers/opp/core.c | 173 ++++++++++++++++++ drivers/opp/of.c | 36 ++++ drivers/spi/spi-geni-qcom.c | 23 ++- drivers/spi/spi-qcom-qspi.c | 25 ++- drivers/tty/serial/qcom_geni_serial.c | 31 ++-- include/linux/devfreq.h | 23 --- include/linux/pm_opp.h | 38 ++++ include/linux/qcom-geni-se.h | 2 - 32 files changed, 402 insertions(+), 428 deletions(-)