mbox series

[0/2] make rockchip pinctrl module able

Message ID 20210305003907.1692515-1-jay.xu@rock-chips.com
Headers show
Series make rockchip pinctrl module able | expand

Message

Jianqun Xu March 5, 2021, 12:39 a.m. UTC 
Make the rockchip pinctrl driver able to be module by unselect
PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.

Jianqun Xu (2):
  arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP
  pinctrl: rockchip: make driver be tristate module

 arch/arm64/Kconfig.platforms       |  2 --
 drivers/pinctrl/Kconfig            |  6 +++++-
 drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
 3 files changed, 18 insertions(+), 3 deletions(-)

Comments

Linus Walleij March 10, 2021, 10:57 p.m. UTC | #1 
On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> Make the rockchip pinctrl driver able to be module by unselect

> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.


This patch set fails like this:

ERROR: modpost: "irq_gc_set_wake"
[drivers/pinctrl/pinctrl-rockchip.ko] undefined!
make[3]: *** [../scripts/Makefile.modpost:132: Module.symvers] Error 1
make[3]: *** Deleting file 'Module.symvers'
make[2]: *** [/home/linus/linux-pinctrl/Makefile:1440: modules] Error 2

Probably this function needs to get exported. (Send a separate
patch for that.)

Yours,
Linus Walleij

Yours,
Linus Walleij
Linus Walleij March 15, 2021, 3:32 p.m. UTC | #2 
On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> Make the rockchip pinctrl driver able to be module by unselect

> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.


Applied this again with the irqchip patch under, let's see how this
works!

Yours,
Linus Walleij
Jianqun Xu March 16, 2021, 12:07 a.m. UTC | #3 
Thanks very much
--------------
jay.xu@rock-chips.com
>On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>
>> Make the rockchip pinctrl driver able to be module by unselect
>> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.
>
>Applied this again with the irqchip patch under, let's see how this
>works!
>
>Yours,
>Linus Walleij
>
>
>