| Message ID | 20210224115146.9131-5-aford173@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [V3,1/5] dt-bindings: net: renesas,etheravb: Add additional clocks | expand |
On Wed, Feb 24, 2021 at 12:52 PM Adam Ford <aford173@gmail.com> wrote: > The AVB refererence clock assumes an external clock that runs reference > automatically. Because the Versaclock is wired to provide the > AVB refclock, the device tree needs to reference it in order for the > driver to start the clock. > > Signed-off-by: Adam Ford <aford173@gmail.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel (with the typo fixed) once the DT bindings have been accepted. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford <aford173@gmail.com> wrote: > > The AVB refererence clock assumes an external clock that runs > > reference > > > automatically. Because the Versaclock is wired to provide the > > AVB refclock, the device tree needs to reference it in order for the > > driver to start the clock. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel (with the typo fixed) once the DT > bindings have been accepted. > Who do I need to ping to get the DT bindings accepted? They have an acked-by from Rob. adam > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Adam, On Thu, Mar 18, 2021 at 1:44 PM Adam Ford <aford173@gmail.com> wrote: > On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford <aford173@gmail.com> wrote: > > > The AVB refererence clock assumes an external clock that runs > > > > reference > > > > > automatically. Because the Versaclock is wired to provide the > > > AVB refclock, the device tree needs to reference it in order for the > > > driver to start the clock. > > > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > i.e. will queue in renesas-devel (with the typo fixed) once the DT > > bindings have been accepted. > > > > Who do I need to ping to get the DT bindings accepted? They have an > acked-by from Rob. Sergei, can you please have a look at the DT binding change? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 18.03.2021 15:44, Adam Ford wrote: >>> The AVB refererence clock assumes an external clock that runs >> >> reference >> >>> automatically. Because the Versaclock is wired to provide the >>> AVB refclock, the device tree needs to reference it in order for the >>> driver to start the clock. >>> >>> Signed-off-by: Adam Ford <aford173@gmail.com> >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> i.e. will queue in renesas-devel (with the typo fixed) once the DT >> bindings have been accepted. >> > > Who do I need to ping to get the DT bindings accepted? They have an > acked-by from Rob. Normally, the bindings get picked up by a subsystem maintainer... or Rob :-) [...] MBR, Sergei
On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford <aford173@gmail.com> wrote: > > The AVB refererence clock assumes an external clock that runs > > reference > > > automatically. Because the Versaclock is wired to provide the > > AVB refclock, the device tree needs to reference it in order for the > > driver to start the clock. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel (with the typo fixed) once the DT > bindings have been accepted. Geert, Since the refclk update and corresponding dt-bindings are in net-next, are you OK applying the rest of the DT changes so they can get into 5.13? adam > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Adam, On Sat, Apr 17, 2021 at 3:54 PM Adam Ford <aford173@gmail.com> wrote: > On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford <aford173@gmail.com> wrote: > > > The AVB refererence clock assumes an external clock that runs > > > > reference > > > > > automatically. Because the Versaclock is wired to provide the > > > AVB refclock, the device tree needs to reference it in order for the > > > driver to start the clock. > > > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > i.e. will queue in renesas-devel (with the typo fixed) once the DT > > bindings have been accepted. > > Geert, > > Since the refclk update and corresponding dt-bindings are in net-next, > are you OK applying the rest of the DT changes so they can get into > 5.13? Queueing in renesas-devel for v5.14, as the soc deadline for v5.13 has already passed two weeks ago. Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi index 8d3a4d6ee885..75355c354c38 100644 --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi @@ -53,6 +53,8 @@ &avb { phy-handle = <&phy0>; rx-internal-delay-ps = <1800>; tx-internal-delay-ps = <2000>; + clocks = <&cpg CPG_MOD 812>, <&versaclock5 4>; + clock-names = "fck", "refclk"; status = "okay"; phy0: ethernet-phy@0 {
The AVB refererence clock assumes an external clock that runs automatically. Because the Versaclock is wired to provide the AVB refclock, the device tree needs to reference it in order for the driver to start the clock. Signed-off-by: Adam Ford <aford173@gmail.com> --- V3: New to series