| Message ID | 20210312145545.26050-1-matthias.bgg@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] dt-bindings: mfd: mediatek: Fix regulator description | expand |
Hi Matthias, Thank you for your patch. There is a typo in the subject line s/dt-bindigns/dt-bindings/ Rob might miss this patch as he filters the patches by subject I guess. Missatge de l'adreça <matthias.bgg@kernel.org> del dia dv., 12 de març 2021 a les 15:57: > > From: Matthias Brugger <mbrugger@suse.com> > > The regulator does not need to have a device tree compatible, if it's > part of an MFD. We leave the node name to the SoC specific name (e.g. > mt6323regulator) to allow older kernels to work with the new binding. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > --- > .../bindings/regulator/mt6323-regulator.txt | 2 +- > .../bindings/regulator/mt6358-regulator.txt | 4 +--- > .../bindings/regulator/mt6397-regulator.txt | 14 +++++--------- > 3 files changed, 7 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt > index a48749db4df36..69f32e1a6702e 100644 > --- a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt > @@ -19,7 +19,7 @@ LDO: > Example: > > pmic: mt6323 { > - mt6323regulator: regulators { > + mt6323regulator { If you convert this binding to YAML, you'll probably get a review that the node name must be just 'regulators' here. And then, looking at the other patches something will break I guess ... > mt6323_vproc_reg: buck_vproc{ > regulator-name = "vproc"; > regulator-min-microvolt = < 700000>; > diff --git a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt > index 9a90a92f2d7e1..ba1214da5bf7c 100644 > --- a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt > @@ -23,9 +23,7 @@ Example: > pmic { > compatible = "mediatek,mt6358"; > > - mt6358regulator: mt6358regulator { > - compatible = "mediatek,mt6358-regulator"; > - > + mt6358regulator { > mt6358_vdram1_reg: buck_vdram1 { > regulator-compatible = "buck_vdram1"; > regulator-name = "vdram1"; > diff --git a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt > index c080086d3e629..2b14362ac56e1 100644 > --- a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt > @@ -1,11 +1,9 @@ > Mediatek MT6397 Regulator > > -Required properties: > -- compatible: "mediatek,mt6397-regulator" > -- mt6397regulator: List of regulators provided by this controller. It is named > - according to its regulator type, buck_<name> and ldo_<name>. > - The definition for each of these nodes is defined using the standard binding > - for regulators at Documentation/devicetree/bindings/regulator/regulator.txt. > +List of regulators provided by this controller. It is named > +according to its regulator type, buck_<name> and ldo_<name>. > +The definition for each of these nodes is defined using the standard binding > +for regulators at Documentation/devicetree/bindings/regulator/regulator.txt. > > The valid names for regulators are:: > BUCK: > @@ -23,9 +21,7 @@ Example: > pmic { > compatible = "mediatek,mt6397"; > > - mt6397regulator: mt6397regulator { > - compatible = "mediatek,mt6397-regulator"; > - > + mt6397regulator { > mt6397_vpca15_reg: buck_vpca15 { > regulator-compatible = "buck_vpca15"; > regulator-name = "vpca15"; > -- > 2.30.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On Fri, 12 Mar 2021, matthias.bgg@kernel.org wrote: > From: Matthias Brugger <mbrugger@suse.com> > > For regulators a compatible string is superfluous. Drop the string. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > --- > drivers/mfd/mt6397-core.c | 3 --- > 1 file changed, 3 deletions(-) Acked-by: Lee Jones <lee.jones@linaro.org> -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
On Fri, 12 Mar 2021 15:55:39 +0100, matthias.bgg@kernel.org wrote: > From: Matthias Brugger <mbrugger@suse.com> > > Having a separate compatible for the regulator node is redundant and not > needed. Delete the corresponding requierement. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > --- > > Documentation/devicetree/bindings/mfd/mt6397.txt | 3 --- > 1 file changed, 3 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, Mar 18, 2021 at 03:11:56PM +0100, Enric Balletbo Serra wrote: > Hi Matthias, > > Thank you for your patch. There is a typo in the subject line > s/dt-bindigns/dt-bindings/ Rob might miss this patch as he filters the > patches by subject I guess. I should, then I'd have a lot less to review... > > Missatge de l'adreça <matthias.bgg@kernel.org> del dia dv., 12 de març > 2021 a les 15:57: > > > > From: Matthias Brugger <mbrugger@suse.com> > > > > The regulator does not need to have a device tree compatible, if it's > > part of an MFD. We leave the node name to the SoC specific name (e.g. > > mt6323regulator) to allow older kernels to work with the new binding. > > > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > > --- > > .../bindings/regulator/mt6323-regulator.txt | 2 +- > > .../bindings/regulator/mt6358-regulator.txt | 4 +--- > > .../bindings/regulator/mt6397-regulator.txt | 14 +++++--------- > > 3 files changed, 7 insertions(+), 13 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt > > index a48749db4df36..69f32e1a6702e 100644 > > --- a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt > > +++ b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt > > @@ -19,7 +19,7 @@ LDO: > > Example: > > > > pmic: mt6323 { This one is wrong... > > - mt6323regulator: regulators { > > + mt6323regulator { And this was right. > > If you convert this binding to YAML, you'll probably get a review that > the node name must be just 'regulators' here. And then, looking at the > other patches something will break I guess ... > > > mt6323_vproc_reg: buck_vproc{ > > regulator-name = "vproc"; > > regulator-min-microvolt = < 700000>; > > diff --git a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt > > index 9a90a92f2d7e1..ba1214da5bf7c 100644 > > --- a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt > > +++ b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt > > @@ -23,9 +23,7 @@ Example: > > pmic { > > compatible = "mediatek,mt6358"; > > > > - mt6358regulator: mt6358regulator { > > - compatible = "mediatek,mt6358-regulator"; > > - > > + mt6358regulator { > > mt6358_vdram1_reg: buck_vdram1 { > > regulator-compatible = "buck_vdram1"; > > regulator-name = "vdram1"; > > diff --git a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt > > index c080086d3e629..2b14362ac56e1 100644 > > --- a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt > > +++ b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt > > @@ -1,11 +1,9 @@ > > Mediatek MT6397 Regulator > > > > -Required properties: > > -- compatible: "mediatek,mt6397-regulator" > > -- mt6397regulator: List of regulators provided by this controller. It is named > > - according to its regulator type, buck_<name> and ldo_<name>. > > - The definition for each of these nodes is defined using the standard binding > > - for regulators at Documentation/devicetree/bindings/regulator/regulator.txt. > > +List of regulators provided by this controller. It is named > > +according to its regulator type, buck_<name> and ldo_<name>. > > +The definition for each of these nodes is defined using the standard binding > > +for regulators at Documentation/devicetree/bindings/regulator/regulator.txt. > > > > The valid names for regulators are:: > > BUCK: > > @@ -23,9 +21,7 @@ Example: > > pmic { > > compatible = "mediatek,mt6397"; > > > > - mt6397regulator: mt6397regulator { > > - compatible = "mediatek,mt6397-regulator"; > > - > > + mt6397regulator { > > mt6397_vpca15_reg: buck_vpca15 { > > regulator-compatible = "buck_vpca15"; > > regulator-name = "vpca15"; > > -- > > 2.30.1 > > > > > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt index 2661775a38251..28a69728e6fe2 100644 --- a/Documentation/devicetree/bindings/mfd/mt6397.txt +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt @@ -33,11 +33,8 @@ Optional subnodes: For details, see ../rtc/rtc-mt6397.txt - regulators Required properties: - - compatible: "mediatek,mt6323-regulator" see ../regulator/mt6323-regulator.txt - - compatible: "mediatek,mt6358-regulator" see ../regulator/mt6358-regulator.txt - - compatible: "mediatek,mt6397-regulator" see ../regulator/mt6397-regulator.txt - codec Required properties: