| Message ID | 20210228124106.135812-2-konrad.dybcio@somainline.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel. > --- > drivers/video/backlight/qcom-wled.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > index 3bc7800eb0a9..497b9035a908 100644 > --- a/drivers/video/backlight/qcom-wled.c > +++ b/drivers/video/backlight/qcom-wled.c > @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev) > > static const struct of_device_id wled_match_table[] = { > { .compatible = "qcom,pm8941-wled", .data = (void *)3 }, > + { .compatible = "qcom,pmi8994-wled", .data = (void *)4 }, > { .compatible = "qcom,pmi8998-wled", .data = (void *)4 }, > { .compatible = "qcom,pm660l-wled", .data = (void *)4 }, > { .compatible = "qcom,pm8150l-wled", .data = (void *)5 }, > -- > 2.30.1
On Tue, Mar 23, 2021 at 08:39:35AM +0000, Lee Jones wrote: > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > Why are you Reviewing/Acking a patch that was applied on the 10th? Simply an oversight. Looks like I forgot to remove it from my backlog when it was applied. Daniel. > > > > --- > > > drivers/video/backlight/qcom-wled.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > > index 3bc7800eb0a9..497b9035a908 100644 > > > --- a/drivers/video/backlight/qcom-wled.c > > > +++ b/drivers/video/backlight/qcom-wled.c > > > @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev) > > > > > > static const struct of_device_id wled_match_table[] = { > > > { .compatible = "qcom,pm8941-wled", .data = (void *)3 }, > > > + { .compatible = "qcom,pmi8994-wled", .data = (void *)4 }, > > > { .compatible = "qcom,pmi8998-wled", .data = (void *)4 }, > > > { .compatible = "qcom,pm660l-wled", .data = (void *)4 }, > > > { .compatible = "qcom,pm8150l-wled", .data = (void *)5 }, > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog
On Tue, 23 Mar 2021, Daniel Thompson wrote: > On Tue, Mar 23, 2021 at 08:39:35AM +0000, Lee Jones wrote: > > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > > > > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > > > > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > > > Why are you Reviewing/Acking a patch that was applied on the 10th? > > Simply an oversight. Looks like I forgot to remove it from my backlog > when it was applied. I wondered if I'd made a mistake. No problem. Thanks for the clarification. > > > > --- > > > > drivers/video/backlight/qcom-wled.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > > > index 3bc7800eb0a9..497b9035a908 100644 > > > > --- a/drivers/video/backlight/qcom-wled.c > > > > +++ b/drivers/video/backlight/qcom-wled.c > > > > @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev) > > > > > > > > static const struct of_device_id wled_match_table[] = { > > > > { .compatible = "qcom,pm8941-wled", .data = (void *)3 }, > > > > + { .compatible = "qcom,pmi8994-wled", .data = (void *)4 }, > > > > { .compatible = "qcom,pmi8998-wled", .data = (void *)4 }, > > > > { .compatible = "qcom,pm660l-wled", .data = (void *)4 }, > > > > { .compatible = "qcom,pm8150l-wled", .data = (void *)5 }, > >
On Wed, 24 Mar 2021, Geert Uytterhoeven wrote: > Hi Lee, > > On Tue, Mar 23, 2021 at 9:40 AM Lee Jones <lee.jones@linaro.org> wrote: > > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > > > > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > > > > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > > > Why are you Reviewing/Acking a patch that was applied on the 10th? > > Only 12 days later?!? > > It's not uncommon to receive acks for patches after they have been > applied upstream. But it is if the patch was applied 10 years and 9 > months ago! > https://lore.kernel.org/linux-m68k/F5513AE92A5A1047AC2F91AEBB9202680288CBBA3983@E2K7-MS2.ds.strath.ac.uk/ That truly is next level! :)
Hi,
> Why are you Reviewing/Acking a patch that was applied on the 10th?
Forgive me if it turns out I'm blind, but I can't see the patch being in either -next, backlight/for-next, or 5.13-rc3. Perhaps it was omitted after all?
Konrad
On Thu, 27 May 2021, Konrad Dybcio wrote: > Hi, > > > Why are you Reviewing/Acking a patch that was applied on the 10th? > > Forgive me if it turns out I'm blind, but I can't see the patch > being in either -next, backlight/for-next, or 5.13-rc3. Perhaps it > was omitted after all? Interesting. It's not you, it's me! No idea what happened exactly TBH, but it's applied again. Should be in -next tomorrow. Apologies for the delay.
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 3bc7800eb0a9..497b9035a908 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev) static const struct of_device_id wled_match_table[] = { { .compatible = "qcom,pm8941-wled", .data = (void *)3 }, + { .compatible = "qcom,pmi8994-wled", .data = (void *)4 }, { .compatible = "qcom,pmi8998-wled", .data = (void *)4 }, { .compatible = "qcom,pm660l-wled", .data = (void *)4 }, { .compatible = "qcom,pm8150l-wled", .data = (void *)5 },
Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- drivers/video/backlight/qcom-wled.c | 1 + 1 file changed, 1 insertion(+)