mbox series

[v6,0/3] Add ZynqMP pinctrl driver

Message ID 1619080202-31924-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com
Headers show
Series Add ZynqMP pinctrl driver | expand

Message

Sai Krishna Potthuri April 22, 2021, 8:29 a.m. UTC 
Add support for Xilinx ZynqMP pinctrl driver and also update
the Xilinx firmware driver to support pinctrl functionality.
This driver queries the pin information from the firmware and
allow configuring the pins as per the request.

Note:
Patch#2 is already applied but sending in this series for
completeness.

changes in v6:
- Rebased the patche series on 'devel' branch in pinctrl tree and no
functional changes.
 
changes in v5:
- Used generic property 'power-source' instead of driver specific for
configuring the IO voltages, updated the same in dt-binding.
- Added support to build driver as a module.
- Used error codes returned by the Xilinx firmware instead of shadowing the
error codes in the driver.
- Fixed comments from Andy related to spell checks, NULL checks, explicit
typecast, header inclusion ordering, removing kernel docs for the
obvious ones.

changes in v4:
- Added comment for ignoring the return value for GET_FUNCTION_NAME qid.
- Updated the zynqmp_pinctrl_get_function_name() API prototype to void as
it always returns zero.

changes in v3:
- Fixed binding doc comments from Rob.
- Used 'maxItems' for groups and pins properties.
- Updated commit subject and description to have present tense statements.

changes in v2:
- Use pattern for pin names in yaml file.
- Updated to support multiple groups and pins.
- Added type ref for the vendor specific properties.
- Removed 'schmitt-cmos', instead used common properties.
- Removed macros for drive-strength property.

Sai Krishna Potthuri (3):
  firmware: xilinx: Add pinctrl support
  dt-bindings: pinctrl: Add binding for ZynqMP pinctrl driver
  pinctrl: Add Xilinx ZynqMP pinctrl driver support

 .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 336 +++++++
 drivers/firmware/xilinx/zynqmp.c              | 114 +++
 drivers/pinctrl/Kconfig                       |  14 +
 drivers/pinctrl/Makefile                      |   1 +
 drivers/pinctrl/pinctrl-zynqmp.c              | 906 ++++++++++++++++++
 include/dt-bindings/pinctrl/pinctrl-zynqmp.h  |  19 +
 include/linux/firmware/xlnx-zynqmp.h          |  90 ++
 7 files changed, 1480 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
 create mode 100644 drivers/pinctrl/pinctrl-zynqmp.c
 create mode 100644 include/dt-bindings/pinctrl/pinctrl-zynqmp.h

Comments

Andy Shevchenko April 23, 2021, 3:54 p.m. UTC | #1 
On Thu, Apr 22, 2021 at 12:14 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Thu, Apr 22, 2021 at 10:30 AM Sai Krishna Potthuri
> <lakshmi.sai.krishna.potthuri@xilinx.com> wrote:
>
> > changes in v6:
> > - Rebased the patche series on 'devel' branch in pinctrl tree and no
> > functional changes.
>
> Remaining patches applied! Thanks for working so hard on this!

Hmm... I have had a bunch of comments. Okay, they may be addressed by
follow up(s).
Linus Walleij April 29, 2021, 2:21 p.m. UTC | #2 
On Fri, Apr 23, 2021 at 5:55 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Apr 22, 2021 at 12:14 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Thu, Apr 22, 2021 at 10:30 AM Sai Krishna Potthuri
> > <lakshmi.sai.krishna.potthuri@xilinx.com> wrote:
> >
> > > changes in v6:
> > > - Rebased the patche series on 'devel' branch in pinctrl tree and no
> > > functional changes.
> >
> > Remaining patches applied! Thanks for working so hard on this!
>
> Hmm... I have had a bunch of comments. Okay, they may be addressed by
> follow up(s).

Sai: can you please address Andy's comments with replies and/or
follow-up patches?

Yours,
Linus Walleij
Sai Krishna Potthuri April 29, 2021, 2:32 p.m. UTC | #3 
Hi Linus,

> -----Original Message-----

> From: Linus Walleij <linus.walleij@linaro.org>

> Sent: Thursday, April 29, 2021 7:52 PM

> To: Andy Shevchenko <andy.shevchenko@gmail.com>

> Cc: Sai Krishna Potthuri <lakshmis@xilinx.com>; Rob Herring

> <robh+dt@kernel.org>; Michal Simek <michals@xilinx.com>; Greg Kroah-

> Hartman <gregkh@linuxfoundation.org>; Linux ARM <linux-arm-

> kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org>;

> open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

> <devicetree@vger.kernel.org>; open list:GPIO SUBSYSTEM <linux-

> gpio@vger.kernel.org>; git <git@xilinx.com>; saikrishna12468@gmail.com

> Subject: Re: [PATCH v6 0/3] Add ZynqMP pinctrl driver

> 

> On Fri, Apr 23, 2021 at 5:55 PM Andy Shevchenko

> <andy.shevchenko@gmail.com> wrote:

> > On Thu, Apr 22, 2021 at 12:14 PM Linus Walleij <linus.walleij@linaro.org>

> wrote:

> > > On Thu, Apr 22, 2021 at 10:30 AM Sai Krishna Potthuri

> > > <lakshmi.sai.krishna.potthuri@xilinx.com> wrote:

> > >

> > > > changes in v6:

> > > > - Rebased the patche series on 'devel' branch in pinctrl tree and

> > > > no functional changes.

> > >

> > > Remaining patches applied! Thanks for working so hard on this!

> >

> > Hmm... I have had a bunch of comments. Okay, they may be addressed by

> > follow up(s).

> 

> Sai: can you please address Andy's comments with replies and/or follow-up

> patches?

Sure, discussing with Andy on couple of comments.
I will send the follow-up patch to address his comments.

Regards
Sai Krishna
> 

> Yours,

> Linus Walleij