| Message ID | 20210316133946.2376963-1-geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | leds: LEDS_BLINK_LGM should depend on X86 | expand |
Hi! > The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO) > is only present on Intel Lightning Mountain SoCs. Hence add a > dependency on X86, to prevent asking the user about this driver when > configuring a kernel without Intel Lightning Mountain platform support. > > While at it, merge the other dependencies into a single statement. > > Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> This rejected, so I applied it by hand. I'm deleting the Fixes tag -- we don't want this in stable. Thanks and best regards, Pavel -- http://www.livejournal.com/~pavelmachek
Hi Pavel, On Sun, Apr 25, 2021 at 10:57 PM Pavel Machek <pavel@ucw.cz> wrote: > > The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO) > > is only present on Intel Lightning Mountain SoCs. Hence add a > > dependency on X86, to prevent asking the user about this driver when > > configuring a kernel without Intel Lightning Mountain platform support. > > > > While at it, merge the other dependencies into a single statement. > > > > Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > This rejected, so I applied it by hand. Thank you! > I'm deleting the Fixes tag -- > we don't want this in stable. Why not? Shouldn't people running stable be shielded from useless questions while configuring their kernels? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon 2021-04-26 09:06:16, Geert Uytterhoeven wrote: > Hi Pavel, > > On Sun, Apr 25, 2021 at 10:57 PM Pavel Machek <pavel@ucw.cz> wrote: > > > The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO) > > > is only present on Intel Lightning Mountain SoCs. Hence add a > > > dependency on X86, to prevent asking the user about this driver when > > > configuring a kernel without Intel Lightning Mountain platform support. > > > > > > While at it, merge the other dependencies into a single statement. > > > > > > Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC") > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > This rejected, so I applied it by hand. > > Thank you! > > > I'm deleting the Fixes tag -- > > we don't want this in stable. > > Why not? Shouldn't people running stable be shielded from useless > questions while configuring their kernels? See stable-kernel-rules. (Maybe updating them to match recent reality would be better, but...) Best regards, Pavel -- http://www.livejournal.com/~pavelmachek
diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig index 6dedc58c47b3ea16..852e634002cda7cf 100644 --- a/drivers/leds/blink/Kconfig +++ b/drivers/leds/blink/Kconfig @@ -9,10 +9,8 @@ if LEDS_BLINK config LEDS_BLINK_LGM tristate "LED support for Intel LGM SoC series" - depends on GPIOLIB - depends on LEDS_CLASS - depends on MFD_SYSCON - depends on OF + depends on X86 || COMPILE_TEST + depends on GPIOLIB && LEDS_CLASS && MFD_SYSCON && OF help Parallel to serial conversion, which is also called SSO controller, can drive external shift register for LED outputs.
The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO) is only present on Intel Lightning Mountain SoCs. Hence add a dependency on X86, to prevent asking the user about this driver when configuring a kernel without Intel Lightning Mountain platform support. While at it, merge the other dependencies into a single statement. Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/leds/blink/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)