| Message ID | 20210423095743.v5.16.Icb581b0273d95cc33ca38676c61ae6d7d2e75357@changeid |
|---|---|
| State | Accepted |
| Commit | 4318ea406e02a7c928e26926bc421b9bcf883fbc |
| Headers | show |
| Series | drm: Fix EDID reading on ti-sn65dsi86; solve some chicken-and-egg problems | expand |
On Fri, Apr 23, 2021 at 1:00 PM Douglas Anderson <dianders@chromium.org> wrote: > > As of commit 5186421cbfe2 ("drm: Introduce epoch counter to > drm_connector") the drm_get_edid() function calls > drm_connector_update_edid_property() for us. There's no reason for us > to call it again. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > As Laurent pointed out [1] this is actually a pretty common > problem. His suggestion to do this more broadly is a good idea but > this series is probably a bit ambitious already so I would suggest > that be taken up separately. > > [1] https://lore.kernel.org/r/YGphgcESWsozCi1y@pendragon.ideasonboard.com > > (no changes since v1) > > drivers/gpu/drm/panel/panel-simple.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index bd208abcbf07..4de33c929a59 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -512,7 +512,6 @@ static int panel_simple_get_modes(struct drm_panel *panel, > if (p->ddc) { > struct edid *edid = drm_get_edid(connector, p->ddc); > > - drm_connector_update_edid_property(connector, edid); > if (edid) { > num += drm_add_edid_modes(connector, edid); > kfree(edid); > -- > 2.31.1.498.g6c1eba8ee3d-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index bd208abcbf07..4de33c929a59 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -512,7 +512,6 @@ static int panel_simple_get_modes(struct drm_panel *panel, if (p->ddc) { struct edid *edid = drm_get_edid(connector, p->ddc); - drm_connector_update_edid_property(connector, edid); if (edid) { num += drm_add_edid_modes(connector, edid); kfree(edid);
As of commit 5186421cbfe2 ("drm: Introduce epoch counter to drm_connector") the drm_get_edid() function calls drm_connector_update_edid_property() for us. There's no reason for us to call it again. Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- As Laurent pointed out [1] this is actually a pretty common problem. His suggestion to do this more broadly is a good idea but this series is probably a bit ambitious already so I would suggest that be taken up separately. [1] https://lore.kernel.org/r/YGphgcESWsozCi1y@pendragon.ideasonboard.com (no changes since v1) drivers/gpu/drm/panel/panel-simple.c | 1 - 1 file changed, 1 deletion(-)