| Message ID | 20210405234713.3190693-1-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 6c525b72f985e967f8d171a7d3f9210c4018decd |
| Headers | show |
| Series | [1/2] drm/panel: Add DT bindings for Samsung LMS397KF04 | expand |
On Tue, 06 Apr 2021 01:47:12 +0200, Linus Walleij wrote: > This adds device tree bindings for the Samsung LMS397KF04 > RGB DPI display panel. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../display/panel/samsung,lms397kf04.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, Apr 6, 2021 at 1:47 AM Linus Walleij <linus.walleij@linaro.org> wrote: > This adds device tree bindings for the Samsung LMS397KF04 > RGB DPI display panel. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Someone on DRM misc up to review and/or apply these two patches? Doug? I bet you have some patch(es) you can toss back at me to review in return. Yours, Linus Walleij
Hi, On Thu, Apr 29, 2021 at 8:39 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > This adds device tree bindings for the Samsung LMS397KF04 > RGB DPI display panel. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../display/panel/samsung,lms397kf04.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) Probably not needed since you have Rob Herring's review, but: Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hi, On Thu, Apr 29, 2021 at 7:34 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Tue, Apr 6, 2021 at 1:47 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > This adds device tree bindings for the Samsung LMS397KF04 > > RGB DPI display panel. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > Someone on DRM misc up to review and/or apply these two > patches? > > Doug? I bet you have some patch(es) you can toss back at me to > review in return. I know next to nothing about MIPI panels, but I gave it my best shot. Please take my comments with a grain of salt since I'm still a bit noobie. I think I already probably owed you a review anyway for previous reviews you did for me. I do have my big 20-part series out there and I certainly won't object to more review but most of the patches are close to having enough review at the moment. For some of the simple (dare I say "trivial"?) patches Bjorn was nice enough to provide review. For the panel patches I got an extra review from Sean Paul. I think there are only one or two patches in the series that have no review at the moment because I had to spin them for Bjorn's feedback and he hasn't gotten back to it yet. -Doug
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml b/Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml new file mode 100644 index 000000000000..4cb75a5f2e3a --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,lms397kf04.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung LMS397KF04 display panel + +description: The datasheet claims this is based around a display controller + named DB7430 with a separate backlight controller. + +maintainers: + - Linus Walleij <linus.walleij@linaro.org> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: samsung,lms397kf04 + + reg: true + + reset-gpios: true + + vci-supply: + description: regulator that supplies the VCI analog voltage + usually around 3.0 V + + vccio-supply: + description: regulator that supplies the VCCIO voltage usually + around 1.8 V + + backlight: true + + spi-max-frequency: + $ref: /schemas/types.yaml#/definitions/uint32 + description: inherited as a SPI client node, the datasheet specifies + maximum 300 ns minimum cycle which gives around 3 MHz max frequency + maximum: 3000000 + + port: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "samsung,lms397kf04"; + spi-max-frequency = <3000000>; + reg = <0>; + vci-supply = <&lcd_3v0_reg>; + vccio-supply = <&lcd_1v8_reg>; + reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; + backlight = <&ktd259>; + + port { + panel_in: endpoint { + remote-endpoint = <&display_out>; + }; + }; + }; + }; + +...
This adds device tree bindings for the Samsung LMS397KF04 RGB DPI display panel. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- .../display/panel/samsung,lms397kf04.yaml | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml -- 2.29.2