| Message ID | 20210311111727.8433-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Commit | 70f7025c854c7edc6965ec2ef4230d09ebb9ffd7 |
| Headers | show |
| Series | [next] bus: mhi: core: remove redundant initialization of variables state and ee | expand |
On Thu, 11 Mar 2021 at 12:18, Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > The variables state and ee are being initialized with values that > are never read and are being updated later with a new values. The > initializations are redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Loic Poulain <loic.poulain@linaro.org> > --- > drivers/bus/mhi/core/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 2c61dfd01353..3faf8bade520 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv) > { > struct mhi_controller *mhi_cntrl = priv; > struct device *dev = &mhi_cntrl->mhi_dev->dev; > - enum mhi_state state = MHI_STATE_MAX; > + enum mhi_state state; > enum mhi_pm_state pm_state = 0; > - enum mhi_ee_type ee = MHI_EE_MAX; > + enum mhi_ee_type ee; > > write_lock_irq(&mhi_cntrl->pm_lock); > if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) { > -- > 2.30.2 >
On Thu, Mar 11, 2021 at 11:17:27AM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variables state and ee are being initialized with values that > are never read and are being updated later with a new values. The > initializations are redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Thanks, Mani > --- > drivers/bus/mhi/core/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 2c61dfd01353..3faf8bade520 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv) > { > struct mhi_controller *mhi_cntrl = priv; > struct device *dev = &mhi_cntrl->mhi_dev->dev; > - enum mhi_state state = MHI_STATE_MAX; > + enum mhi_state state; > enum mhi_pm_state pm_state = 0; > - enum mhi_ee_type ee = MHI_EE_MAX; > + enum mhi_ee_type ee; > > write_lock_irq(&mhi_cntrl->pm_lock); > if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) { > -- > 2.30.2 >
On Thu, Mar 11, 2021 at 11:17:27AM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variables state and ee are being initialized with values that > are never read and are being updated later with a new values. The > initializations are redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to mhi-next! Thanks, Mani > --- > drivers/bus/mhi/core/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 2c61dfd01353..3faf8bade520 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv) > { > struct mhi_controller *mhi_cntrl = priv; > struct device *dev = &mhi_cntrl->mhi_dev->dev; > - enum mhi_state state = MHI_STATE_MAX; > + enum mhi_state state; > enum mhi_pm_state pm_state = 0; > - enum mhi_ee_type ee = MHI_EE_MAX; > + enum mhi_ee_type ee; > > write_lock_irq(&mhi_cntrl->pm_lock); > if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) { > -- > 2.30.2 >
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Thu, 11 Mar 2021 11:17:27 +0000 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variables state and ee are being initialized with values that > are never read and are being updated later with a new values. The > initializations are redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - [next] bus: mhi: core: remove redundant initialization of variables state and ee https://git.kernel.org/qcom/c/70f7025c854c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c index 2c61dfd01353..3faf8bade520 100644 --- a/drivers/bus/mhi/core/main.c +++ b/drivers/bus/mhi/core/main.c @@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv) { struct mhi_controller *mhi_cntrl = priv; struct device *dev = &mhi_cntrl->mhi_dev->dev; - enum mhi_state state = MHI_STATE_MAX; + enum mhi_state state; enum mhi_pm_state pm_state = 0; - enum mhi_ee_type ee = MHI_EE_MAX; + enum mhi_ee_type ee; write_lock_irq(&mhi_cntrl->pm_lock); if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) {