| Message ID | 20210526182807.548118-7-sudeep.holla@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: firmware: Convert SCPI and SCMI to json schema | expand |
On Wed, 26 May 2021 19:28:05 +0100, Sudeep Holla wrote: > Now that the arm,scpi binding is converted to YAML format, the following > errors are seen when doing `make DT_CHECKER_FLAGS=-m dt_binding_check` > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:0:0: /example-1/soc/scpi: failed to match any schema with compatible: ['arm,scpi'] Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:0:0: /example-1/soc/scpi/power-domains-0: failed to match any schema with compatible: ['arm,scpi-power-domains'] See https://patchwork.ozlabs.org/patch/1484218 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Thu, May 27, 2021 at 09:23:27AM -0500, Rob Herring wrote: > On Wed, 26 May 2021 19:28:05 +0100, Sudeep Holla wrote: > > Now that the arm,scpi binding is converted to YAML format, the following > > errors are seen when doing `make DT_CHECKER_FLAGS=-m dt_binding_check` > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:0:0: /example-1/soc/scpi: failed to match any schema with compatible: ['arm,scpi'] > Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:0:0: /example-1/soc/scpi/power-domains-0: failed to match any schema with compatible: ['arm,scpi-power-domains'] > > See https://patchwork.ozlabs.org/patch/1484218 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Just curious if this is built as past of the series as I am unable to hit this issue. However I get this if I remove 5/8 which is adding the scpi yaml schema. Am I missing something ? -- Regards, Sudeep
On Thu, May 27, 2021 at 11:25 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Thu, May 27, 2021 at 09:23:27AM -0500, Rob Herring wrote: > > On Wed, 26 May 2021 19:28:05 +0100, Sudeep Holla wrote: > > > Now that the arm,scpi binding is converted to YAML format, the following > > > errors are seen when doing `make DT_CHECKER_FLAGS=-m dt_binding_check` > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:0:0: /example-1/soc/scpi: failed to match any schema with compatible: ['arm,scpi'] > > Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:0:0: /example-1/soc/scpi/power-domains-0: failed to match any schema with compatible: ['arm,scpi-power-domains'] > > > > See https://patchwork.ozlabs.org/patch/1484218 > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > > > Just curious if this is built as past of the series as I am unable to hit > this issue. However I get this if I remove 5/8 which is adding the scpi > yaml schema. Am I missing something ? The automated check does try to apply series, but runs checks a patch at time and it resets the base if it gets an error on a patch. I think switching patch 5 and 6 order should fix things. Don't worry about that yet, I'll look at the rest of the series. Rob
On Thu, May 27, 2021 at 03:07:39PM -0500, Rob Herring wrote: > On Thu, May 27, 2021 at 11:25 AM Sudeep Holla <sudeep.holla@arm.com> wrote: [...] > > Just curious if this is built as past of the series as I am unable to hit > > this issue. However I get this if I remove 5/8 which is adding the scpi > > yaml schema. Am I missing something ? > > The automated check does try to apply series, but runs checks a patch > at time and it resets the base if it gets an error on a patch. I think > switching patch 5 and 6 order should fix things. Don't worry about > that yet, I'll look at the rest of the series. > Ah OK, will re-order them. Thanks for the review. -- Regards, Sudeep
diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml index d07eb00b97c8..bfdc3e33565e 100644 --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml @@ -126,9 +126,15 @@ additionalProperties: false clock-names = "apb_pclk"; }; - mhu_client_scpi: scpi@2f000000 { + scpi { compatible = "arm,scpi"; - reg = <0 0x2f000000 0 0x200>; mboxes = <&mhuB 1 4>; /* HP-NonSecure, 5th doorbell */ + shmem = <&cpu_scp_hpri>; /* HP-NonSecure */ + + scpi_devpd: power-domains-0 { + compatible = "arm,scpi-power-domains"; + num-domains = <2>; + #power-domain-cells = <1>; + }; }; };
Now that the arm,scpi binding is converted to YAML format, the following errors are seen when doing `make DT_CHECKER_FLAGS=-m dt_binding_check` From schema: Documentation/devicetree/bindings/firmware/arm,scpi.yaml Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: $nodename:0: 'scpi' was expected Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: reg: [[0, 788529152, 0, 512]] is not of type 'object' Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: 'shmem' is a required property Fix those error following the SCPI bindings. Cc: Rob Herring <robh+dt@kernel.org> Cc: Viresh Kumar <viresh.kumar@linaro.org Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.25.1