diff mbox series

[04/13] dt-bindings: mfd: stm32-timers: remove #address/size cells from required properties

Message ID 20210415101037.1465-5-alexandre.torgue@foss.st.com
State Accepted
Commit 00d5fa42210e23803d20e5e255f6ca80a3304875
Headers show
Series ARM: dts: stm32: fix "make dtbs_check W=1" round1 | expand

Commit Message

Alexandre TORGUE April 15, 2021, 10:10 a.m. UTC
address-cells and size-cells can't be declared as "required" properties
as they are not needed if subnodes don't have a "reg" entry.

Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>

Comments

Fabrice Gasnier April 16, 2021, 3:52 p.m. UTC | #1
On 4/15/21 12:10 PM, Alexandre Torgue wrote:
> address-cells and size-cells can't be declared as "required" properties

> as they are not needed if subnodes don't have a "reg" entry.

> 

> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>

> 

> diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml

> index 0f16c8864a87..dace35362a7a 100644

> --- a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml

> +++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml


Hi Alexandre,

Not sure if this matters: patches 3 and 4 could be swapped in the
series. Apart from that:

Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>


Thanks,
Fabrice
> @@ -119,8 +119,6 @@ patternProperties:

>        - compatible

>  

>  required:

> -  - "#address-cells"

> -  - "#size-cells"

>    - compatible

>    - reg

>    - clocks

>
Rob Herring (Arm) April 20, 2021, 8:04 p.m. UTC | #2
On Thu, 15 Apr 2021 12:10:28 +0200, Alexandre Torgue wrote:
> address-cells and size-cells can't be declared as "required" properties

> as they are not needed if subnodes don't have a "reg" entry.

> 

> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>

> 


Acked-by: Rob Herring <robh@kernel.org>
Lee Jones June 1, 2021, 4:26 p.m. UTC | #3
On Thu, 15 Apr 2021, Alexandre Torgue wrote:

> address-cells and size-cells can't be declared as "required" properties

> as they are not needed if subnodes don't have a "reg" entry.

> 

> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>


Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
index 0f16c8864a87..dace35362a7a 100644
--- a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
+++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
@@ -119,8 +119,6 @@  patternProperties:
       - compatible
 
 required:
-  - "#address-cells"
-  - "#size-cells"
   - compatible
   - reg
   - clocks