| Message ID | 20210604115159.8834-1-sergio.paracuellos@gmail.com |
|---|---|
| Headers | show |
| Series | pinctrl: ralink: move all pinmux arch stuff into driver code | expand |
On Fri, Jun 4, 2021 at 1:52 PM Sergio Paracuellos <sergio.paracuellos@gmail.com> wrote: > We currently have 'drivers/pinctrl/ralink/' with common code to all of them > in 'pinctrl-rt2880.c' file. Pinctrl data was being passed in SoC initilization > to the driver. Instead of doing that just move all related code to the driver > itself. We maintain for all of them compatible string to avoid to make more > changes in dts's an so on. If a new compatible string is neccessary to be > defined for each different SoC, we can change them after this series are > applied. > > I have only tested MT7621 platform using GNUBee PC1 board. I don't have > other boards to test other SoC changes. > > This series are rebased on the master branch of linux-pinctrl git tree so > I expect this to be merged through pinctrl tree. Thomas, if 'linux-mips' > is preferred to merge this series just let me know and I can rebase them > to make you things easier. > > Thanks in advance for your time. I have simply applied all patches so we get some testing in linux-next (last time we found some snags through linux-next). This is an important modernization of the ralink SoCs so I am pushing the fastforward button a bit. If some ralink maintainer has opinions they can either patch it or complain loudly so I can take the patches out again. Yours, Linus Walleij
Hi Linus, On Mon, Jun 7, 2021 at 9:23 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Jun 4, 2021 at 1:52 PM Sergio Paracuellos > <sergio.paracuellos@gmail.com> wrote: > > > We currently have 'drivers/pinctrl/ralink/' with common code to all of them > > in 'pinctrl-rt2880.c' file. Pinctrl data was being passed in SoC initilization > > to the driver. Instead of doing that just move all related code to the driver > > itself. We maintain for all of them compatible string to avoid to make more > > changes in dts's an so on. If a new compatible string is neccessary to be > > defined for each different SoC, we can change them after this series are > > applied. > > > > I have only tested MT7621 platform using GNUBee PC1 board. I don't have > > other boards to test other SoC changes. > > > > This series are rebased on the master branch of linux-pinctrl git tree so > > I expect this to be merged through pinctrl tree. Thomas, if 'linux-mips' > > is preferred to merge this series just let me know and I can rebase them > > to make you things easier. > > > > Thanks in advance for your time. > > I have simply applied all patches so we get some testing in linux-next > (last time we found some snags through linux-next). Good! Let's see what happen, then :) > > This is an important modernization of the ralink SoCs so I > am pushing the fastforward button a bit. I also do believe that having moved all of this stuff from the arch headers to the driver itself is a very good step. > > If some ralink maintainer has opinions they can either patch it or > complain loudly so I can take the patches out again. Please, complain loudly if necessary :). As I said I only tested the changes for mt7621 SoC, so it might be something wrong there. > > Yours, > Linus Walleij Thanks! Sergio Paracuellos
Ralink architecture have all pinmux config for different SoCs in architecture headers. This SoCs configs are: - CONFIG_SOC_RT288X - CONFIG_SOC_RT305X - CONFIG_SOC_RT3883 - CONFIG_SOC_MT7620 - CONFIG_SOC_MT7621 We currently have 'drivers/pinctrl/ralink/' with common code to all of them in 'pinctrl-rt2880.c' file. Pinctrl data was being passed in SoC initilization to the driver. Instead of doing that just move all related code to the driver itself. We maintain for all of them compatible string to avoid to make more changes in dts's an so on. If a new compatible string is neccessary to be defined for each different SoC, we can change them after this series are applied. I have only tested MT7621 platform using GNUBee PC1 board. I don't have other boards to test other SoC changes. This series are rebased on the master branch of linux-pinctrl git tree so I expect this to be merged through pinctrl tree. Thomas, if 'linux-mips' is preferred to merge this series just let me know and I can rebase them to make you things easier. Thanks in advance for your time. Best regards, Sergio Paracuellos Sergio Paracuellos (6): pinctrl: ralink: move ralink architecture pinmux header into the driver pinctrl: ralink: move MT7621 SoC pinmux config into a new 'pinctrl-mt7621.c' file pinctrl: ralink: move RT3883 SoC pinmux config into a new 'pinctrl-rt3883.c' file pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file pinctrl: ralink: move RT288X SoC pinmux config into a new 'pinctrl-rt288x.c' file arch/mips/include/asm/mach-ralink/mt7620.h | 53 +- arch/mips/include/asm/mach-ralink/rt288x.h | 9 - arch/mips/include/asm/mach-ralink/rt305x.h | 24 - arch/mips/include/asm/mach-ralink/rt3883.h | 34 -- arch/mips/ralink/mt7620.c | 320 ------------ arch/mips/ralink/mt7621.c | 88 ---- arch/mips/ralink/prom.c | 1 - arch/mips/ralink/rt288x.c | 21 - arch/mips/ralink/rt305x.c | 77 --- arch/mips/ralink/rt3883.c | 45 -- drivers/pinctrl/ralink/Kconfig | 25 + drivers/pinctrl/ralink/Makefile | 6 + .../pinctrl/ralink/pinctrl-mt7620.c | 472 +++--------------- drivers/pinctrl/ralink/pinctrl-mt7621.c | 116 +++++ drivers/pinctrl/ralink/pinctrl-rt2880.c | 30 +- drivers/pinctrl/ralink/pinctrl-rt288x.c | 60 +++ drivers/pinctrl/ralink/pinctrl-rt305x.c | 136 +++++ drivers/pinctrl/ralink/pinctrl-rt3883.c | 107 ++++ .../pinctrl/ralink}/pinmux.h | 3 +- 19 files changed, 536 insertions(+), 1091 deletions(-) copy arch/mips/ralink/mt7620.c => drivers/pinctrl/ralink/pinctrl-mt7620.c (51%) create mode 100644 drivers/pinctrl/ralink/pinctrl-mt7621.c create mode 100644 drivers/pinctrl/ralink/pinctrl-rt288x.c create mode 100644 drivers/pinctrl/ralink/pinctrl-rt305x.c create mode 100644 drivers/pinctrl/ralink/pinctrl-rt3883.c rename {arch/mips/include/asm/mach-ralink => drivers/pinctrl/ralink}/pinmux.h (91%)